From: Dan Carpenter <dan.carpenter@linaro.org>
To: Peng Fan <peng.fan@nxp.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Cristian Marussi <cristian.marussi@arm.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
arm-scmi@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] firmware: imx: sm-misc: Dump syslog info
Date: Wed, 10 Sep 2025 19:10:05 +0300 [thread overview]
Message-ID: <aMGi3S2j_FHid3Sb@stanley.mountain> (raw)
In-Reply-To: <20250910-sm-syslog-v1-2-5b36f8f21da6@nxp.com>
On Wed, Sep 10, 2025 at 10:28:18PM +0800, Peng Fan wrote:
> static int scmi_imx_misc_ctrl_probe(struct scmi_device *sdev)
> {
> const struct scmi_handle *handle = sdev->handle;
> struct device_node *np = sdev->dev.of_node;
> + struct dentry *scmi_imx_dentry;
> u32 src_id, flags;
> int ret, i, num;
>
> @@ -98,6 +134,12 @@ static int scmi_imx_misc_ctrl_probe(struct scmi_device *sdev)
> }
> }
>
> + scmi_imx_dentry = debugfs_create_dir("scmi_imx", NULL);
> + if (!IS_ERR(scmi_imx_dentry))
> + debugfs_create_file("syslog", 0444, scmi_imx_dentry, &sdev->dev, &syslog_fops);
You don't need the IS_ERR() check. If debugfs_create_dir() fails then
just pass the error pointer to debugfs_create_file(), it's fine.
regards,
dan carpenter
> +
> + devm_add_action_or_reset(&sdev->dev, scmi_imx_misc_put, scmi_imx_dentry);
> +
> return 0;
> }
>
>
> --
> 2.37.1
>
next prev parent reply other threads:[~2025-09-10 16:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 14:28 [PATCH 0/2] firmware: arm_scmi/imx: Support dump syslog Peng Fan
2025-09-10 14:28 ` [PATCH 1/2] firmware: arm_scmi: imx: Support getting syslog of MISC protocol Peng Fan
2025-09-10 15:17 ` Frank Li
2025-09-11 5:46 ` Peng Fan
2025-09-10 14:28 ` [PATCH 2/2] firmware: imx: sm-misc: Dump syslog info Peng Fan
2025-09-10 15:25 ` Frank Li
2025-09-12 7:50 ` Peng Fan
2025-09-10 16:10 ` Dan Carpenter [this message]
2025-09-11 5:47 ` Peng Fan
2025-09-12 0:08 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMGi3S2j_FHid3Sb@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=arm-scmi@vger.kernel.org \
--cc=cristian.marussi@arm.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox