From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B268E23BCEF for ; Wed, 10 Sep 2025 18:29:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757528988; cv=none; b=JhY485z+HxhqtizPAL9uLKzty/OKoqNr05TOzl1H2870Mh/0EwmmL/O/KJhXtEahMuUs7kKqsdpUuXnHOxEHIP3uomfdXBEWdpncU1BIuUV2gaZmip6tvD25ZStsIyFgBtAkVvwMhU/hjTDqzx2PjxdZzmRKIKudZwNV0/++hnM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757528988; c=relaxed/simple; bh=O9ecuj8kRXRq6dEl5kGqSphF2XCxCU5mNbrki8VIT9o=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Ox0P+BzRWHac0ycubIAO9JiIVWVhxS/E9XYYQJnZBk2BKMTYwqGrE6m2S4zKb6x+k3eYOZhnkXV5H9hSpSXaX9y22iXrFwKeQebPKWtc2nXXsuixzIoxBojB7YKx1I66cqKPm2guDKibyVg1lGNVgfE3yKEVrvHULjvSK4PqaXU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=RVKJYhBQ; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="RVKJYhBQ" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-24c99bd543aso138352945ad.3 for ; Wed, 10 Sep 2025 11:29:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1757528986; x=1758133786; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=MtiDzw6RmLEmA2FOdaMw8DNJxzNAmIgO0MAX2XQmYOE=; b=RVKJYhBQ3KKjjezygxtC+yg9IzHXElg8NhaSR/vylxevedbQZ/F5Ab6Tf1kTLfErCE 4zoPwh4QbHFOc0yqYjmGhPfiZgDYwY6MoJL+SkljMVAxi0ItiAW6qfxY/deozg9XFxO6 arvJRYg01jZ0hHV2TXRZHUxpy41xqDGhw0wGW7GkUOeIeeANB7ab56+2mBweN96oAmgF Vfc+UoCcbPMS+/Bw1iARtZ2hQOKvfvzd8pkapeOmBmxSUupfgytqsdIz+FkDMvPtHm4A bCFh08JxwM0fx7smQfFfGIXjWinWZ2oX7G3tYOquALGCVBL6ggAlMwyrQ27MS4cADK8r O7OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757528986; x=1758133786; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MtiDzw6RmLEmA2FOdaMw8DNJxzNAmIgO0MAX2XQmYOE=; b=Uv4Tk4VHVCOg76fpP7rH6a3c3QeMJ2vtx9Lz7tmALp9yasdap8J9siuofsAjUcSApp FGQNgy5DpoVQqBpjczDf3zYqA1qHPZRy330Ny9A4chuufuJdnZ5jx//FmCiRP4cgH9T/ AyYcaPKy2sjZLNX3YreRhQi14HwO90mXqdncDsZwvSIP/7AgmaKonxl0IRX7qAQYxGo9 mT0qI36ra5/Qy9CkZ/hjbvDnmf/2X0w0hmTtZkP80bJscN7rTubKoUcacUSbJ1n36KcT 4uHFvWHZYhOUEytC9kQP7BJM0UAOpQvvgwTCCNXNyVyKNN4EXvi0YJZsQ5qSg+IJqIlk bouA== X-Forwarded-Encrypted: i=1; AJvYcCVagKlliD8G5PkHTdS87HzWvT8uhoiNMQAcRS4tnbaf98o4kJ1HWQjjBDHa6RXnRfufAUaT8cqnYVmQHzo=@vger.kernel.org X-Gm-Message-State: AOJu0YxusOPDHOpOh/s+dj7eJTCa7Vev0dO0s3fw0AmCH7boOmNbkDLj FBnRznFIHSfMoUaqqSLVH+VB02UhCAV21kwR+OYM4N/KjEv0Y19wQBUatLazoEem4miU0Zyp+yE EME41KQ== X-Google-Smtp-Source: AGHT+IHDAjtJnh2q/ezPGV1CwRbRlP2Vheml2ZcWOEaCBTqyS1/Lt4YX44JMxVa1LU+2TnaPjQioFqmGGcg= X-Received: from pjbkl5.prod.google.com ([2002:a17:90b:4985:b0:329:748c:a5af]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:184:b0:245:f2c2:64ed with SMTP id d9443c01a7336-2516f04efefmr243902875ad.24.1757528986042; Wed, 10 Sep 2025 11:29:46 -0700 (PDT) Date: Wed, 10 Sep 2025 11:29:44 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250909093953.202028-1-chao.gao@intel.com> Message-ID: Subject: Re: [PATCH v14 00/22] Enable CET Virtualization From: Sean Christopherson To: Chao Gao Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, acme@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, john.allen@amd.com, mingo@kernel.org, mingo@redhat.com, minipli@grsecurity.net, mlevitsk@redhat.com, namhyung@kernel.org, pbonzini@redhat.com, prsampat@amd.com, rick.p.edgecombe@intel.com, shuah@kernel.org, tglx@linutronix.de, x86@kernel.org, xin@zytor.com, xiaoyao.li@intel.com Content-Type: text/plain; charset="us-ascii" On Tue, Sep 09, 2025, Chao Gao wrote: > On Tue, Sep 09, 2025 at 02:39:31AM -0700, Chao Gao wrote: > >The FPU support for CET virtualization has already been merged into 6.17-rc1. > >Building on that, this series introduces Intel CET virtualization support for > >KVM. > > > >Changes in v14 > >1. rename the type of guest SSP register to KVM_X86_REG_KVM and add docs > > for register IDs in api.rst (Sean, Xiaoyao) > >2. update commit message of patch 1 > >3. use rdmsrq/wrmsrq() instead of rdmsrl/wrmsrl() in patch 6 (Xin) > >4. split the introduction of per-guest guest_supported_xss into a > >separate patch. (Xiaoyao) > >5. make guest FPU and VMCS consistent regarding MSR_IA32_S_CET > >6. collect reviews from Xiaoyao. > > (Removed Weijiang's Intel email as it is bouncing) Yeah, I'll try to remember to filter it out. I'll post a v15, I have a decent number of local changes and fixes (see responses, hopefully I captured everything), along with a more comprehensive selftest.