Re: [PATCH v2 2/2] ARM: rockchip: select ROCKCHIP_PM_DOMAINS

[Mikko Rapeli <mikko.rapeli@linaro.org>]

Hi,

On Fri, Sep 12, 2025 at 10:48:47AM +0200, Geert Uytterhoeven wrote:
> Hi Mikko,
> 
> On Fri, 12 Sept 2025 at 10:41, Mikko Rapeli <mikko.rapeli@linaro.org> wrote:
> > According to Heiko Stuebner <heiko@sntech.de> all SoCs
> > since 2012 have power domain support in HW and
> > ROCKCHIP_PM_DOMAINS should always be enabled.
> >
> > Suggested-by: Heiko Stuebner <heiko@sntech.de>
> > Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm/mach-rockchip/Kconfig
> > +++ b/arch/arm/mach-rockchip/Kconfig
> > @@ -14,6 +14,7 @@ config ARCH_ROCKCHIP
> >         select HAVE_ARM_TWD if SMP
> >         select DW_APB_TIMER_OF
> >         select REGULATOR if PM
> > +       select ROCKCHIP_PM_DOMAINS
> 
> This requires "select PM". Oh, that is done below (out-of-context).
> So the "if PM" above can be dropped.

Yes, it's selected just after the context. I can drop it from
"select REGULATOR" in v3.

I was not sure if the PM dependency should be there or not
also when it's explicitly selected.

Cheers,

-Mikko