From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: David Lechner <dlechner@baylibre.com>
Cc: "Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/6] iio: adc: ad7124: use guard(mutex) to simplify return paths
Date: Fri, 12 Sep 2025 20:15:21 +0300 [thread overview]
Message-ID: <aMRVKZGPv4PwR8-o@smile.fi.intel.com> (raw)
In-Reply-To: <d5e53a9c-418c-4c33-bbf4-b7d49d523cf2@baylibre.com>
On Fri, Sep 12, 2025 at 09:19:36AM -0500, David Lechner wrote:
> On 9/11/25 11:39 PM, Andy Shevchenko wrote:
> > On Fri, Sep 12, 2025 at 12:42 AM David Lechner <dlechner@baylibre.com> wrote:
> >>
> >> Use guard(mutex) in a couple of functions to allow direct returns. This
> >> simplifies the code a bit and will make later changes easier.
> >
> > From this and the patch it's unclear if cleanup.h was already there or
> > not. If not, this patch misses it, if yes, the commit message should
> > be different.
>
> cleanup.h is already there. I'm not sure what would need to be different
> in the commit message though.
I expect something like "finish converting the driver to use guard()()..."
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-09-12 17:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 21:41 [PATCH v2 0/6] iio: adc: ad7124: add filter support David Lechner
2025-09-11 21:42 ` [PATCH v2 1/6] iio: adc: ad7124: use clamp() David Lechner
2025-09-11 21:42 ` [PATCH v2 2/6] iio: adc: ad7124: use read_avail() for scale_available David Lechner
2025-09-11 21:42 ` [PATCH v2 3/6] iio: adc: ad7124: use guard(mutex) to simplify return paths David Lechner
2025-09-12 4:39 ` Andy Shevchenko
2025-09-12 14:19 ` David Lechner
2025-09-12 17:15 ` Andy Shevchenko [this message]
2025-09-12 17:41 ` David Lechner
2025-09-12 18:07 ` Andy Shevchenko
2025-09-13 13:40 ` Jonathan Cameron
2025-09-11 21:42 ` [PATCH v2 4/6] iio: adc: ad7124: support fractional sampling_frequency David Lechner
2025-09-12 4:45 ` Andy Shevchenko
2025-09-12 14:25 ` David Lechner
2025-09-11 21:42 ` [PATCH v2 5/6] iio: adc: ad7124: add filter support David Lechner
2025-09-12 4:49 ` Andy Shevchenko
2025-09-12 14:27 ` David Lechner
2025-09-13 13:42 ` Jonathan Cameron
2025-09-15 6:46 ` Andy Shevchenko
2025-09-11 21:42 ` [PATCH v2 6/6] iio: ABI: document "sinc4+rej60" filter_type David Lechner
2025-09-12 4:50 ` [PATCH v2 0/6] iio: adc: ad7124: add filter support Andy Shevchenko
2025-09-13 13:43 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMRVKZGPv4PwR8-o@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox