* [PATCH v3 1/4] pmdomain: rockchip: enable ROCKCHIP_PM_DOMAINS with ARCH_ROCKCHIP
2025-09-12 14:22 ` [PATCH v3 0/4] enable ROCKCHIP_PM_DOMAINS Mikko Rapeli
@ 2025-09-12 14:22 ` Mikko Rapeli
2025-09-12 14:53 ` Arnd Bergmann
2025-09-12 15:00 ` Heiko Stübner
2025-09-12 14:22 ` [PATCH v3 2/4] mmc: add COMPILE_TEST to multiple drivers Mikko Rapeli
` (3 subsequent siblings)
4 siblings, 2 replies; 14+ messages in thread
From: Mikko Rapeli @ 2025-09-12 14:22 UTC (permalink / raw)
To: linux-mmc
Cc: ulf.hansson, Heiko Stübner, linux-kernel, adrian.hunter,
victor.shih, ben.chuang, geert+renesas, angelogioacchino.delregno,
dlan, arnd, zhoubinbin, Mikko Rapeli
On rk3399 based rockpi4b, mounting rootfs from mmc fails unless
ROCKCHIP_PM_DOMAINS is enabled. Accoriding to
Heiko Stübner <heiko@sntech.de> all SoCs since 2012 have power
domains so the support should be enabled by default
on both arm and arm64.
Failing boot without CONFIG_ROCKCHIP_PM_DOMAINS=y:
https://ledge.validation.linaro.org/scheduler/job/119268
/dev/disk/by-partuuid/1d48ffd8-f2a7-4a33-b52f-186089b3c85e: Can't lookup blockdev
/dev/disk/by-partuuid/1d48ffd8-f2a7-4a33-b52f-186089b3c85e: Can't lookup blockdev
/dev/disk/by-partuuid/1d48ffd8-f2a7-4a33-b52f-186089b3c85e: Can't lookup blockdev
/dev/disk/by-partuuid/1d48ffd8-f2a7-4a33-b52f-186089b3c85e: Can't lookup blockdev
/dev/disk/by-partuuid/1d48ffd8-f2a7-4a33-b52f-186089b3c85e: Can't lookup blockdev
/dev/disk/by-partuuid/1d48ffd8-f2a7-4a33-b52f-186089b3c85e: Can't lookup blockdev
dw-apb-uart ff1a0000.serial: forbid DMA for kernel console
root '/dev/disk/by-partuuid/1d48ffd8-f2a7-4a33-b52f-186089b3c85e' doesn't exist or does not contain a /dev.
rk_gmac-dwmac fe300000.ethernet: deferred probe timeout, ignoring dependency
rk_gmac-dwmac fe300000.ethernet: probe with driver rk_gmac-dwmac failed with error -110
rk_iommu ff650800.iommu: deferred probe timeout, ignoring dependency
rk_iommu ff650800.iommu: probe with driver rk_iommu failed with error -110
dwmmc_rockchip fe320000.mmc: deferred probe timeout, ignoring dependency
rockchip-typec-phy ff7c0000.phy: deferred probe timeout, ignoring dependency
dwmmc_rockchip fe320000.mmc: probe with driver dwmmc_rockchip failed with error -110
rockchip-typec-phy ff7c0000.phy: probe with driver rockchip-typec-phy failed with error -110
rockchip-typec-phy ff800000.phy: deferred probe timeout, ignoring dependency
rockchip-typec-phy ff800000.phy: probe with driver rockchip-typec-phy failed with error -110
rk_iommu ff660480.iommu: deferred probe timeout, ignoring dependency
rk_iommu ff660480.iommu: probe with driver rk_iommu failed with error -110
rk_iommu ff8f3f00.iommu: deferred probe timeout, ignoring dependency
rk_iommu ff8f3f00.iommu: probe with driver rk_iommu failed with error -110
rk_iommu ff903f00.iommu: deferred probe timeout, ignoring dependency
rk_iommu ff903f00.iommu: probe with driver rk_iommu failed with error -110
rk_iommu ff914000.iommu: deferred probe timeout, ignoring dependency
rk_iommu ff914000.iommu: probe with driver rk_iommu failed with error -110
rk_iommu ff924000.iommu: deferred probe timeout, ignoring dependency
rk_iommu ff924000.iommu: probe with driver rk_iommu failed with error -110
platform fe800000.usb: deferred probe pending: platform: wait for supplier /phy@ff7c0000/usb3-port
sdhci-arasan fe330000.mmc: deferred probe timeout, ignoring dependency
platform fe900000.usb: deferred probe pending: platform: wait for supplier /phy@ff800000/usb3-port
sdhci-arasan fe330000.mmc: probe with driver sdhci-arasan failed with error -110
platform ff1d0000.spi: deferred probe pending: (reason unknown)
platform hdmi-sound: deferred probe pending: asoc-simple-card: parse error
Working boot with CONFIG_ROCKCHIP_PM_DOMAINS=y:
https://ledge.validation.linaro.org/scheduler/job/119272
dwmmc_rockchip fe320000.mmc: IDMAC supports 32-bit address mode.
dwmmc_rockchip fe320000.mmc: Using internal DMA controller.
dwmmc_rockchip fe320000.mmc: Version ID is 270a
dwmmc_rockchip fe320000.mmc: DW MMC controller at irq 45,32 bit host data width,256 deep fifo
dwmmc_rockchip fe320000.mmc: Got CD GPIO
ff1a0000.serial: ttyS2 at MMIO 0xff1a0000 (irq = 44, base_baud = 1500000) is a 16550A
printk: legacy console [ttyS2] enabled
mmc_host mmc1: Bus speed (slot 0) = 400000Hz (slot req 400000Hz, actual 400000HZ div = 0)
dw_wdt ff848000.watchdog: No valid TOPs array specified
mmc_host mmc1: Bus speed (slot 0) = 50000000Hz (slot req 50000000Hz, actual 50000000HZ div = 0)
mmc0: CQHCI version 5.10
rk_gmac-dwmac fe300000.ethernet: IRQ eth_wake_irq not found
mmc1: new high speed SDHC card at address aaaa
fan53555-regulator 0-0040: FAN53555 Option[8] Rev[1] Detected!
fan53555-regulator 0-0041: FAN53555 Option[8] Rev[1] Detected!
rk_gmac-dwmac fe300000.ethernet: IRQ eth_lpi not found
mmcblk1: mmc1:aaaa SC16G 14.8 GiB
rk_gmac-dwmac fe300000.ethernet: IRQ sfty not found
GPT:Primary header thinks Alt. header is not at the end of the disk.
rk_gmac-dwmac fe300000.ethernet: Deprecated MDIO bus assumption used
GPT:1978417 != 31116287
rk_gmac-dwmac fe300000.ethernet: PTP uses main clock
GPT:Alternate GPT header not at the end of the disk.
rk_gmac-dwmac fe300000.ethernet: clock input or output? (input).
GPT:1978417 != 31116287
rk_gmac-dwmac fe300000.ethernet: TX delay(0x28).
GPT: Use GNU Parted to correct GPT errors.
rk_gmac-dwmac fe300000.ethernet: RX delay(0x11).
mmcblk1: p1 p2 p3 p4 p5 p6 p7 p8
Suggested-by: Ulf Hansson <ulf.hansson@linaro.org>
Suggested-by: Heiko Stübner <heiko@sntech.de>
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
---
drivers/pmdomain/rockchip/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pmdomain/rockchip/Kconfig b/drivers/pmdomain/rockchip/Kconfig
index 218d43186e5b9..17f2e6fe86b6f 100644
--- a/drivers/pmdomain/rockchip/Kconfig
+++ b/drivers/pmdomain/rockchip/Kconfig
@@ -3,6 +3,7 @@ if ARCH_ROCKCHIP || COMPILE_TEST
config ROCKCHIP_PM_DOMAINS
bool "Rockchip generic power domain"
+ default ARCH_ROCKCHIP
depends on PM
depends on HAVE_ARM_SMCCC_DISCOVERY
depends on REGULATOR
--
2.34.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v3 1/4] pmdomain: rockchip: enable ROCKCHIP_PM_DOMAINS with ARCH_ROCKCHIP
2025-09-12 14:22 ` [PATCH v3 1/4] pmdomain: rockchip: enable ROCKCHIP_PM_DOMAINS with ARCH_ROCKCHIP Mikko Rapeli
@ 2025-09-12 14:53 ` Arnd Bergmann
2025-09-12 15:00 ` Heiko Stübner
1 sibling, 0 replies; 14+ messages in thread
From: Arnd Bergmann @ 2025-09-12 14:53 UTC (permalink / raw)
To: Mikko Rapeli, linux-mmc @ vger . kernel . org
Cc: Ulf Hansson, Heiko Stübner, linux-kernel, Adrian Hunter,
Victor Shih, Ben Chuang, Geert Uytterhoeven,
AngeloGioacchino Del Regno, Yixun Lan, Binbin Zhou
On Fri, Sep 12, 2025, at 16:22, Mikko Rapeli wrote:
> diff --git a/drivers/pmdomain/rockchip/Kconfig
> b/drivers/pmdomain/rockchip/Kconfig
> index 218d43186e5b9..17f2e6fe86b6f 100644
> --- a/drivers/pmdomain/rockchip/Kconfig
> +++ b/drivers/pmdomain/rockchip/Kconfig
> @@ -3,6 +3,7 @@ if ARCH_ROCKCHIP || COMPILE_TEST
>
> config ROCKCHIP_PM_DOMAINS
> bool "Rockchip generic power domain"
> + default ARCH_ROCKCHIP
> depends on PM
> depends on HAVE_ARM_SMCCC_DISCOVERY
> depends on REGULATOR
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 1/4] pmdomain: rockchip: enable ROCKCHIP_PM_DOMAINS with ARCH_ROCKCHIP
2025-09-12 14:22 ` [PATCH v3 1/4] pmdomain: rockchip: enable ROCKCHIP_PM_DOMAINS with ARCH_ROCKCHIP Mikko Rapeli
2025-09-12 14:53 ` Arnd Bergmann
@ 2025-09-12 15:00 ` Heiko Stübner
1 sibling, 0 replies; 14+ messages in thread
From: Heiko Stübner @ 2025-09-12 15:00 UTC (permalink / raw)
To: linux-mmc, Mikko Rapeli
Cc: ulf.hansson, linux-kernel, adrian.hunter, victor.shih, ben.chuang,
geert+renesas, angelogioacchino.delregno, dlan, arnd, zhoubinbin,
Mikko Rapeli
Am Freitag, 12. September 2025, 16:22:50 Mitteleuropäische Sommerzeit schrieb Mikko Rapeli:
> On rk3399 based rockpi4b, mounting rootfs from mmc fails unless
> ROCKCHIP_PM_DOMAINS is enabled. Accoriding to
> Heiko Stübner <heiko@sntech.de> all SoCs since 2012 have power
> domains so the support should be enabled by default
> on both arm and arm64.
>
> Failing boot without CONFIG_ROCKCHIP_PM_DOMAINS=y:
>
> https://ledge.validation.linaro.org/scheduler/job/119268
>
> /dev/disk/by-partuuid/1d48ffd8-f2a7-4a33-b52f-186089b3c85e: Can't lookup blockdev
> /dev/disk/by-partuuid/1d48ffd8-f2a7-4a33-b52f-186089b3c85e: Can't lookup blockdev
> /dev/disk/by-partuuid/1d48ffd8-f2a7-4a33-b52f-186089b3c85e: Can't lookup blockdev
> /dev/disk/by-partuuid/1d48ffd8-f2a7-4a33-b52f-186089b3c85e: Can't lookup blockdev
> /dev/disk/by-partuuid/1d48ffd8-f2a7-4a33-b52f-186089b3c85e: Can't lookup blockdev
> /dev/disk/by-partuuid/1d48ffd8-f2a7-4a33-b52f-186089b3c85e: Can't lookup blockdev
> dw-apb-uart ff1a0000.serial: forbid DMA for kernel console
> root '/dev/disk/by-partuuid/1d48ffd8-f2a7-4a33-b52f-186089b3c85e' doesn't exist or does not contain a /dev.
> rk_gmac-dwmac fe300000.ethernet: deferred probe timeout, ignoring dependency
> rk_gmac-dwmac fe300000.ethernet: probe with driver rk_gmac-dwmac failed with error -110
> rk_iommu ff650800.iommu: deferred probe timeout, ignoring dependency
> rk_iommu ff650800.iommu: probe with driver rk_iommu failed with error -110
> dwmmc_rockchip fe320000.mmc: deferred probe timeout, ignoring dependency
> rockchip-typec-phy ff7c0000.phy: deferred probe timeout, ignoring dependency
> dwmmc_rockchip fe320000.mmc: probe with driver dwmmc_rockchip failed with error -110
> rockchip-typec-phy ff7c0000.phy: probe with driver rockchip-typec-phy failed with error -110
> rockchip-typec-phy ff800000.phy: deferred probe timeout, ignoring dependency
> rockchip-typec-phy ff800000.phy: probe with driver rockchip-typec-phy failed with error -110
> rk_iommu ff660480.iommu: deferred probe timeout, ignoring dependency
> rk_iommu ff660480.iommu: probe with driver rk_iommu failed with error -110
> rk_iommu ff8f3f00.iommu: deferred probe timeout, ignoring dependency
> rk_iommu ff8f3f00.iommu: probe with driver rk_iommu failed with error -110
> rk_iommu ff903f00.iommu: deferred probe timeout, ignoring dependency
> rk_iommu ff903f00.iommu: probe with driver rk_iommu failed with error -110
> rk_iommu ff914000.iommu: deferred probe timeout, ignoring dependency
> rk_iommu ff914000.iommu: probe with driver rk_iommu failed with error -110
> rk_iommu ff924000.iommu: deferred probe timeout, ignoring dependency
> rk_iommu ff924000.iommu: probe with driver rk_iommu failed with error -110
> platform fe800000.usb: deferred probe pending: platform: wait for supplier /phy@ff7c0000/usb3-port
> sdhci-arasan fe330000.mmc: deferred probe timeout, ignoring dependency
> platform fe900000.usb: deferred probe pending: platform: wait for supplier /phy@ff800000/usb3-port
> sdhci-arasan fe330000.mmc: probe with driver sdhci-arasan failed with error -110
> platform ff1d0000.spi: deferred probe pending: (reason unknown)
> platform hdmi-sound: deferred probe pending: asoc-simple-card: parse error
>
> Working boot with CONFIG_ROCKCHIP_PM_DOMAINS=y:
>
> https://ledge.validation.linaro.org/scheduler/job/119272
>
> dwmmc_rockchip fe320000.mmc: IDMAC supports 32-bit address mode.
> dwmmc_rockchip fe320000.mmc: Using internal DMA controller.
> dwmmc_rockchip fe320000.mmc: Version ID is 270a
> dwmmc_rockchip fe320000.mmc: DW MMC controller at irq 45,32 bit host data width,256 deep fifo
> dwmmc_rockchip fe320000.mmc: Got CD GPIO
> ff1a0000.serial: ttyS2 at MMIO 0xff1a0000 (irq = 44, base_baud = 1500000) is a 16550A
> printk: legacy console [ttyS2] enabled
> mmc_host mmc1: Bus speed (slot 0) = 400000Hz (slot req 400000Hz, actual 400000HZ div = 0)
> dw_wdt ff848000.watchdog: No valid TOPs array specified
> mmc_host mmc1: Bus speed (slot 0) = 50000000Hz (slot req 50000000Hz, actual 50000000HZ div = 0)
> mmc0: CQHCI version 5.10
> rk_gmac-dwmac fe300000.ethernet: IRQ eth_wake_irq not found
> mmc1: new high speed SDHC card at address aaaa
> fan53555-regulator 0-0040: FAN53555 Option[8] Rev[1] Detected!
> fan53555-regulator 0-0041: FAN53555 Option[8] Rev[1] Detected!
> rk_gmac-dwmac fe300000.ethernet: IRQ eth_lpi not found
> mmcblk1: mmc1:aaaa SC16G 14.8 GiB
> rk_gmac-dwmac fe300000.ethernet: IRQ sfty not found
> GPT:Primary header thinks Alt. header is not at the end of the disk.
> rk_gmac-dwmac fe300000.ethernet: Deprecated MDIO bus assumption used
> GPT:1978417 != 31116287
> rk_gmac-dwmac fe300000.ethernet: PTP uses main clock
> GPT:Alternate GPT header not at the end of the disk.
> rk_gmac-dwmac fe300000.ethernet: clock input or output? (input).
> GPT:1978417 != 31116287
> rk_gmac-dwmac fe300000.ethernet: TX delay(0x28).
> GPT: Use GNU Parted to correct GPT errors.
> rk_gmac-dwmac fe300000.ethernet: RX delay(0x11).
> mmcblk1: p1 p2 p3 p4 p5 p6 p7 p8
>
> Suggested-by: Ulf Hansson <ulf.hansson@linaro.org>
> Suggested-by: Heiko Stübner <heiko@sntech.de>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
> ---
> drivers/pmdomain/rockchip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pmdomain/rockchip/Kconfig b/drivers/pmdomain/rockchip/Kconfig
> index 218d43186e5b9..17f2e6fe86b6f 100644
> --- a/drivers/pmdomain/rockchip/Kconfig
> +++ b/drivers/pmdomain/rockchip/Kconfig
> @@ -3,6 +3,7 @@ if ARCH_ROCKCHIP || COMPILE_TEST
>
> config ROCKCHIP_PM_DOMAINS
> bool "Rockchip generic power domain"
> + default ARCH_ROCKCHIP
> depends on PM
> depends on HAVE_ARM_SMCCC_DISCOVERY
> depends on REGULATOR
>
Acked-by: Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v3 2/4] mmc: add COMPILE_TEST to multiple drivers
2025-09-12 14:22 ` [PATCH v3 0/4] enable ROCKCHIP_PM_DOMAINS Mikko Rapeli
2025-09-12 14:22 ` [PATCH v3 1/4] pmdomain: rockchip: enable ROCKCHIP_PM_DOMAINS with ARCH_ROCKCHIP Mikko Rapeli
@ 2025-09-12 14:22 ` Mikko Rapeli
2025-09-12 14:53 ` Arnd Bergmann
2025-09-12 14:22 ` [PATCH v3 3/4] mmc: remove COMPILE_TEST from MMC_LOONGSON2 Mikko Rapeli
` (2 subsequent siblings)
4 siblings, 1 reply; 14+ messages in thread
From: Mikko Rapeli @ 2025-09-12 14:22 UTC (permalink / raw)
To: linux-mmc
Cc: ulf.hansson, Heiko Stübner, linux-kernel, adrian.hunter,
victor.shih, ben.chuang, geert+renesas, angelogioacchino.delregno,
dlan, arnd, zhoubinbin, Mikko Rapeli
These compile on x86_64 with =y and =m.
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
---
drivers/mmc/host/Kconfig | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 7232de1c06887..2db46291ae442 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -56,7 +56,7 @@ config MMC_STM32_SDMMC
config MMC_PXA
tristate "Intel PXA25x/26x/27x Multimedia Card Interface support"
- depends on ARCH_PXA
+ depends on ARCH_PXA || COMPILE_TEST
help
This selects the Intel(R) PXA(R) Multimedia card Interface.
If you have a PXA(R) platform with a Multimedia Card slot,
@@ -608,7 +608,7 @@ config MMC_SDHCI_MSM
config MMC_MXC
tristate "Freescale i.MX21/27/31 or MPC512x Multimedia Card support"
- depends on ARCH_MXC || PPC_MPC512x
+ depends on ARCH_MXC || PPC_MPC512x || COMPILE_TEST
help
This selects the Freescale i.MX21, i.MX27, i.MX31 or MPC512x
Multimedia Card Interface. If you have an i.MX or MPC512x platform
@@ -866,7 +866,7 @@ config MMC_DW_PCI
config MMC_DW_ROCKCHIP
tristate "Rockchip specific extensions for Synopsys DW Memory Card Interface"
- depends on MMC_DW && ARCH_ROCKCHIP
+ depends on MMC_DW && ( ARCH_ROCKCHIP || COMPILE_TEST )
select MMC_DW_PLTFM
help
This selects support for Rockchip SoC specific extensions to the
@@ -948,7 +948,7 @@ config MMC_USHC
config MMC_WMT
tristate "Wondermedia SD/MMC Host Controller support"
- depends on ARCH_VT8500
+ depends on ARCH_VT8500 || COMPILE_TEST
default y
help
This selects support for the SD/MMC Host Controller on
--
2.34.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v3 2/4] mmc: add COMPILE_TEST to multiple drivers
2025-09-12 14:22 ` [PATCH v3 2/4] mmc: add COMPILE_TEST to multiple drivers Mikko Rapeli
@ 2025-09-12 14:53 ` Arnd Bergmann
0 siblings, 0 replies; 14+ messages in thread
From: Arnd Bergmann @ 2025-09-12 14:53 UTC (permalink / raw)
To: Mikko Rapeli, linux-mmc @ vger . kernel . org
Cc: Ulf Hansson, Heiko Stübner, linux-kernel, Adrian Hunter,
Victor Shih, Ben Chuang, Geert Uytterhoeven,
AngeloGioacchino Del Regno, Yixun Lan, Binbin Zhou
On Fri, Sep 12, 2025, at 16:22, Mikko Rapeli wrote:
> These compile on x86_64 with =y and =m.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
I'll also add this to my randconfig tests to see if something
comes up.
> - depends on MMC_DW && ARCH_ROCKCHIP
> + depends on MMC_DW && ( ARCH_ROCKCHIP || COMPILE_TEST )
> select MMC_DW_PLTFM
The whitespace is unusual here, I would make this either
depends on MMC_DW && (ARCH_ROCKCHIP || COMPILE_TEST)
or
depends on MMC_DW
depends on ARCH_ROCKCHIP || COMPILE_TEST
Arnd
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v3 3/4] mmc: remove COMPILE_TEST from MMC_LOONGSON2
2025-09-12 14:22 ` [PATCH v3 0/4] enable ROCKCHIP_PM_DOMAINS Mikko Rapeli
2025-09-12 14:22 ` [PATCH v3 1/4] pmdomain: rockchip: enable ROCKCHIP_PM_DOMAINS with ARCH_ROCKCHIP Mikko Rapeli
2025-09-12 14:22 ` [PATCH v3 2/4] mmc: add COMPILE_TEST to multiple drivers Mikko Rapeli
@ 2025-09-12 14:22 ` Mikko Rapeli
2025-09-12 14:50 ` Arnd Bergmann
2025-09-13 4:58 ` Binbin Zhou
2025-09-12 14:22 ` [PATCH v3 4/4] ARM: rockchip: remove REGULATOR conditional to PM Mikko Rapeli
2025-09-12 14:36 ` [PATCH v3 0/4] enable ROCKCHIP_PM_DOMAINS Mikko Rapeli
4 siblings, 2 replies; 14+ messages in thread
From: Mikko Rapeli @ 2025-09-12 14:22 UTC (permalink / raw)
To: linux-mmc
Cc: ulf.hansson, Heiko Stübner, linux-kernel, adrian.hunter,
victor.shih, ben.chuang, geert+renesas, angelogioacchino.delregno,
dlan, arnd, zhoubinbin, Mikko Rapeli
It fails to link due to undeclared dependency
to regmap which is not enabled for COMPILE_TEST:
ERROR: modpost: "__devm_regmap_init_mmio_clk"
[drivers/mmc/host/loongson2-mmc.ko] undefined!
Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
---
drivers/mmc/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 2db46291ae442..e2d9a7cf9f855 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -1113,7 +1113,7 @@ config MMC_OWL
config MMC_LOONGSON2
tristate "Loongson-2K SD/SDIO/eMMC Host Interface support"
- depends on LOONGARCH || COMPILE_TEST
+ depends on LOONGARCH
depends on HAS_DMA
help
This selects support for the SD/SDIO/eMMC Host Controller on
--
2.34.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v3 3/4] mmc: remove COMPILE_TEST from MMC_LOONGSON2
2025-09-12 14:22 ` [PATCH v3 3/4] mmc: remove COMPILE_TEST from MMC_LOONGSON2 Mikko Rapeli
@ 2025-09-12 14:50 ` Arnd Bergmann
2025-09-15 7:01 ` Mikko Rapeli
2025-09-13 4:58 ` Binbin Zhou
1 sibling, 1 reply; 14+ messages in thread
From: Arnd Bergmann @ 2025-09-12 14:50 UTC (permalink / raw)
To: Mikko Rapeli, linux-mmc @ vger . kernel . org
Cc: Ulf Hansson, Heiko Stübner, linux-kernel, Adrian Hunter,
Victor Shih, Ben Chuang, Geert Uytterhoeven,
AngeloGioacchino Del Regno, Yixun Lan, Binbin Zhou
On Fri, Sep 12, 2025, at 16:22, Mikko Rapeli wrote:
> It fails to link due to undeclared dependency
> to regmap which is not enabled for COMPILE_TEST:
>
> ERROR: modpost: "__devm_regmap_init_mmio_clk"
> [drivers/mmc/host/loongson2-mmc.ko] undefined!
Nice catch! I assume my normal randconfig builds never
run into this because there is always something selecting
REGMAP_MMIO.
> config MMC_LOONGSON2
> tristate "Loongson-2K SD/SDIO/eMMC Host Interface support"
> - depends on LOONGARCH || COMPILE_TEST
> + depends on LOONGARCH
> depends on HAS_DMA
I would instead add 'select REGMAP_MMIO' here, which is what
we do for other drivers using this.
Arnd
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v3 3/4] mmc: remove COMPILE_TEST from MMC_LOONGSON2
2025-09-12 14:50 ` Arnd Bergmann
@ 2025-09-15 7:01 ` Mikko Rapeli
0 siblings, 0 replies; 14+ messages in thread
From: Mikko Rapeli @ 2025-09-15 7:01 UTC (permalink / raw)
To: Arnd Bergmann, Binbin Zhou
Cc: linux-mmc @ vger . kernel . org, Ulf Hansson, Heiko Stübner,
linux-kernel, Adrian Hunter, Victor Shih, Ben Chuang,
Geert Uytterhoeven, AngeloGioacchino Del Regno, Yixun Lan,
zhoubb.aaron
Hi,
On Fri, Sep 12, 2025 at 04:50:38PM +0200, Arnd Bergmann wrote:
> On Fri, Sep 12, 2025, at 16:22, Mikko Rapeli wrote:
> > It fails to link due to undeclared dependency
> > to regmap which is not enabled for COMPILE_TEST:
> >
> > ERROR: modpost: "__devm_regmap_init_mmio_clk"
> > [drivers/mmc/host/loongson2-mmc.ko] undefined!
>
> Nice catch! I assume my normal randconfig builds never
> run into this because there is always something selecting
> REGMAP_MMIO.
>
> > config MMC_LOONGSON2
> > tristate "Loongson-2K SD/SDIO/eMMC Host Interface support"
> > - depends on LOONGARCH || COMPILE_TEST
> > + depends on LOONGARCH
> > depends on HAS_DMA
>
> I would instead add 'select REGMAP_MMIO' here, which is what
> we do for other drivers using this.
On Sat, Sep 13, 2025 at 12:58:00PM +0800, Binbin Zhou wrote:
<snip>
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -1113,7 +1113,7 @@ config MMC_OWL
> > config MMC_LOONGSON2
> > tristate "Loongson-2K SD/SDIO/eMMC Host Interface support"
> > - depends on LOONGARCH || COMPILE_TEST
> > + depends on LOONGARCH
>
> How about add `select REGMAP_MMIO` instead.
Sorry, my bad. I just checked drivers/base/regmap/Kconfig for COMPILE_TEST
and since it was not found thought that it's not supported with
COMPILE_TEST.
I will add the REGMAP_MMIO dependency instead in v4.
Cheers,
-Mikko
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 3/4] mmc: remove COMPILE_TEST from MMC_LOONGSON2
2025-09-12 14:22 ` [PATCH v3 3/4] mmc: remove COMPILE_TEST from MMC_LOONGSON2 Mikko Rapeli
2025-09-12 14:50 ` Arnd Bergmann
@ 2025-09-13 4:58 ` Binbin Zhou
1 sibling, 0 replies; 14+ messages in thread
From: Binbin Zhou @ 2025-09-13 4:58 UTC (permalink / raw)
To: Mikko Rapeli, linux-mmc
Cc: ulf.hansson, Heiko Stübner, linux-kernel, adrian.hunter,
victor.shih, ben.chuang, geert+renesas, angelogioacchino.delregno,
dlan, arnd, zhoubb.aaron
Hi Mikko:
Thanks for your patch.
On 2025/9/12 22:22, Mikko Rapeli wrote:
> It fails to link due to undeclared dependency
> to regmap which is not enabled for COMPILE_TEST:
>
> ERROR: modpost: "__devm_regmap_init_mmio_clk"
> [drivers/mmc/host/loongson2-mmc.ko] undefined!
>
> Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 2db46291ae442..e2d9a7cf9f855 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -1113,7 +1113,7 @@ config MMC_OWL
>
> config MMC_LOONGSON2
> tristate "Loongson-2K SD/SDIO/eMMC Host Interface support"
> - depends on LOONGARCH || COMPILE_TEST
> + depends on LOONGARCH
How about add `select REGMAP_MMIO` instead.
> depends on HAS_DMA
> help
> This selects support for the SD/SDIO/eMMC Host Controller on
Thanks.
Binbin
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v3 4/4] ARM: rockchip: remove REGULATOR conditional to PM
2025-09-12 14:22 ` [PATCH v3 0/4] enable ROCKCHIP_PM_DOMAINS Mikko Rapeli
` (2 preceding siblings ...)
2025-09-12 14:22 ` [PATCH v3 3/4] mmc: remove COMPILE_TEST from MMC_LOONGSON2 Mikko Rapeli
@ 2025-09-12 14:22 ` Mikko Rapeli
2025-09-12 14:36 ` [PATCH v3 0/4] enable ROCKCHIP_PM_DOMAINS Mikko Rapeli
4 siblings, 0 replies; 14+ messages in thread
From: Mikko Rapeli @ 2025-09-12 14:22 UTC (permalink / raw)
To: linux-mmc
Cc: ulf.hansson, Heiko Stübner, linux-kernel, adrian.hunter,
victor.shih, ben.chuang, geert+renesas, angelogioacchino.delregno,
dlan, arnd, zhoubinbin, Mikko Rapeli, Geert Uytterhoeven
PM is explicitly enabled in lines just below so
REGULATOR can be too.
Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
---
arch/arm/mach-rockchip/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
index b7855cc665e94..c90193dd39283 100644
--- a/arch/arm/mach-rockchip/Kconfig
+++ b/arch/arm/mach-rockchip/Kconfig
@@ -13,7 +13,7 @@ config ARCH_ROCKCHIP
select HAVE_ARM_SCU if SMP
select HAVE_ARM_TWD if SMP
select DW_APB_TIMER_OF
- select REGULATOR if PM
+ select REGULATOR
select ROCKCHIP_TIMER
select ARM_GLOBAL_TIMER
select CLKSRC_ARM_GLOBAL_TIMER_SCHED_CLOCK
--
2.34.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v3 0/4] enable ROCKCHIP_PM_DOMAINS
2025-09-12 14:22 ` [PATCH v3 0/4] enable ROCKCHIP_PM_DOMAINS Mikko Rapeli
` (3 preceding siblings ...)
2025-09-12 14:22 ` [PATCH v3 4/4] ARM: rockchip: remove REGULATOR conditional to PM Mikko Rapeli
@ 2025-09-12 14:36 ` Mikko Rapeli
4 siblings, 0 replies; 14+ messages in thread
From: Mikko Rapeli @ 2025-09-12 14:36 UTC (permalink / raw)
To: linux-mmc, linux-pm, linux-arm-kernel, Russell King,
Heiko Stuebner, linux-rockchip
Cc: ulf.hansson, linux-kernel, adrian.hunter, victor.shih, ben.chuang,
geert+renesas, angelogioacchino.delregno, dlan, arnd, zhoubinbin,
Geert Uytterhoeven
Hi,
Sorry I did not use scripts/get_maintainers.pl correctly after
changes were moving from one susbsystem to another based on review
comments but I hope correct maintainers and lists have received
the patches now.
Cheers,
-Mikko
On Fri, Sep 12, 2025 at 05:22:49PM +0300, Mikko Rapeli wrote:
> Hi,
>
> MMC_DW_ROCKCHIP needs ROCKCHIP_PM_DOMAINS before MMC is detected
> on Rockchip rk3399 rockpi4b and similar devices. Make this dependency
> more visible, or the default with ARCH_ROCKCHIP if possible.
>
> v3: use "default ARCH_ROCKCHIP" in ROCKCHIP_PM_DOMAINS as suggested
> by Arnd Bergmann <arnd@arndb.de>, enable more MMC drivers for
> COMPILE_TEST and remove MMC_LOONGSON2 which doesn't link,
> remove PM dependency as suggested by
> Geert Uytterhoeven <geert@linux-m68k.org>
>
> v2: changed from "depend on" in MMC driver to "select" as default
> on ARCH_ROCKCHIP as suggested by Ulf and Heiko
> https://marc.info/?i=20250912084112.2795848-1-mikko.rapeli%20()%20linaro%20!%20org
>
> v1: https://lore.kernel.org/linux-mmc/20250911144313.2774171-1-mikko.rapeli@linaro.org/
>
> Mikko Rapeli (4):
> pmdomain: rockchip: enable ROCKCHIP_PM_DOMAINS with ARCH_ROCKCHIP
> mmc: add COMPILE_TEST to multiple drivers
> mmc: remove COMPILE_TEST from MMC_LOONGSON2
> ARM: rockchip: remove REGULATOR conditional to PM
>
> arch/arm/mach-rockchip/Kconfig | 2 +-
> drivers/mmc/host/Kconfig | 10 +++++-----
> drivers/pmdomain/rockchip/Kconfig | 1 +
> 3 files changed, 7 insertions(+), 6 deletions(-)
>
> --
> 2.34.1
>
On Fri, Sep 12, 2025 at 05:27:35PM +0300, Mikko Rapeli wrote:
> On rk3399 based rockpi4b, mounting rootfs from mmc fails unless
> ROCKCHIP_PM_DOMAINS is enabled. Accoriding to
> Heiko Stübner <heiko@sntech.de> all SoCs since 2012 have power
> domains so the support should be enabled by default
> on both arm and arm64.
>
> Failing boot without CONFIG_ROCKCHIP_PM_DOMAINS=y:
>
> https://ledge.validation.linaro.org/scheduler/job/119268
>
> /dev/disk/by-partuuid/1d48ffd8-f2a7-4a33-b52f-186089b3c85e: Can't lookup blockdev
> /dev/disk/by-partuuid/1d48ffd8-f2a7-4a33-b52f-186089b3c85e: Can't lookup blockdev
> /dev/disk/by-partuuid/1d48ffd8-f2a7-4a33-b52f-186089b3c85e: Can't lookup blockdev
> /dev/disk/by-partuuid/1d48ffd8-f2a7-4a33-b52f-186089b3c85e: Can't lookup blockdev
> /dev/disk/by-partuuid/1d48ffd8-f2a7-4a33-b52f-186089b3c85e: Can't lookup blockdev
> /dev/disk/by-partuuid/1d48ffd8-f2a7-4a33-b52f-186089b3c85e: Can't lookup blockdev
> dw-apb-uart ff1a0000.serial: forbid DMA for kernel console
> root '/dev/disk/by-partuuid/1d48ffd8-f2a7-4a33-b52f-186089b3c85e' doesn't exist or does not contain a /dev.
> rk_gmac-dwmac fe300000.ethernet: deferred probe timeout, ignoring dependency
> rk_gmac-dwmac fe300000.ethernet: probe with driver rk_gmac-dwmac failed with error -110
> rk_iommu ff650800.iommu: deferred probe timeout, ignoring dependency
> rk_iommu ff650800.iommu: probe with driver rk_iommu failed with error -110
> dwmmc_rockchip fe320000.mmc: deferred probe timeout, ignoring dependency
> rockchip-typec-phy ff7c0000.phy: deferred probe timeout, ignoring dependency
> dwmmc_rockchip fe320000.mmc: probe with driver dwmmc_rockchip failed with error -110
> rockchip-typec-phy ff7c0000.phy: probe with driver rockchip-typec-phy failed with error -110
> rockchip-typec-phy ff800000.phy: deferred probe timeout, ignoring dependency
> rockchip-typec-phy ff800000.phy: probe with driver rockchip-typec-phy failed with error -110
> rk_iommu ff660480.iommu: deferred probe timeout, ignoring dependency
> rk_iommu ff660480.iommu: probe with driver rk_iommu failed with error -110
> rk_iommu ff8f3f00.iommu: deferred probe timeout, ignoring dependency
> rk_iommu ff8f3f00.iommu: probe with driver rk_iommu failed with error -110
> rk_iommu ff903f00.iommu: deferred probe timeout, ignoring dependency
> rk_iommu ff903f00.iommu: probe with driver rk_iommu failed with error -110
> rk_iommu ff914000.iommu: deferred probe timeout, ignoring dependency
> rk_iommu ff914000.iommu: probe with driver rk_iommu failed with error -110
> rk_iommu ff924000.iommu: deferred probe timeout, ignoring dependency
> rk_iommu ff924000.iommu: probe with driver rk_iommu failed with error -110
> platform fe800000.usb: deferred probe pending: platform: wait for supplier /phy@ff7c0000/usb3-port
> sdhci-arasan fe330000.mmc: deferred probe timeout, ignoring dependency
> platform fe900000.usb: deferred probe pending: platform: wait for supplier /phy@ff800000/usb3-port
> sdhci-arasan fe330000.mmc: probe with driver sdhci-arasan failed with error -110
> platform ff1d0000.spi: deferred probe pending: (reason unknown)
> platform hdmi-sound: deferred probe pending: asoc-simple-card: parse error
>
> Working boot with CONFIG_ROCKCHIP_PM_DOMAINS=y:
>
> https://ledge.validation.linaro.org/scheduler/job/119272
>
> dwmmc_rockchip fe320000.mmc: IDMAC supports 32-bit address mode.
> dwmmc_rockchip fe320000.mmc: Using internal DMA controller.
> dwmmc_rockchip fe320000.mmc: Version ID is 270a
> dwmmc_rockchip fe320000.mmc: DW MMC controller at irq 45,32 bit host data width,256 deep fifo
> dwmmc_rockchip fe320000.mmc: Got CD GPIO
> ff1a0000.serial: ttyS2 at MMIO 0xff1a0000 (irq = 44, base_baud = 1500000) is a 16550A
> printk: legacy console [ttyS2] enabled
> mmc_host mmc1: Bus speed (slot 0) = 400000Hz (slot req 400000Hz, actual 400000HZ div = 0)
> dw_wdt ff848000.watchdog: No valid TOPs array specified
> mmc_host mmc1: Bus speed (slot 0) = 50000000Hz (slot req 50000000Hz, actual 50000000HZ div = 0)
> mmc0: CQHCI version 5.10
> rk_gmac-dwmac fe300000.ethernet: IRQ eth_wake_irq not found
> mmc1: new high speed SDHC card at address aaaa
> fan53555-regulator 0-0040: FAN53555 Option[8] Rev[1] Detected!
> fan53555-regulator 0-0041: FAN53555 Option[8] Rev[1] Detected!
> rk_gmac-dwmac fe300000.ethernet: IRQ eth_lpi not found
> mmcblk1: mmc1:aaaa SC16G 14.8 GiB
> rk_gmac-dwmac fe300000.ethernet: IRQ sfty not found
> GPT:Primary header thinks Alt. header is not at the end of the disk.
> rk_gmac-dwmac fe300000.ethernet: Deprecated MDIO bus assumption used
> GPT:1978417 != 31116287
> rk_gmac-dwmac fe300000.ethernet: PTP uses main clock
> GPT:Alternate GPT header not at the end of the disk.
> rk_gmac-dwmac fe300000.ethernet: clock input or output? (input).
> GPT:1978417 != 31116287
> rk_gmac-dwmac fe300000.ethernet: TX delay(0x28).
> GPT: Use GNU Parted to correct GPT errors.
> rk_gmac-dwmac fe300000.ethernet: RX delay(0x11).
> mmcblk1: p1 p2 p3 p4 p5 p6 p7 p8
>
> Suggested-by: Ulf Hansson <ulf.hansson@linaro.org>
> Suggested-by: Heiko Stübner <heiko@sntech.de>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
> ---
> drivers/pmdomain/rockchip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pmdomain/rockchip/Kconfig b/drivers/pmdomain/rockchip/Kconfig
> index 218d43186e5b9..17f2e6fe86b6f 100644
> --- a/drivers/pmdomain/rockchip/Kconfig
> +++ b/drivers/pmdomain/rockchip/Kconfig
> @@ -3,6 +3,7 @@ if ARCH_ROCKCHIP || COMPILE_TEST
>
> config ROCKCHIP_PM_DOMAINS
> bool "Rockchip generic power domain"
> + default ARCH_ROCKCHIP
> depends on PM
> depends on HAVE_ARM_SMCCC_DISCOVERY
> depends on REGULATOR
> --
> 2.34.1
>
On Fri, Sep 12, 2025 at 05:30:36PM +0300, Mikko Rapeli wrote:
> PM is explicitly enabled in lines just below so
> REGULATOR can be too.
>
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
> ---
> arch/arm/mach-rockchip/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
> index b7855cc665e94..c90193dd39283 100644
> --- a/arch/arm/mach-rockchip/Kconfig
> +++ b/arch/arm/mach-rockchip/Kconfig
> @@ -13,7 +13,7 @@ config ARCH_ROCKCHIP
> select HAVE_ARM_SCU if SMP
> select HAVE_ARM_TWD if SMP
> select DW_APB_TIMER_OF
> - select REGULATOR if PM
> + select REGULATOR
> select ROCKCHIP_TIMER
> select ARM_GLOBAL_TIMER
> select CLKSRC_ARM_GLOBAL_TIMER_SCHED_CLOCK
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 14+ messages in thread