From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F8282F0C5D for ; Mon, 15 Sep 2025 09:14:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757927678; cv=none; b=LJ+Bmbz3HeUrrUyVath5DmzY9kLe+rcB7VOuxf/eirbHss2yAu3qjsyp6aGso+GXDWbIOwn8cR2+FILlL3Ldjmyo5q36KuVY2kPXXqh63gieG4ND/yh50qfenKUcX6KqVjr2f6xUuPJoAQ8vz19JRtGFQqM/xrBuWQ3wwTjFzrE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757927678; c=relaxed/simple; bh=KmJnxss+MoY7NrV8YJ1jLGKE3+2RMVeAE6TDsl1qkWg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=caQqzbQCLFL+q3P61ve+sMxHiW0349upcKYy4EN+rFRR26tww6l1tJdsJ7MWJxNZv80kwyk90GNn1zEVFC6NUxKaiU9JkWC9uKdyajScK/sAboPY3dDgZ825HhVsGWdaEPGHy4n0cjeacNiKt1eXJbapKDLZMoKgCHkGOwSvwQQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=S3Bjprbw; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="S3Bjprbw" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-45dec1ae562so34916625e9.1 for ; Mon, 15 Sep 2025 02:14:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757927674; x=1758532474; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Aku+CpnvWW9zhF6+nPeIxknoBC5KeYin4IOVLZZ/1pw=; b=S3BjprbwnbQU6XcqP5P+Zvo7Aas9yso/B+OpSv9rTj/9QzlJC0VSumIHd1Y8DIczhp KtC53YgreatyzbudzsVo2WlawgN7P2goKo89P2d04wnqPeD4z8nlxXejUHTA3PT4mhzi iggN2G6vJ1jhxzyRhPYQlJDCdQplE8Jx+qGU+IHiuvV7NZ6E4mfsM70m3goEOvZsqLJJ 7erq4shgI54JCBitvnsAeIhkY/Ak30UyaMSVLpf38mniM1lz4bxucmozDehFtegbesZ2 vFS0LOEC3FrhWsKx1wiLgatz40s+jbZEJjl8ja8PUloldRbTx4UIrhBCm5lAtAG8sOxu ob4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757927674; x=1758532474; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Aku+CpnvWW9zhF6+nPeIxknoBC5KeYin4IOVLZZ/1pw=; b=OBBayNzEzvdoDdClWbmX3IrEPfXtJzAY66vNJq22azkQGvTXGjxMnnKM1WdoeY2+nm aayjMnYQ7hTTEQXchNK575yg1oa6kAEEThSymZq8Dd8y5LDzIhKUQTfrR5cpoprg8phV LUw0gkMwwGJwms4TIw8WN5EFzvdmseFJa9wAqXd1zQh/JqTeMdxmwtCz7KcJR0GxUAff bGTlzT8wESm81GXVAeHrP4W1zEEOfify1JsQz175sq63HW5u1t55BLQ/ulDlt0n6EHhl nrJrJFtGMcGIditslEbHDl+bKnECQimONNbR+WZ5Y54r42i9zfLMwVHq3Q9ks0bWd2kq 3tuA== X-Forwarded-Encrypted: i=1; AJvYcCVRnzuo26rMtnhIGh99euuKf3xakEc4eauAVrYWiR9Xur/ve8ZLYG6sm52up/BnfUgntHDDQXuL/DpxuG8=@vger.kernel.org X-Gm-Message-State: AOJu0Yzfd7a6ildkVguGOaVljYigDD5wybIe/enRBqboM/Aljf5k4x97 amou+bt8opKB3JQGvjCCp5Veu0MQOyzuG2qBkTrTVwlmLERWc1knqVsYrqLRLVaLtng= X-Gm-Gg: ASbGncvr4Pi8RR5TDO2Kh0YFL8O8OKOf7QErGWjWR2cXXK8F4dke01J+rDan7cLDTYN 8xMDMM4P/hOxwjzKsweQuysHaFa3s8qQYS8RhCDCo/Y8hlVvZ1XzjocPKrVEeAPXSQKwHNEc1Ja 9uex8Ge2BpYtASbGXoQ2EmcfPYLLYmfnN5vKNDDtoRuYeBciM09cievtd9HGyeWQDZgfoJgyXbk ZkBXi3vVZDYmJvvpRP5OXzALeFLbWjKuwMbyeF4zRgAPMXLdmZmI4blj0jnspEY3gMTbL+8RhHx +GfcDblKg588DY2a2guYAUFGpwXROr42NElu2OnJi4joultudLjqLI1m10cT2wuW33p+b8rQMGa DGmcNqUvNEm1UBueTcAtUemjadi8= X-Google-Smtp-Source: AGHT+IGfbN1nly0tHEF/LPKTpBacJhCDeNphPgRpeP/LXLn8yUoq10STJSdN75g2RpiF61gi81auIw== X-Received: by 2002:a05:600c:3b1f:b0:45c:b6fa:352e with SMTP id 5b1f17b1804b1-45f2130999emr113157655e9.18.1757927674493; Mon, 15 Sep 2025 02:14:34 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-45e017bfd14sm170533075e9.21.2025.09.15.02.14.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Sep 2025 02:14:34 -0700 (PDT) Date: Mon, 15 Sep 2025 12:14:28 +0300 From: Dan Carpenter To: Feng Chen Cc: Liang Yang , Xianwei Zhao , Mark Brown , linux-amlogic@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH next] spi: amlogic: Fix some error checking in aml_sfc_dma_buffer_setup() Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Sep 15, 2025 at 08:49:59AM +0300, Dan Carpenter wrote: > There was supposed to be a "ret = " assignment here but it was > accidentally left off so the error checking doesn't work. > > Fixes: 4670db6f32e9 ("spi: amlogic: add driver for Amlogic SPI Flash Controller") > Signed-off-by: Dan Carpenter > --- Sorry, I should have checked lore before I sent this. It's already been patched. regards, dan carpenter