From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: <lucas.demarchi@intel.com>, <thomas.hellstrom@linux.intel.com>,
<airlied@gmail.com>, <simona@ffwll.ch>,
<intel-xe@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
"Abaci Robot" <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next 2/2] drm/xe: Remove duplicated include in xe_tlb_inval.c
Date: Mon, 15 Sep 2025 08:36:39 -0400 [thread overview]
Message-ID: <aMgIV3JkpxyZKCkN@intel.com> (raw)
In-Reply-To: <20250915080647.669569-2-yang.lee@linux.alibaba.com>
On Mon, Sep 15, 2025 at 04:06:47PM +0800, Yang Li wrote:
> The header files xe_tlb_inval.h is included twice in xe_tlb_inval.c,
> so one inclusion of each can be removed.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=24706
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/gpu/drm/xe/xe_tlb_inval.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_tlb_inval.c b/drivers/gpu/drm/xe/xe_tlb_inval.c
> index e6e97b5a7b5c..41e80d609815 100644
> --- a/drivers/gpu/drm/xe/xe_tlb_inval.c
> +++ b/drivers/gpu/drm/xe/xe_tlb_inval.c
> @@ -17,7 +17,6 @@
> #include "xe_tlb_inval.h"
> #include "xe_mmio.h"
> #include "xe_pm.h"
> -#include "xe_tlb_inval.h"
in both patches, please remove the other occurence so we
keep the alphabetical order.
> #include "xe_trace.h"
>
> /**
> --
> 2.43.7
>
next prev parent reply other threads:[~2025-09-15 12:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 8:06 [PATCH -next 1/2] drm/xe: Remove duplicated include in xe_pt.c Yang Li
2025-09-15 8:06 ` [PATCH -next 2/2] drm/xe: Remove duplicated include in xe_tlb_inval.c Yang Li
2025-09-15 12:36 ` Rodrigo Vivi [this message]
2025-09-15 15:01 ` Lucas De Marchi
2025-09-15 14:58 ` [PATCH -next 1/2] drm/xe: Remove duplicated include in xe_pt.c Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMgIV3JkpxyZKCkN@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=abaci@linux.alibaba.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox