Re: [PATCH v4 16/28] iommu/arm-smmu-v3-kvm: Create array for hyp SMMUv3

Daniel Mentz
2025-09-09T18:31:00Z

On Tue, Aug 19, 2025 at 2:55 PM Mostafa Saleh <smostafa@google.com> wrote:
>
> + if (kvm_arm_smmu_array[i].mmio_size < SZ_128K) {
> + pr_err("SMMUv3(%s) has unsupported size(0x%lx)\n", np->name,
> + kvm_arm_smmu_array[i].mmio_size);

Use format specifier %pOF to print device tree node.
If mmio_size is a size_t type, use format specifier %zx.
Align language of error message with kernel driver which prints "MMIO
region too small (%pr)\n".
I'm wondering if we should use kvm_err instead of pr_err.