Re: [PATCH bpf-next v3 01/14] selftests/bpf: test_xsk: Split xskxceiver

Bastien Curutchet
2025-09-17T15:28:47Z

Hi Maciej,

On 9/16/25 4:21 PM, Maciej Fijalkowski wrote:
> On Thu, Sep 04, 2025 at 12:10:16PM +0200, Bastien Curutchet (eBPF Foundation) wrote:
>> AF_XDP features are tested by the test_xsk.sh script but not by the
>> test_progs framework. The tests used by the script are defined in
>> xksxceiver.c which can't be integrated in the test_progs framework as is.
>>
>> Extract these test definitions from xskxceiver{.c/.h} to put them in new
>> test_xsk{.c/.h} files.
>> Keep the main() function and its unshared dependencies in xksxceiver to
>> avoid impacting the test_xsk.sh script which is often used to test real
>> hardware.
>>
>> Signed-off-by: Bastien Curutchet (eBPF Foundation) <bastien.curutchet@bootlin.com>
>> ---
>
> Hi Bastien,
>
> after this patch the way summary is reported is different.
>
> Before:
> # 16 skipped test(s) detected. Consider enabling relevant config options to improve coverage.
> # Totals: pass:53 fail:3 xfail:0 xpass:0 skip:16 error:0
>
> After:
> # Planned tests != run tests (72 != 53)
> # Totals: pass:53 fail:0 xfail:0 xpass:0 skip:0 error:0
>
> We lose the count of failed tests. Could you take a look?

Good catch, I'll take a look at it.

Best regards,
--
Bastien Curutchet, Bootlin
Embedded Linux and Kernel engineering