* [PATCH] nvme-pci: Add TUXEDO IBS Gen8 to Samsung sleep quirk
@ 2025-07-01 20:55 Werner Sembach
2025-07-03 11:45 ` Christoph Hellwig
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Werner Sembach @ 2025-07-01 20:55 UTC (permalink / raw)
To: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg
Cc: Georg Gottleuber, Werner Sembach, linux-nvme, linux-kernel
From: Georg Gottleuber <ggo@tuxedocomputers.com>
On the TUXEDO InfinityBook S Gen8, a Samsung 990 Evo NVMe leads to
a high power consumption in s2idle sleep (3.5 watts).
This patch applies 'Force No Simple Suspend' quirk to achieve a sleep with
a lower power consumption, typically around 1 watts.
Signed-off-by: Georg Gottleuber <ggo@tuxedocomputers.com>
Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
Cc: stable@vger.kernel.org
---
drivers/nvme/host/pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 8ff12e415cb5d..d677080e67d33 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3198,10 +3198,12 @@ static unsigned long check_vendor_combination_bug(struct pci_dev *pdev)
* Exclude Samsung 990 Evo from NVME_QUIRK_SIMPLE_SUSPEND
* because of high power consumption (> 2 Watt) in s2idle
* sleep. Only some boards with Intel CPU are affected.
+ * (Note for testing: Samsung 990 Evo Plus has same PCI ID)
*/
if (dmi_match(DMI_BOARD_NAME, "DN50Z-140HC-YD") ||
dmi_match(DMI_BOARD_NAME, "GMxPXxx") ||
dmi_match(DMI_BOARD_NAME, "GXxMRXx") ||
+ dmi_match(DMI_BOARD_NAME, "NS5X_NS7XAU") ||
dmi_match(DMI_BOARD_NAME, "PH4PG31") ||
dmi_match(DMI_BOARD_NAME, "PH4PRX1_PH6PRX1") ||
dmi_match(DMI_BOARD_NAME, "PH6PG01_PH6PG71"))
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] nvme-pci: Add TUXEDO IBS Gen8 to Samsung sleep quirk
2025-07-01 20:55 [PATCH] nvme-pci: Add TUXEDO IBS Gen8 to Samsung sleep quirk Werner Sembach
@ 2025-07-03 11:45 ` Christoph Hellwig
2025-07-03 12:58 ` Georg Gottleuber
2025-08-25 16:07 ` Werner Sembach
2025-09-16 18:16 ` Keith Busch
2 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2025-07-03 11:45 UTC (permalink / raw)
To: Werner Sembach
Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg,
Georg Gottleuber, linux-nvme, linux-kernel
On Tue, Jul 01, 2025 at 10:55:49PM +0200, Werner Sembach wrote:
> From: Georg Gottleuber <ggo@tuxedocomputers.com>
>
> On the TUXEDO InfinityBook S Gen8, a Samsung 990 Evo NVMe leads to
> a high power consumption in s2idle sleep (3.5 watts).
>
> This patch applies 'Force No Simple Suspend' quirk to achieve a sleep with
> a lower power consumption, typically around 1 watts.
Why do we keep getting more and more of these quirks instead of
getting the issue root caused and fixed?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nvme-pci: Add TUXEDO IBS Gen8 to Samsung sleep quirk
2025-07-03 11:45 ` Christoph Hellwig
@ 2025-07-03 12:58 ` Georg Gottleuber
0 siblings, 0 replies; 6+ messages in thread
From: Georg Gottleuber @ 2025-07-03 12:58 UTC (permalink / raw)
To: Christoph Hellwig, Werner Sembach
Cc: Keith Busch, Jens Axboe, Sagi Grimberg, Georg Gottleuber,
linux-nvme, linux-kernel, Christoffer Sandberg
Am 03.07.25 um 13:45 schrieb Christoph Hellwig:
> On Tue, Jul 01, 2025 at 10:55:49PM +0200, Werner Sembach wrote:
>> From: Georg Gottleuber <ggo@tuxedocomputers.com>
>>
>> On the TUXEDO InfinityBook S Gen8, a Samsung 990 Evo NVMe leads
>> to a high power consumption in s2idle sleep (3.5 watts).
>>
>> This patch applies 'Force No Simple Suspend' quirk to achieve a
>> sleep with a lower power consumption, typically around 1 watts.
>
> Why do we keep getting more and more of these quirks instead of
> getting the issue root caused and fixed?
>
Hi, it is not a new quirk but another device. For me the real question
is: Why is NVME_QUIRK_SIMPLE_SUSPEND apparently used for nearly all
NVMes. This is no longer a quirk, but rather the new default.
For some device combinations, it just works better without this quirk.
That's why I set NVME_QUIRK_FORCE_NO_SIMPLE_SUSPEND.
Best regards,
Georg
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nvme-pci: Add TUXEDO IBS Gen8 to Samsung sleep quirk
2025-07-01 20:55 [PATCH] nvme-pci: Add TUXEDO IBS Gen8 to Samsung sleep quirk Werner Sembach
2025-07-03 11:45 ` Christoph Hellwig
@ 2025-08-25 16:07 ` Werner Sembach
2025-09-16 16:49 ` Werner Sembach
2025-09-16 18:16 ` Keith Busch
2 siblings, 1 reply; 6+ messages in thread
From: Werner Sembach @ 2025-08-25 16:07 UTC (permalink / raw)
To: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg
Cc: Georg Gottleuber, linux-nvme, linux-kernel
Hi
Am 01.07.25 um 22:55 schrieb Werner Sembach:
> From: Georg Gottleuber <ggo@tuxedocomputers.com>
>
> On the TUXEDO InfinityBook S Gen8, a Samsung 990 Evo NVMe leads to
> a high power consumption in s2idle sleep (3.5 watts).
>
> This patch applies 'Force No Simple Suspend' quirk to achieve a sleep with
> a lower power consumption, typically around 1 watts.
>
> Signed-off-by: Georg Gottleuber <ggo@tuxedocomputers.com>
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> Cc: stable@vger.kernel.org
gentle bump for this not to be forgotten
> ---
> drivers/nvme/host/pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 8ff12e415cb5d..d677080e67d33 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3198,10 +3198,12 @@ static unsigned long check_vendor_combination_bug(struct pci_dev *pdev)
> * Exclude Samsung 990 Evo from NVME_QUIRK_SIMPLE_SUSPEND
> * because of high power consumption (> 2 Watt) in s2idle
> * sleep. Only some boards with Intel CPU are affected.
> + * (Note for testing: Samsung 990 Evo Plus has same PCI ID)
> */
> if (dmi_match(DMI_BOARD_NAME, "DN50Z-140HC-YD") ||
> dmi_match(DMI_BOARD_NAME, "GMxPXxx") ||
> dmi_match(DMI_BOARD_NAME, "GXxMRXx") ||
> + dmi_match(DMI_BOARD_NAME, "NS5X_NS7XAU") ||
> dmi_match(DMI_BOARD_NAME, "PH4PG31") ||
> dmi_match(DMI_BOARD_NAME, "PH4PRX1_PH6PRX1") ||
> dmi_match(DMI_BOARD_NAME, "PH6PG01_PH6PG71"))
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nvme-pci: Add TUXEDO IBS Gen8 to Samsung sleep quirk
2025-08-25 16:07 ` Werner Sembach
@ 2025-09-16 16:49 ` Werner Sembach
0 siblings, 0 replies; 6+ messages in thread
From: Werner Sembach @ 2025-09-16 16:49 UTC (permalink / raw)
To: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg
Cc: Georg Gottleuber, linux-nvme, linux-kernel
Am 25.08.25 um 18:07 schrieb Werner Sembach:
> Hi
>
> Am 01.07.25 um 22:55 schrieb Werner Sembach:
>> From: Georg Gottleuber <ggo@tuxedocomputers.com>
>>
>> On the TUXEDO InfinityBook S Gen8, a Samsung 990 Evo NVMe leads to
>> a high power consumption in s2idle sleep (3.5 watts).
>>
>> This patch applies 'Force No Simple Suspend' quirk to achieve a sleep with
>> a lower power consumption, typically around 1 watts.
>>
>> Signed-off-by: Georg Gottleuber <ggo@tuxedocomputers.com>
>> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
>> Cc: stable@vger.kernel.org
> gentle bump for this not to be forgotten
bump again
>> ---
>> drivers/nvme/host/pci.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
>> index 8ff12e415cb5d..d677080e67d33 100644
>> --- a/drivers/nvme/host/pci.c
>> +++ b/drivers/nvme/host/pci.c
>> @@ -3198,10 +3198,12 @@ static unsigned long
>> check_vendor_combination_bug(struct pci_dev *pdev)
>> * Exclude Samsung 990 Evo from NVME_QUIRK_SIMPLE_SUSPEND
>> * because of high power consumption (> 2 Watt) in s2idle
>> * sleep. Only some boards with Intel CPU are affected.
>> + * (Note for testing: Samsung 990 Evo Plus has same PCI ID)
>> */
>> if (dmi_match(DMI_BOARD_NAME, "DN50Z-140HC-YD") ||
>> dmi_match(DMI_BOARD_NAME, "GMxPXxx") ||
>> dmi_match(DMI_BOARD_NAME, "GXxMRXx") ||
>> + dmi_match(DMI_BOARD_NAME, "NS5X_NS7XAU") ||
>> dmi_match(DMI_BOARD_NAME, "PH4PG31") ||
>> dmi_match(DMI_BOARD_NAME, "PH4PRX1_PH6PRX1") ||
>> dmi_match(DMI_BOARD_NAME, "PH6PG01_PH6PG71"))
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nvme-pci: Add TUXEDO IBS Gen8 to Samsung sleep quirk
2025-07-01 20:55 [PATCH] nvme-pci: Add TUXEDO IBS Gen8 to Samsung sleep quirk Werner Sembach
2025-07-03 11:45 ` Christoph Hellwig
2025-08-25 16:07 ` Werner Sembach
@ 2025-09-16 18:16 ` Keith Busch
2 siblings, 0 replies; 6+ messages in thread
From: Keith Busch @ 2025-09-16 18:16 UTC (permalink / raw)
To: Werner Sembach
Cc: Jens Axboe, Christoph Hellwig, Sagi Grimberg, Georg Gottleuber,
linux-nvme, linux-kernel
On Tue, Jul 01, 2025 at 10:55:49PM +0200, Werner Sembach wrote:
> From: Georg Gottleuber <ggo@tuxedocomputers.com>
>
> On the TUXEDO InfinityBook S Gen8, a Samsung 990 Evo NVMe leads to
> a high power consumption in s2idle sleep (3.5 watts).
>
> This patch applies 'Force No Simple Suspend' quirk to achieve a sleep with
> a lower power consumption, typically around 1 watts.
Applied to nvme-6.18, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-09-16 18:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-01 20:55 [PATCH] nvme-pci: Add TUXEDO IBS Gen8 to Samsung sleep quirk Werner Sembach
2025-07-03 11:45 ` Christoph Hellwig
2025-07-03 12:58 ` Georg Gottleuber
2025-08-25 16:07 ` Werner Sembach
2025-09-16 16:49 ` Werner Sembach
2025-09-16 18:16 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox