Re: [PATCH v2] KVM: TDX: Force split irqchip for TDX at irqchip creation time

Sean Christopherson
2025-09-16T19:59:35Z

On Tue, Sep 16, 2025, Xiaoyao Li wrote:
> On 9/16/2025 8:25 AM, Sean Christopherson wrote:
> > On Tue, 26 Aug 2025 18:17:26 -0700, Sagi Shahar wrote:
> > > TDX module protects the EOI-bitmap which prevents the use of in-kernel
> > > I/O APIC. See more details in the original patch [1]
> > >
> > > The current implementation already enforces the use of split irqchip for
> > > TDX but it does so at the vCPU creation time which is generally to late
> > > to fallback to split irqchip.
> > >
> > > [...]
> >
> > Applied to kvm-x86 misc, thanks!
>
> The latest one of this patch is v4:
>
> https://lore.kernel.org/all/20250904062007.622530-1-sagis@google.com/

Yeah, I had applied v2 quite some time ago, just took me a while to do final
testing and send the "thank you".

> > [1/1] KVM: TDX: Force split irqchip for TDX at irqchip creation time
> > https://github.com/kvm-x86/linux/commit/2569c8c5767b
>
> What got queued, added a superfluous new line in tdx_vm_init()

Drat. I force pushed to fix that goof, and added Kai's Acked-by in the process.

[1/1] KVM: TDX: Reject fully in-kernel irqchip if EOIs are protected, i.e. for TDX VMs