From: Tejun Heo <tj@kernel.org>
To: Andrea Righi <arighi@nvidia.com>
Cc: David Vernet <void@manifault.com>,
Changwoo Min <changwoo@igalia.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, sched-ext@lists.linux.dev
Subject: Re: [PATCH sched_ext/for-6.17-fixes] sched_ext, sched/core: Fix build failure when !FAIR_GROUP_SCHED && EXT_GROUP_SCHED
Date: Tue, 16 Sep 2025 23:09:24 -1000 [thread overview]
Message-ID: <aMp6xLmp_h_Xa1ly@slm.duckdns.org> (raw)
In-Reply-To: <aMpRDcIhrnx2ZaIr@gpd4>
On Wed, Sep 17, 2025 at 08:11:25AM +0200, Andrea Righi wrote:
> On Tue, Sep 16, 2025 at 11:06:42AM -1000, Tejun Heo wrote:
> > While collecting SCX related fields in struct task_group into struct
> > scx_task_group, 6e6558a6bc41 ("sched_ext, sched/core: Factor out struct
> > scx_task_group") forgot update tg->scx_weight usage in tg_weight(), which
> > leads to build failure when CONFIG_FAIR_GROUP_SCHED is disabled but
> > CONFIG_EXT_GROUP_SCHED is enabled. Fix it.
> >
> > Fixes: 6e6558a6bc41 ("sched_ext, sched/core: Factor out struct scx_task_group")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202509170230.MwZsJSWa-lkp@intel.com/
>
> Missing SoB line? Apart than that LGTM.
Oops, yeah.
> Tested-by: Andrea Righi <arighi@nvidia.com>
Applied with the tags added.
Thanks.
--
tejun
prev parent reply other threads:[~2025-09-17 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 21:06 [PATCH sched_ext/for-6.17-fixes] sched_ext, sched/core: Fix build failure when !FAIR_GROUP_SCHED && EXT_GROUP_SCHED Tejun Heo
2025-09-17 6:11 ` Andrea Righi
2025-09-17 9:09 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMp6xLmp_h_Xa1ly@slm.duckdns.org \
--to=tj@kernel.org \
--cc=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=sched-ext@lists.linux.dev \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox