Re: [PATCH v11 1/3] dt-bindings: iio: adc: add max14001

Conor Dooley
2025-09-16T19:21:04Z

[-- Attachment #1: Type: text/plain, Size: 1647 bytes --]

On Tue, Sep 16, 2025 at 11:40:47AM -0500, David Lechner wrote:
> On 9/15/25 5:16 PM, Marilene Andrade Garcia wrote:

> >
> > The MAX14001 and MAX14002 both have the COUT output pin and the FAULT
> > output pin, and work the same. I have decided to declare them as interrupts
> > because I think some action should be done when they are hit. However, the
> > implementation of these features is not present in the v11 driver code, as
> > it was not in v9. But I plan to submit it in the next steps.
>
> The devicetree bindings should be as complete as possible and not care
> if the driver doesn't use everything. So adding them now is the right
> thing to do.

> > + interrupts:
> > + minItems: 1
> > + items:
> > + - description: |
> > + Asserts high when ADC readings exceed the upper threshold and low
> > + when below the lower threshold. Must be connected to the COUT pin.
> > + - description: |
> > + Alert output that asserts low during a number of different error
> > + conditions. The interrupt source must be attached to FAULT pin.

These descriptions read wrong to me. They __are__ the COUT and FAULT
pins, given what David responded to above, not something that can be
connected to these pins (if they were, they would be represented as
-gpios rather than interrupts most likely). Unless you mean that these
pins can have some other use and are only available on the COUT/FAULT
pins when some register value is set - but even in that case saying
"must be" doesn't fit since the interrupt property could be used to
configure the device accordingly.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]