From: Ian Ray <ian.ray@gehealthcare.com>
To: Marcus Folkesson <marcus.folkesson@gmail.com>
Cc: Support Opensource <support.opensource@diasemi.com>,
Lee Jones <lee@kernel.org>, Axel Lin <axel.lin@ingics.com>,
Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
linux-kernel@vger.kernel.org, ian.ray@gehealthcare.com
Subject: Re: [PATCH v2] mfd: da9052-spi: change read-mask to write-mask
Date: Wed, 1 Oct 2025 16:03:37 +0300 [thread overview]
Message-ID: <aN0mqU75onKEYSDg@zeus> (raw)
In-Reply-To: <20240925-da9052-v2-1-f243e4505b07@gmail.com>
Hello Marcus,
On Wed, Sep 25, 2024 at 12:19:53PM +0200, Marcus Folkesson wrote:
> Driver has mixed up the R/W bit.
> The LSB bit is set on write rather than read.
> Change it to avoid nasty things to happen.
>
> Fixes: e9e9d3973594 ("mfd: da9052: Avoid setting read_flag_mask for da9052-i2c driver")
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Your patch breaks DA9053 SPI communication (for me, at least) on the
6.1.y branch (I have not tested on master).
The datasheets [1] and [2] both refer to R/Wn in the SPI signalling.
What led to the assertion that "The LSB bit is set on write rather
than read."?
In the original code "config.read_flag_mask = 1;", is OR'd into the
buffer in regmap_set_work_buf_flag_mask. This sets the "R" bit as
expected.
[1] DA9052 CFR0011-120-00 Rev 5, Revision 2.5, 13-Feb-2017, page 67.
[2] DA9053 DA9053-00-IDS2n_131017, page 54.
Blue skies,
Ian
next prev parent reply other threads:[~2025-10-01 13:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 10:19 [PATCH v2] mfd: da9052-spi: change read-mask to write-mask Marcus Folkesson
2024-10-09 13:31 ` (subset) " Lee Jones
2025-10-01 13:03 ` Ian Ray [this message]
2025-10-02 7:23 ` Marcus Folkesson
2025-10-02 7:49 ` Ian Ray
2025-10-02 7:56 ` Marcus Folkesson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aN0mqU75onKEYSDg@zeus \
--to=ian.ray@gehealthcare.com \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=axel.lin@ingics.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.folkesson@gmail.com \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox