From: Elle Rhumsaa <elle@weathered-steel.dev>
To: Michal Wilczynski <m.wilczynski@samsung.com>
Cc: "Uwe Kleine-König" <ukleinek@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Guo Ren" <guoren@kernel.org>, "Fu Wei" <wefu@redhat.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti.fr>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Benno Lossin" <lossin@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Drew Fustini" <fustini@kernel.org>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
rust-for-linux@vger.kernel.org, linux-riscv@lists.infradead.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v15 7/7] riscv: dts: thead: Add PWM fan and thermal control
Date: Wed, 1 Oct 2025 21:00:18 +0000 [thread overview]
Message-ID: <aN2WYmcYHHZSccPm@archiso> (raw)
In-Reply-To: <20250930-rust-next-pwm-working-fan-for-sending-v15-7-5661c3090877@samsung.com>
On Tue, Sep 30, 2025 at 02:20:38PM +0200, Michal Wilczynski wrote:
> Add Device Tree nodes to enable a PWM controlled fan and it's associated
> thermal management for the Lichee Pi 4A board.
>
> This enables temperature-controlled active cooling for the Lichee Pi 4A
> board based on SoC temperature.
>
> Reviewed-by: Drew Fustini <fustini@kernel.org>
> Tested-by: Drew Fustini <fustini@kernel.org>
> Reviewed-by: Elle Rhumsaa <elle@weathered-steel.dev>
> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
> ---
> arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts | 67 +++++++++++++++++++++++
> 1 file changed, 67 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts b/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
> index 4020c727f09e8e2286fdc7fecd79dbd8eba69556..c58c2085ca92a3234f1350500cedae4157f0c35f 100644
> --- a/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
> +++ b/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
> @@ -28,9 +28,76 @@ aliases {
> chosen {
> stdout-path = "serial0:115200n8";
> };
> +
> + thermal-zones {
> + cpu-thermal {
> + polling-delay = <1000>;
> + polling-delay-passive = <1000>;
> + thermal-sensors = <&pvt 0>;
> +
> + trips {
> + fan_config0: fan-trip0 {
> + temperature = <39000>;
> + hysteresis = <5000>;
> + type = "active";
> + };
> +
> + fan_config1: fan-trip1 {
> + temperature = <50000>;
> + hysteresis = <5000>;
> + type = "active";
> + };
> +
> + fan_config2: fan-trip2 {
> + temperature = <60000>;
> + hysteresis = <5000>;
> + type = "active";
> + };
> + };
> +
> + cooling-maps {
> + map-active-0 {
> + cooling-device = <&fan 1 1>;
> + trip = <&fan_config0>;
> + };
> +
> + map-active-1 {
> + cooling-device = <&fan 2 2>;
> + trip = <&fan_config1>;
> + };
> +
> + map-active-2 {
> + cooling-device = <&fan 3 3>;
> + trip = <&fan_config2>;
> + };
> + };
> + };
> + };
> +
> + fan: pwm-fan {
> + pinctrl-names = "default";
> + pinctrl-0 = <&fan_pins>;
> + compatible = "pwm-fan";
> + #cooling-cells = <2>;
> + pwms = <&pwm 1 10000000 0>;
> + cooling-levels = <0 66 196 255>;
> + };
> +
> };
>
> &padctrl0_apsys {
> + fan_pins: fan-0 {
> + pwm1-pins {
> + pins = "GPIO3_3"; /* PWM1 */
> + function = "pwm";
> + bias-disable;
> + drive-strength = <25>;
> + input-disable;
> + input-schmitt-disable;
> + slew-rate = <0>;
> + };
> + };
> +
> uart0_pins: uart0-0 {
> tx-pins {
> pins = "UART0_TXD";
>
> --
> 2.34.1
>
Reviewed-by: Elle Rhumsaa <elle@weathered-steel.dev>
next prev parent reply other threads:[~2025-10-01 21:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250930122729eucas1p2c4f1c07a4a504a59ba691b407a39420d@eucas1p2.samsung.com>
2025-09-30 12:20 ` [PATCH v15 0/7] Rust Abstractions for PWM subsystem with TH1520 PWM driver Michal Wilczynski
2025-09-30 12:20 ` [PATCH v15 1/7] pwm: Export `pwmchip_release` for external use Michal Wilczynski
2025-10-01 20:51 ` Elle Rhumsaa
2025-09-30 12:20 ` [PATCH v15 2/7] rust: pwm: Add Kconfig and basic data structures Michal Wilczynski
2025-10-01 20:52 ` Elle Rhumsaa
2025-09-30 12:20 ` [PATCH v15 3/7] rust: pwm: Add complete abstraction layer Michal Wilczynski
2025-10-01 20:57 ` Elle Rhumsaa
2025-10-09 17:05 ` Uwe Kleine-König
2025-09-30 12:20 ` [PATCH v15 4/7] pwm: Add Rust driver for T-HEAD TH1520 SoC Michal Wilczynski
2025-10-01 20:58 ` Elle Rhumsaa
2025-09-30 12:20 ` [PATCH v15 5/7] dt-bindings: pwm: thead: Add T-HEAD TH1520 PWM controller Michal Wilczynski
2025-10-01 0:01 ` Drew Fustini
2025-10-01 20:59 ` Elle Rhumsaa
2025-09-30 12:20 ` [PATCH v15 6/7] riscv: dts: thead: Add PWM controller node Michal Wilczynski
2025-09-30 12:20 ` [PATCH v15 7/7] riscv: dts: thead: Add PWM fan and thermal control Michal Wilczynski
2025-10-01 21:00 ` Elle Rhumsaa [this message]
2025-10-13 10:23 ` [PATCH v15 0/7] Rust Abstractions for PWM subsystem with TH1520 PWM driver Michal Wilczynski
2025-10-13 16:48 ` Uwe Kleine-König
2025-10-15 17:52 ` Michal Wilczynski
2025-10-15 18:07 ` Michal Wilczynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aN2WYmcYHHZSccPm@archiso \
--to=elle@weathered-steel.dev \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=alex@ghiti.fr \
--cc=aliceryhl@google.com \
--cc=aou@eecs.berkeley.edu \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=conor+dt@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=fustini@kernel.org \
--cc=gary@garyguo.net \
--cc=guoren@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lossin@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=m.wilczynski@samsung.com \
--cc=mturquette@baylibre.com \
--cc=ojeda@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=ukleinek@kernel.org \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox