Re: [PATCH 2/4] media: i2c: dw9719: Add DW9800K support

Luca Weiss
2025-10-02T12:58:11Z

On Thu Oct 2, 2025 at 12:15 PM CEST, Griffin Kroah-Hartman wrote:
> The DW9800K is a similar part to the DW9719. The method for operation is
> the same as the DW9719, but the register set is different. Add support
> for this part to the existing dw9719 driver.
>
> Tested on the Fairphone 5 smartphone.

Can confirm!

Tested-by: Luca Weiss <luca.weiss@fairphone.com>

Regards
Luca

> Signed-off-by: Griffin Kroah-Hartman <griffin.kroah@fairphone.com>
> ---
> drivers/media/i2c/dw9719.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/drivers/media/i2c/dw9719.c b/drivers/media/i2c/dw9719.c
> index 3627e78b8b6668933c4ecd92231465ce4105ff0c..172479f2c9f63f6b2a1f6eccf8184142edb383b9 100644
> --- a/drivers/media/i2c/dw9719.c
> +++ b/drivers/media/i2c/dw9719.c
> @@ -68,6 +68,9 @@
> #define DW9761_VCM_PRELOAD CCI_REG8(8)
> #define DW9761_DEFAULT_VCM_PRELOAD 0x73
>
> +#define DW9800K_DEFAULT_SAC 1
> +#define DW9800K_MODE_SAC_SHIFT 6
> +#define DW9800K_DEFAULT_VCM_FREQ 0x10
>
> #define to_dw9719_device(x) container_of(x, struct dw9719_device, sd)
>
> @@ -75,6 +78,7 @@ enum dw9719_model {
> DW9718S,
> DW9719,
> DW9761,
> + DW9800K,
> };
>
> struct dw9719_device {
> @@ -137,6 +141,12 @@ static int dw9719_power_up(struct dw9719_device *dw9719, bool detect)
> goto props;
> }
>
> + if (dw9719->model == DW9800K) {
> + dw9719->sac_mode = DW9800K_DEFAULT_SAC;
> + dw9719->vcm_freq = DW9800K_DEFAULT_VCM_FREQ;
> + goto props;
> + }
> +
> ret = cci_read(dw9719->regmap, DW9719_INFO, &val, NULL);
> if (ret < 0)
> return ret;
> @@ -177,6 +187,12 @@ static int dw9719_power_up(struct dw9719_device *dw9719, bool detect)
> }
>
> switch (dw9719->model) {
> + case DW9800K:
> + cci_write(dw9719->regmap, DW9719_CONTROL, DW9719_ENABLE_RINGING, &ret);
> + cci_write(dw9719->regmap, DW9719_MODE,
> + dw9719->sac_mode << DW9800K_MODE_SAC_SHIFT, &ret);
> + cci_write(dw9719->regmap, DW9719_VCM_FREQ, dw9719->vcm_freq, &ret);
> + break;
> case DW9718S:
> /* Datasheet says [OCP/UVLO] should be disabled below 2.5V */
> dw9719->sac_mode &= DW9718S_CONTROL_SAC_MASK;
> @@ -426,6 +442,7 @@ static const struct of_device_id dw9719_of_table[] = {
> { .compatible = "dongwoon,dw9718s", .data = (const void *)DW9718S },
> { .compatible = "dongwoon,dw9719", .data = (const void *)DW9719 },
> { .compatible = "dongwoon,dw9761", .data = (const void *)DW9761 },
> + { .compatible = "dongwoon,dw9800k", .data = (const void *)DW9800K },
> { }
> };
> MODULE_DEVICE_TABLE(of, dw9719_of_table);