From: Tejun Heo <tj@kernel.org>
To: Andrea Righi <arighi@nvidia.com>
Cc: David Vernet <void@manifault.com>,
Changwoo Min <changwoo@igalia.com>,
linux-kernel@vger.kernel.org, sched-ext@lists.linux.dev
Subject: Re: [PATCH 4/7] sched_ext: Use bitfields for boolean warning flags
Date: Tue, 23 Sep 2025 06:00:27 -1000 [thread overview]
Message-ID: <aNLEG9m9JM4gDM9L@slm.duckdns.org> (raw)
In-Reply-To: <aNJQFqg2R80VJc7p@gpd4>
On Tue, Sep 23, 2025 at 09:45:26AM +0200, Andrea Righi wrote:
> On Sun, Sep 21, 2025 at 03:32:43PM -1000, Tejun Heo wrote:
> > Convert warned_zero_slice and warned_deprecated_rq in scx_sched struct to
> > single-bit bitfields to reduce struct size.
> >
> > Signed-off-by: Tejun Heo <tj@kernel.org>
>
> Hm... I think the struct size remains the same, at least in my build:
> - before: /* size: 1072, cachelines: 17, members: 14 */
> - after: /* size: 1072, cachelines: 17, members: 14 */
>
> Maybe if we add more attributes in the future?
Yeah, just so that we don't keep expanding the struct as we add flags. I'll
update the description.
Thanks.
--
tejun
next prev parent reply other threads:[~2025-09-23 16:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 1:32 [PATCH 1/7] sched_ext: Use rhashtable_lookup() instead of rhashtable_lookup_fast() Tejun Heo
2025-09-22 1:32 ` [PATCH 2/7] sched_ext: Improve SCX_KF_DISPATCH comment Tejun Heo
2025-09-23 7:20 ` Andrea Righi
2025-09-22 1:32 ` [PATCH 3/7] sched_ext: Fix stray scx_root usage in task_can_run_on_remote_rq() Tejun Heo
2025-09-23 7:22 ` Andrea Righi
2025-09-22 1:32 ` [PATCH 4/7] sched_ext: Use bitfields for boolean warning flags Tejun Heo
2025-09-23 7:45 ` Andrea Righi
2025-09-23 16:00 ` Tejun Heo [this message]
2025-09-23 16:58 ` [PATCH v2 " Tejun Heo
2025-09-23 18:45 ` Andrea Righi
2025-09-22 1:32 ` [PATCH 5/7] sched_ext: Add SCX_EFLAG_INITIALIZED to indicate successful ops.init() Tejun Heo
2025-09-23 8:08 ` Andrea Righi
2025-09-22 1:32 ` [PATCH 6/7] sched_ext: Make qmap dump operation non-destructive Tejun Heo
2025-09-23 8:09 ` Andrea Righi
2025-09-22 1:32 ` [PATCH 7/7] tools/sched_ext: scx_qmap: Make debug output quieter by default Tejun Heo
2025-09-23 8:11 ` Andrea Righi
2025-09-23 7:18 ` [PATCH 1/7] sched_ext: Use rhashtable_lookup() instead of rhashtable_lookup_fast() Andrea Righi
2025-09-23 15:59 ` Tejun Heo
2025-09-23 18:47 ` Andrea Righi
2025-09-23 19:13 ` Tejun Heo
2025-09-24 6:14 ` Andrea Righi
2025-09-24 6:38 ` Tejun Heo
2025-09-24 8:26 ` Andrea Righi
2025-09-24 18:00 ` Tejun Heo
2025-10-22 21:37 ` Andrea Righi
2025-10-22 21:56 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNLEG9m9JM4gDM9L@slm.duckdns.org \
--to=tj@kernel.org \
--cc=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sched-ext@lists.linux.dev \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox