From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFCDD29BDA7; Fri, 26 Sep 2025 09:47:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758880027; cv=none; b=iWCnNINcDRQJHQ3R/gJ6oe2MuoUig+4lnkBYTPbBsdpnLCzzJ8fv30LS+8ebXZSJUq0Q4iNTXHw0NyLv6c+K5cuD2hIX/FbbVrWsYlkBPixNXlc/YnCP83zk/u2T8U/czVEE+EyXvE01deaWPvvXfa/HNPFS3dVJY3meW5Z+4gg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758880027; c=relaxed/simple; bh=UnVLZ7TBQGgIyTCxy7xsCd3ZHl/kMaius1zR9yAh3o0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DJC77Ds2bVxPxnVqpuBXBKzhZnslXq1iZ/hlDEOmJOstVMZ/KNsAby01gaOEweDJlKWzT4Qci4LQPXDFCaUwR0MrrloTwZrqvvUZfVPFHzvYL8+87Wa2UNOnLlBp02MDzHMbPiUxpjHs+X0GnhX0kLFZ0i+bXQJDbRUCPUe9t4w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=QYQjPpZb; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="QYQjPpZb" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=NCfE4He+gY9xo2RYtjC3yuFf4BxApKFT2Hd+TnVpmsQ=; b=QYQjPpZbkM5943qWjk73KlYk1y hFHt5ndkFWQJlNIg5FiGIA4CRcrQUpKA6oYXmsdAarRoy0tTAb/0Ob5tF924xYedzcERNK2HdWDH9 +oK+CP/6rTWz2df9rfMUHeFK2GKRVf/ZP9DwFIutFOuAXEDuoowAKUA/JGWfpXs4LuIoZwxmhgFdy puSMZhtXLPthdatt5ld2FwdZWsgiaso0MhDQRE/70eIEXukPG1ElFDAqu3zgTkotXtY1A7rLBV0Lf WiOLZfZQYzPvgW3REWsretj9MptO3ewpRJ62jjlUoyLSQjmuaOxV5Skq6JV/PXZlLoERav7LfeoQJ LrH7wOhg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:33342) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1v252R-000000003Jp-2ZwE; Fri, 26 Sep 2025 10:46:51 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1v252N-000000000Yz-32Aw; Fri, 26 Sep 2025 10:46:47 +0100 Date: Fri, 26 Sep 2025 10:46:47 +0100 From: "Russell King (Oracle)" To: Horatiu Vultur Cc: Vladimir Oltean , Jakub Kicinski , andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, richardcochran@gmail.com, vadim.fedorenko@linux.dev, christophe.jaillet@wanadoo.fr, rosenp@gmail.com, steen.hegelund@microchip.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2] phy: mscc: Fix PTP for vsc8574 and VSC8572 Message-ID: References: <20250917113316.3973777-1-horatiu.vultur@microchip.com> <20250918160942.3dc54e9a@kernel.org> <20250922121524.3baplkjgw2xnwizr@skbuf> <20250922123301.y7qjguatajhci67o@DEN-DL-M31836.microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250922123301.y7qjguatajhci67o@DEN-DL-M31836.microchip.com> Sender: Russell King (Oracle) On Mon, Sep 22, 2025 at 02:33:01PM +0200, Horatiu Vultur wrote: > Thanks for the advice. > What about to make the PHY_ID_VSC8572 and PHY_ID_VSC8574 to use > vsc8584_probe() and then in this function just have this check: > > --- > if ((phydev->phy_id & 0xfffffff0) != PHY_ID_VSC8572 && > (phydev->phy_id & 0xfffffff0) != PHY_ID_VSC8574) { > if ((phydev->phy_id & MSCC_DEV_REV_MASK) != VSC8584_REVB) { > dev_err(&phydev->mdio.dev, "Only VSC8584 revB is supported.\n"); > return -ENOTSUPP; > } > } Please, no, not like this. Have a look how the driver already compares PHY IDs in the rest of the code. When a PHY driver is matched, the PHY ID is compared using the .phy_id and .phy_id_mask members of the phy_driver structure. The .phy_id is normally stuff like PHY_ID_VSC8572 and PHY_ID_VSC8574. When the driver is probed, phydev->drv is set to point at the appropriate phy_driver structure. Thus, the tests can be simplified to merely looking at phydev->drv->phy_id: if (phydev->drv->phy_id != PHY_ID_VSC8572 && phydev->drv->phy_id != PHY_ID_VSC8574 && (phydev->phy_id & MSCC_DEV_REV_MASK) != VSC8584_REVB) { ... Alternatively, please look at the phy_id*() and phydev_id_compare() families of functions. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!