From: Corey Minyard <corey@minyard.net>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Binbin Zhou <zhoubinbin@loongson.cn>,
Chong Qiao <qiaochong@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>, Lee Jones <lee@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] mfd: ls2kbmc: Fix a couple Smatch warnings
Date: Fri, 3 Oct 2025 10:38:48 -0500 [thread overview]
Message-ID: <aN_uCPqymUbVN34c@mail.minyard.net> (raw)
In-Reply-To: <cover.1759478975.git.dan.carpenter@linaro.org>
On Fri, Oct 03, 2025 at 12:28:58PM +0300, Dan Carpenter wrote:
> These are two issues which were detected by Smatch. They're not really
> going to happen in real life. Small kmalloc()s can't fail.
> The devm_mfd_add_devices() function isn't going to fail either...
>
> But still, they're worth fixing just for correctness sake.
>
> Dan Carpenter (2):
> mfd: ls2kbmc: Fix an IS_ERR() vs NULL check in probe()
> mfd: ls2kbmc: check for devm_mfd_add_devices() failure
Got them, thank you. I'll get this in for 6.18.
-corey
>
> drivers/mfd/ls2k-bmc-core.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> --
> 2.51.0
>
next prev parent reply other threads:[~2025-10-03 15:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-03 9:28 [PATCH 0/2] mfd: ls2kbmc: Fix a couple Smatch warnings Dan Carpenter
2025-10-03 9:29 ` [PATCH 1/2] mfd: ls2kbmc: Fix an IS_ERR() vs NULL check in probe() Dan Carpenter
2025-10-03 9:29 ` [PATCH 2/2] mfd: ls2kbmc: check for devm_mfd_add_devices() failure Dan Carpenter
2025-10-03 15:38 ` Corey Minyard [this message]
2025-10-08 14:03 ` [PATCH 0/2] mfd: ls2kbmc: Fix a couple Smatch warnings Lee Jones
2025-10-09 9:56 ` Lee Jones
2025-10-09 3:07 ` Huacai Chen
2025-10-09 10:01 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aN_uCPqymUbVN34c@mail.minyard.net \
--to=corey@minyard.net \
--cc=chenhuacai@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qiaochong@loongson.cn \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox