From: Brian Masney <bmasney@redhat.com>
To: Johan Hovold <johan@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Miaoqian Lin <linmq006@gmail.com>
Subject: Re: [PATCH 1/2] soc: qcom: ocmem: fix device leak on lookup
Date: Fri, 26 Sep 2025 17:08:41 -0400 [thread overview]
Message-ID: <aNcA2SCZMckYmZXb@redhat.com> (raw)
In-Reply-To: <20250926143511.6715-2-johan@kernel.org>
On Fri, Sep 26, 2025 at 04:35:10PM +0200, Johan Hovold wrote:
> Make sure to drop the reference taken to the ocmem platform device when
> looking up its driver data.
>
> Note that holding a reference to a device does not prevent its driver
> data from going away so there is no point in keeping the reference.
>
> Also note that commit 0ff027027e05 ("soc: qcom: ocmem: Fix missing
> put_device() call in of_get_ocmem") fixed the leak in a lookup error
> path, but the reference is still leaking on success.
>
> Fixes: 88c1e9404f1d ("soc: qcom: add OCMEM driver")
> Cc: stable@vger.kernel.org # 5.5: 0ff027027e05
> Cc: Brian Masney <bmasney@redhat.com>
> Cc: Miaoqian Lin <linmq006@gmail.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Brian Masney <bmasney@redhat.com>
next prev parent reply other threads:[~2025-09-26 21:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 14:35 [PATCH 0/2] soc: qcom: ocmem/pbs: fix device leaks on lookup Johan Hovold
2025-09-26 14:35 ` [PATCH 1/2] soc: qcom: ocmem: fix device leak " Johan Hovold
2025-09-26 18:42 ` Markus Elfring
2025-09-26 21:08 ` Brian Masney [this message]
2025-09-26 14:35 ` [PATCH 2/2] soc: qcom: pbs: " Johan Hovold
2025-09-26 18:55 ` Markus Elfring
2025-10-27 14:09 ` [PATCH 0/2] soc: qcom: ocmem/pbs: fix device leaks " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNcA2SCZMckYmZXb@redhat.com \
--to=bmasney@redhat.com \
--cc=andersson@kernel.org \
--cc=johan@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linmq006@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox