From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCD332FF64D for ; Mon, 29 Sep 2025 11:01:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759143679; cv=none; b=j0zhiSl7qeM/vHkvM9j1Q5ZFahdZpsw73flonR16CoAcE3FJCqEk0cUeUCcBRRBv7x9/KmdvmONmPR2gdWEI3/jQsuic2BB8WLXOGQ2GfqjYeeHFA3UeSjlFEGyN3enhNth6ZBRju4ymRvxAE8dfaHM1JTKsSmzuaXVjSpGHy7A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759143679; c=relaxed/simple; bh=pY5ptJQJD5hC5Yld/qr6VRXciRKFgD9s0GcbegbNqCE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GLqHC1Qc3ofO0vaF5Uw9vkxp1k1L/zld3Gow3LT1vTSmDk3sxWwRTwEYnsaq2vYlvJyb3Pmd9c0HOvXnyk0U0U5EMNITs8GNpoxyGI0NQOE+dS4uuPRcMhjFufRersNloD55FRSFjH1l2XR/JGTmrMmWvzVXdlW6W/Pt7AZ4xo4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=F8KDYdNi; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="F8KDYdNi" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-46e32c0e273so101355e9.1 for ; Mon, 29 Sep 2025 04:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1759143675; x=1759748475; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Rg8kwxsOK3RvjQ0Oy8bn6on+o39qQD/CbdbTzAEerLQ=; b=F8KDYdNinepvsxCkB1sYKwrTMEfug9TQawfjxVpWZf+IqAyFCLrhK6jcxusl0xkSFk eYU8NpymMgDUu5fsqdDNYUgXnOugOfr3AtATyrJjx8INxMkQwbdu3xS7SPBhbQrT0LIp uK9Yqp/J1nRFGnkjPAuEAcf7pfig0ZyhQGkSdCCUi+FurTnbXw/FxYMiRBVQ8piUzNro PIUUwgox2QI7pwUIOLVekF5SjL7lXZsWVxI3LEyBt9i6gTt5hdo/3SBKW35dMi7Bcl9s 2Umj0H5OSTOFLWiSEyTEuY399zfkwVjyKRMAehOSUaGl00M83nHTCa9jgcRxpGaQBHXb sn6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759143675; x=1759748475; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Rg8kwxsOK3RvjQ0Oy8bn6on+o39qQD/CbdbTzAEerLQ=; b=b3Tica7W6k1jWDBv/zTuz9zmGAppoaD4T5A8Hz8Fm4g/wHRoWsY6ke/yEHG/xlnBmC cbApbQoH7jfMe4Ufs7bt0tBledgnEUTc82+eNJXzj9q6q2H9BseHVan97kduTZl8efRx r6kq2wef00WHI/ZoS4lm8nMy+GTWU7M+ofMVaITerclXu5kitFIUccsWTMf3OPLVOcZs 6FqHxNIB1fvFTLxIh9/3TtSITRHo8RdIDYrXlJhbVwqzruEdwKsqkU7l8ZC2GJoDNvTm jpaopnzPkudR0/7LFzIbz4oRpjbzd87LlSmsTkJE2GlvJHlH8eJktP5EJ36LU4s1m4Ww 1O6A== X-Gm-Message-State: AOJu0YwTMeAu2ClHuPd4V6PPGJr1hRKM49WVEtKUOSBdDQ/fSf/E0T25 XOUNDTOMLlak3RCaUqBmWrLTOpowbt7ezVS0GVUKQUCs73x85mdyFCfZ5utaFib2bg== X-Gm-Gg: ASbGnctP4H73Cd4BzuxJvQO43cpQcSGGBbDrSE0iz+8H1aTLL4qx8ciH3RRu2XC+URp gbBUxVEukHlnifknBVtAkK+Y6LbopgEwSl3mJCEzhjnhmLbiz6tSLgQs9e/RfdQVTd4ETABGJJ6 4kZJDvb+e2k6kSQlPxLchCuSjp5s0fBNjYf1Bmi3MjpAhc+jzvFN04hks7ztMQ8RzzQV/4ijE76 TcJYr/6heJ4TNppS7Dee1SKXY33exAMzpQG7OT+v5gvladdajbCMqaolbvWARLc0eah3XBFdkHT +BMT3eKxvgZC1kxgJw7ajY7A/SPGfMX9x79sd9tGp9fxVFb2PH70n0egB6c0MGtobBhU7dLt8Sx Qe5JBXOLJtvHtpEmGBNXYA5WRjqRh8PakRsFR+2T/+Zfur29gzhPTvAUkKSApqh397oA= X-Google-Smtp-Source: AGHT+IFg+hCsYGMP/Ez1tXXALpy4mbn6kahyoJaMM4qeV/gbtw19iOEwbJlDUZ+YOlPn2J+hesMSFw== X-Received: by 2002:a05:600c:a31b:b0:45d:f51c:193 with SMTP id 5b1f17b1804b1-46e575a116emr243565e9.7.1759143674689; Mon, 29 Sep 2025 04:01:14 -0700 (PDT) Received: from google.com (140.240.76.34.bc.googleusercontent.com. [34.76.240.140]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e4ab0bf62sm70168175e9.9.2025.09.29.04.01.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Sep 2025 04:01:13 -0700 (PDT) Date: Mon, 29 Sep 2025 11:01:10 +0000 From: Mostafa Saleh To: Will Deacon Cc: linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, robin.murphy@arm.com, jean-philippe@linaro.org, qperret@google.com, tabba@google.com, jgg@ziepe.ca, mark.rutland@arm.com, praan@google.com Subject: Re: [PATCH v4 10/28] KVM: arm64: iommu: Shadow host stage-2 page table Message-ID: References: <20250819215156.2494305-1-smostafa@google.com> <20250819215156.2494305-11-smostafa@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Sep 26, 2025 at 03:42:38PM +0100, Will Deacon wrote: > On Tue, Sep 16, 2025 at 02:24:46PM +0000, Mostafa Saleh wrote: > > On Tue, Sep 09, 2025 at 03:42:07PM +0100, Will Deacon wrote: > > > On Tue, Aug 19, 2025 at 09:51:38PM +0000, Mostafa Saleh wrote: > > > > diff --git a/arch/arm64/kvm/hyp/nvhe/iommu/iommu.c b/arch/arm64/kvm/hyp/nvhe/iommu/iommu.c > > > > index a01c036c55be..f7d1c8feb358 100644 > > > > --- a/arch/arm64/kvm/hyp/nvhe/iommu/iommu.c > > > > +++ b/arch/arm64/kvm/hyp/nvhe/iommu/iommu.c > > > > @@ -4,15 +4,94 @@ > > > > * > > > > * Copyright (C) 2022 Linaro Ltd. > > > > */ > > > > +#include > > > > + > > > > #include > > > > +#include > > > > +#include > > > > > > > > /* Only one set of ops supported */ > > > > struct kvm_iommu_ops *kvm_iommu_ops; > > > > > > > > +/* Protected by host_mmu.lock */ > > > > +static bool kvm_idmap_initialized; > > > > + > > > > +static inline int pkvm_to_iommu_prot(enum kvm_pgtable_prot prot) > > > > +{ > > > > + int iommu_prot = 0; > > > > + > > > > + if (prot & KVM_PGTABLE_PROT_R) > > > > + iommu_prot |= IOMMU_READ; > > > > + if (prot & KVM_PGTABLE_PROT_W) > > > > + iommu_prot |= IOMMU_WRITE; > > > > + if (prot == PKVM_HOST_MMIO_PROT) > > > > + iommu_prot |= IOMMU_MMIO; > > > > > > This looks a little odd to me. > > > > > > On the CPU side, the only different between PKVM_HOST_MEM_PROT and > > > PKVM_HOST_MMIO_PROT is that the former has execute permission. Both are > > > mapped as cacheable at stage-2 because it's the job of the host to set > > > the more restrictive memory type at stage-1. > > > > > > Carrying that over to the SMMU would suggest that we don't care about > > > IOMMU_MMIO at stage-2 at all, so why do we need to set it here? > > > > Unlike the CPU, the host can set the SMMU to bypass, in that case the > > hypervisor will attach its stage-2 with no stage-1 configured. So, > > stage-2 must have the correct attrs for MMIO. > > I'm not sure about that. > > If the SMMU is in stage-1 bypass, we still have the incoming memory > attributes from the transaction (modulo MTCFG which we shouldn't be > setting) and they should combine with the stage-2 attributes in roughly > the same way as the CPU, no? Makes sense, we can remove that for now and map all stage-2 with IOMMU_CACHE. However, that might not be true for other IOMMUs, as they might not combine attributes as SMMUv3 stage-2, but we can ignore that for now. I will update the logic in v5. Thanks, Mostafa > > > > > +static int __snapshot_host_stage2(const struct kvm_pgtable_visit_ctx *ctx, > > > > + enum kvm_pgtable_walk_flags visit) > > > > +{ > > > > + u64 start = ctx->addr; > > > > + kvm_pte_t pte = *ctx->ptep; > > > > + u32 level = ctx->level; > > > > + u64 end = start + kvm_granule_size(level); > > > > + int prot = IOMMU_READ | IOMMU_WRITE; > > > > + > > > > + /* Keep unmapped. */ > > > > + if (pte && !kvm_pte_valid(pte)) > > > > + return 0; > > > > + > > > > + if (kvm_pte_valid(pte)) > > > > + prot = pkvm_to_iommu_prot(kvm_pgtable_stage2_pte_prot(pte)); > > > > + else if (!addr_is_memory(start)) > > > > + prot |= IOMMU_MMIO; > > > > > > Why do we need to map MMIO regions pro-actively here? I'd have thought > > > we could just do: > > > > > > if (!kvm_pte_valid(pte)) > > > return 0; > > > > > > prot = pkvm_to_iommu_prot(kvm_pgtable_stage2_pte_prot(pte); > > > kvm_iommu_ops->host_stage2_idmap(start, end, prot); > > > return 0; > > > > > > but I think that IOMMU_MMIO is throwing me again... > > > > We have to map everything pro-actively as we don’t handle page faults > > in the SMMUv3 driver. > > This would be a future work where the CPU stage-2 page table is shared with > > the SMMUv3. > > Ah yes, I'd forgotten about that. > > Thanks, > > Will