From: Bobby Eshleman <bobbyeshleman@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
Willem de Bruijn <willemb@google.com>,
Neal Cardwell <ncardwell@google.com>,
David Ahern <dsahern@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Stanislav Fomichev <sdf@fomichev.me>,
Mina Almasry <almasrymina@google.com>,
Bobby Eshleman <bobbyeshleman@meta.com>
Subject: Re: [PATCH net-next v4 2/2] net: devmem: use niov array for token management
Date: Mon, 29 Sep 2025 09:16:48 -0700 [thread overview]
Message-ID: <aNqw8CAVjas0vvGm@devvm11784.nha0.facebook.com> (raw)
In-Reply-To: <20250926162245.5bc89cfa@kernel.org>
On Fri, Sep 26, 2025 at 04:22:45PM -0700, Jakub Kicinski wrote:
> On Fri, 26 Sep 2025 09:31:34 -0700 Bobby Eshleman wrote:
> > @@ -2530,8 +2466,12 @@ static int tcp_recvmsg_dmabuf(struct sock *sk, const struct sk_buff *skb,
> > */
> > for (i = 0; i < skb_shinfo(skb)->nr_frags; i++) {
> > skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
> > + struct net_devmem_dmabuf_binding *binding;
> > struct net_iov *niov;
> > u64 frag_offset;
> > + size_t size;
> > + size_t len;
>
> unused variables here
>
Got it, will update after window opens.
Best,
Bobby
next prev parent reply other threads:[~2025-09-29 16:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 16:31 [PATCH net-next v4 0/2] net: devmem: improve cpu cost of RX token management Bobby Eshleman
2025-09-26 16:31 ` [PATCH net-next v4 1/2] net: devmem: rename tx_vec to vec in dmabuf binding Bobby Eshleman
2025-09-26 16:31 ` [PATCH net-next v4 2/2] net: devmem: use niov array for token management Bobby Eshleman
2025-09-26 23:22 ` Jakub Kicinski
2025-09-29 16:16 ` Bobby Eshleman [this message]
2025-09-27 9:08 ` kernel test robot
2025-09-27 6:00 ` [syzbot ci] Re: net: devmem: improve cpu cost of RX " syzbot ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNqw8CAVjas0vvGm@devvm11784.nha0.facebook.com \
--to=bobbyeshleman@gmail.com \
--cc=almasrymina@google.com \
--cc=bobbyeshleman@meta.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox