From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D089230C10B for ; Mon, 29 Sep 2025 17:24:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.15 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759166643; cv=fail; b=swM3xQ71OYUa8IfzYKFHClH898Q0J5iVbA/7+VCCsWS1SpX2sPUf+74QK5M+qzs0s12ot+gI1kLl8UgYnxGTIoumTuZk18D0OfyNQwhvo6WRNGPJNv1IGccLXy7fXZm00O4Xluwm15fxPOZaVPq0X2EmPYqFDNzzb0JVCLn3LP4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759166643; c=relaxed/simple; bh=0IEo4suGbBJ3vzjaSmsHwlaXfeK99spoxdetMCsDE3c=; h=Date:From:To:CC:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=rcZDUUTWQ2PAapa3UXgwoy/7Y5NNLocmrLdvOvLph1fc0Bcpe4IRy+qgvGeGlKoY9Nxh2mfNqD35WMQ/UJOn6wCIyJKyD/cYhVeMzDu/4s/mfP72YfxECvRAcQh2HOT/vvKgnkWrTxpkl46ugTW1GZzDkYf/mN9XenhhaBC6buc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=anTOXc/y; arc=fail smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="anTOXc/y" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1759166642; x=1790702642; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=0IEo4suGbBJ3vzjaSmsHwlaXfeK99spoxdetMCsDE3c=; b=anTOXc/ypWSjFUUk532HfVocAP79gq15BZpmjG4CyJzS7sW9h4aYtODb ne1rnj6BW+2JXsPe9ob0hDaJc2+joqD01msc+elG47cmDg16ZfKaEnX5F PjhAuDKpDlPZBzRMUsuzngse99C0yfvQnSMuueiwbu4x11WXSQxqUq6xv Dm5SEfa+7iS6TB6GOLAm6QZXaMOi4K4aYgZC7Y7tpP3mPbkQd2trNlyew gYh365r0bGblSEncL89qTtYD38vPOkbKCrcccSHtSb5IdXRyDFj8z5XGN FOnZgMZPjzBs+WDZ7Ynv3nWdza5/6PgZpvskWVlyLSSqFfm+ECL+EAl3C w==; X-CSE-ConnectionGUID: muGE+x4tTMSAshl0WrSRNg== X-CSE-MsgGUID: sQ0KzlgaT0679j24+j7dKQ== X-IronPort-AV: E=McAfee;i="6800,10657,11568"; a="61524157" X-IronPort-AV: E=Sophos;i="6.18,302,1751266800"; d="scan'208";a="61524157" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2025 10:24:01 -0700 X-CSE-ConnectionGUID: buCFbF6iSduJNn1RzJddOA== X-CSE-MsgGUID: FhuRgWV+QdC7Xlek0jEYGg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,302,1751266800"; d="scan'208";a="209000658" Received: from orsmsx903.amr.corp.intel.com ([10.22.229.25]) by orviesa002.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2025 10:23:52 -0700 Received: from ORSMSX902.amr.corp.intel.com (10.22.229.24) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.27; Mon, 29 Sep 2025 10:23:49 -0700 Received: from ORSEDG903.ED.cps.intel.com (10.7.248.13) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.27 via Frontend Transport; Mon, 29 Sep 2025 10:23:49 -0700 Received: from CH1PR05CU001.outbound.protection.outlook.com (52.101.193.11) by edgegateway.intel.com (134.134.137.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.27; Mon, 29 Sep 2025 10:23:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yv06xB63HbkqUpt7AQTIQAS8uEm2hTybkGpfAmBNsejat0uPwC4nKSstRwoG8EIaJis7XAfc+z3X7GO8517lyDwGWz0S/9MlKwHa8KU1QX4Xm0F+wHb+zg4WWvN25L0/YKaeiIfHI4q3bSXE5/a/1CXP+jaH4eZi8h1EPJ/H+9iFEKxzhnSaOrkHYxWcXXDx4RLEINXgHsCot07lShkeZacft4Fsi7Bf17ZIt0YEEAr6POw7A06XBoSbmaAmkxMHotce/TcVBKjbVkdVnT0PgZgSz1S7TI0w4UN/4KRSHDWFtGbFAxvjiyw4J6iGBoY82cIOHUVBuVFKFeFBQlGrRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3pO0pRzfAEP9k6CJ6ysMj3OO9cBpj+Dtz98rh5sdDgc=; b=PAtQfyLNYak/3CmBhgCTjoyJEafpbGnzDtjkXvv+a+yoBZmN8tAZMrh4e5qs7/N4LihAAyJfwlzTUeMQS0D+5VbMqgJp1IehQfnY9DIFR5QStbQl1PUTyLJgbgN8Mh4FBCsrfPCgsQXCGW62nx7M3dCsqcZxU3O57xIGXSpaUJiMBlg6w6GjsbpqxiIXr4CkgkK/ED+8nIPQ4rjkRtTPVCx8mioZCLFfrUt/T6OsdJ2kn6DRmvr35LPW/88Umc77JkKGU1dnqBoCQhsqo0T4NWwADDTpItJPKI66pNCvoJJKOlDwq+CrLUw1yZjyO52RIQpOUGZLYBuPOnUgOn6/3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ5PPF0D43D62C4.namprd11.prod.outlook.com (2603:10b6:a0f:fc02::80b) by SJ2PR11MB7671.namprd11.prod.outlook.com (2603:10b6:a03:4c4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.17; Mon, 29 Sep 2025 17:23:45 +0000 Received: from SJ5PPF0D43D62C4.namprd11.prod.outlook.com ([fe80::4df9:6ae0:ba12:2dde]) by SJ5PPF0D43D62C4.namprd11.prod.outlook.com ([fe80::4df9:6ae0:ba12:2dde%8]) with mapi id 15.20.9160.008; Mon, 29 Sep 2025 17:23:45 +0000 Date: Mon, 29 Sep 2025 10:23:42 -0700 From: Alison Schofield To: Ira Weiny CC: Jiapeng Chong , , , , , , Abaci Robot Subject: Re: [PATCH -next] nvdimm: Remove duplicate linux/slab.h header Message-ID: References: <20250928013110.1452090-1-jiapeng.chong@linux.alibaba.com> <68daa03bbd9a5_270161294bd@iweiny-mobl.notmuch> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <68daa03bbd9a5_270161294bd@iweiny-mobl.notmuch> X-ClientProxiedBy: SJ0PR05CA0099.namprd05.prod.outlook.com (2603:10b6:a03:334::14) To SJ5PPF0D43D62C4.namprd11.prod.outlook.com (2603:10b6:a0f:fc02::80b) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PPF0D43D62C4:EE_|SJ2PR11MB7671:EE_ X-MS-Office365-Filtering-Correlation-Id: b7eb8c44-bf46-41bf-bc27-08ddff7cf184 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Ss85qm829c/PEWm4hmds2gYGkX6IW3kSTkQwByd4S4u75QSTd101gJAJOozI?= =?us-ascii?Q?xPDRqbXpOIv8fi0jETKK0zfLnlH+cpMhdk68K6zO5sggYOVperseaNmlaJBq?= =?us-ascii?Q?M6qdnLYbdsny5BFuAMPjM5mU5/znnzpTFFaZivBZHcES1h/uzTQQwTwTLjRj?= =?us-ascii?Q?+5r5j6nXAG4GUcB3kBIJsp69TvKFaBUqrRe7oykp3QTsvMrtAVZHIdiDlRw0?= =?us-ascii?Q?k/JwNLWy9iigVQYy7OjK2gS35oA+fO/5DpkhrNo43ZyfVeGVKsOCdjlP9zc9?= =?us-ascii?Q?gyz4F/yG5J3li37zaOhGTPIfUjbC9KwnIPreE9KZ4EjvwHpttWKodt1Ikc1y?= =?us-ascii?Q?HiEegyHujWuljQ7ybutDZFZDLviQ9XNmCNFw9/9pW7XrOSemOmkLeR4DxAB8?= =?us-ascii?Q?jU8sGLaV7ysQJ/Fx0KKTIdKHsUkuuceRvgoRt8bQlbe/QBi0zH+fEpN0+VIE?= =?us-ascii?Q?U+m1IfS5o6AdJP4BlKy1H89pjAHx+dUPkpsrB5Sg/QScc7xvq+BQn4/FuT55?= =?us-ascii?Q?630njDfouhx7TjdD85Wci1pGFLXvZ7lplXIh/d9pJdMNkOahNxTKElySdABT?= =?us-ascii?Q?hOuBH5CiR5Xpi5hxPTF+yYo84cnMfzMFw6Be2uxQM9LomyEOSgGFDW+Dsu2P?= =?us-ascii?Q?v/qrskP/+CA0SAWzlpiMhCn/IMiBlqPVNL2f0whoJ6epHiEczlUxI8K++/0Z?= =?us-ascii?Q?tGiJnbGNuKbQlPa5PXb8/eVlNW3SWMtwdM9ZB4NP1ptZYwamai82FeMK4xDK?= =?us-ascii?Q?A/90bU2jC4hblmsyh/BoHzpE99MO/Z2pT/dwpwUqCmQ2QoXyb30wYsPonaOo?= =?us-ascii?Q?l6t3vemvjFgh3jkxcIdGYwI/L37BzwPvAQcYHgm5AtUCnwgFBhbCr1Qi8M6V?= =?us-ascii?Q?K1560/1RavxiK5Zi4Dn12J7OXN+VGyp8F6nj6ZQNztJCMbgV/4HaLeAwU3kG?= =?us-ascii?Q?VVFNl2toyKW5+WSYH9DJVaDg9tbyLR9VjJLhEZW1hjjog6+ocXK4fBq80miW?= =?us-ascii?Q?tqKJmc6iIOLPoWzTpOb2hAcHnRmsuOkilQgnCM5gemMZVdYXmcayYbx9O0+y?= =?us-ascii?Q?yEvUwj83HPRQnK6xSK06PwCvWgOi36HMspk3EaIRSoIZYN/hx2eWh8ZD1rPc?= =?us-ascii?Q?NUh1x7LTR3uBUCbmmdLabR/gSbIfTqpUVOFWJjUEnbUGKJRV6QnSo6+SHRUj?= =?us-ascii?Q?IFTpHeOexEa6kZVwbfHC8bir2AiDd/OTb4I/Ool7HLd9mfdTff9BMqncN8Bl?= =?us-ascii?Q?BFUJLeltYn7TG8/saWcgPZh/ov46MAhEYfJ4dhzbFmEdWMMwiZnFTmmt86/d?= =?us-ascii?Q?lLWohiqbF8KmbVUFsjgIyV4GnGrLkXQhD1UzMFjo9N0sVJ7s3yuXuM/WaR93?= =?us-ascii?Q?z8vOSUzSmrZ40fQKTljQ9bs4+RuTfg+7lw1RMwaZiZYcOaYhyw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ5PPF0D43D62C4.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?j3+zuiTQcz8Kd7G2nigKS9kFiCI4fNAYY7W2ZpMOL0Fmv4dwa1NLhzq57q9k?= =?us-ascii?Q?JyJErdd8AL/gi2ofDi3yA4fTq5wkI75V4lvAZ2sMk4PK8oNCSqiw/RXh4mQe?= =?us-ascii?Q?ilceqIeq/vjsKbCWafzKvF2EEY9htz0InDk0sxl5mw4NrJW7X9xpbSGcGByV?= =?us-ascii?Q?l7+J9o87HMVXu0SGC0IZT/9a8eRAUXs9FTEik6J/23se4FOd844mSqa5CPHR?= =?us-ascii?Q?5XPOk0PnxhYZfvfiMaiHO0q/NTRa3jUOXZiHFA/erRjbFpAmrx1ZLGE74eCn?= =?us-ascii?Q?H97ZyL980A1bLThnm0yxf01pEYOgt2tcFOtd7Qip2vmuovKDIB5or1uaXF8r?= =?us-ascii?Q?sa/4urzCg0U+3DbQeCkkHz1t+1NM/beTejDfKVJ3+W3TKa1zSLPNzskP/8MI?= =?us-ascii?Q?c0KF5JNff25k2hNMWmT5az8tpnjVGcDZpNnNV8C7fawgUkIxLc4TN6Ze1Iwt?= =?us-ascii?Q?qZDafr+PXwbXrwpGxZGPA6JdXe7TjKnT3stuxHADVmVxWNrbGlcWO07fWdtr?= =?us-ascii?Q?Gwi8GYvsYPDLlYKSwu2RIv9YezyUM8iUN+Cp6QA8vSJLteTO9nqCTdhy/dgN?= =?us-ascii?Q?aH/GfkdfIY2CGw5o6wS5zWD9aW3JTVMa5kCDoxK8n38mPeA3Dg1z3h9Rg6hO?= =?us-ascii?Q?269b0vevxlaYMnd7RMYV5WZiIVLZtVvVVVUXKhL9H4bhkAkQcQK0VAa70H10?= =?us-ascii?Q?EQOZ1DZkovAZUEotSaAjj2g+dvq4gG/Nubs9+bzz6M3O+sky5khws063t3Md?= =?us-ascii?Q?IH31n/ikScHcrGok2GUXtqJbw7hLx+93dxidwED0PMk4kWiujfRvfuQtvNPH?= =?us-ascii?Q?eCbzEH3RrkyP/WjG40SpnEiRsDrUYA9dmFN7h/eIfDFeibSsACTv8wdMDaIW?= =?us-ascii?Q?JJIFR8MjhD9TSkpWt6tJ6uUYbikOVeFZq1UV5k8N9funMz4gya9vmj5fwSa1?= =?us-ascii?Q?uCBuMARfGHmwKpT4RkUFBv82LrvNGZyKDSRG/W+f37H0mCKxMsNdSEaXEx8L?= =?us-ascii?Q?uKmxQTY+YSzHtASmazTQu3VITQdNBbsd8iC4/5f6+TwIArnnzh3oeUThGGJY?= =?us-ascii?Q?ix61ImaEc5KBnR39tEa/nkvPIk9QryBXl998sGmuw6a3VygCCLhMrKVRVyAq?= =?us-ascii?Q?iXLTViwYmTfEn9BYIYmvbNmrfIAWLuU4sX3vsULHGv/ZyKg/pFtlLYHdVyiz?= =?us-ascii?Q?3EPbE92XdIeGlGUBvnAg5u14V6mOUPnmeqhrMw0zR+oNYNcqQnSytfZhHey7?= =?us-ascii?Q?YN0B3WhMtyClRZSVwyjCjDVRnOFj4Z+rHaU6xXLGG4Flc7Ktl9jeEzRzuYfT?= =?us-ascii?Q?9j6ke5DGKs8Fb4qro9fh3odtfxYmjYIhdznoIsy7IFzphuXhmMmoNffiiAEY?= =?us-ascii?Q?4SbQcTRwgJ3lfa1saOSA64bMpzZDf9lDCJ8DdYsXQQVtr1UPxCw945hXpHiV?= =?us-ascii?Q?23m+TJmepP5P03/loCFwZN/Dt0D3SgE2VinoKo8/tcKjKwS4iIIo7F5WtVe+?= =?us-ascii?Q?jVoLx+/xzgWVE9cMbjGYJre6XFOcuzIsalaA0ePjpZqydIRJNHgHO0RLX8dX?= =?us-ascii?Q?TVhSFBOe89IuEqKGH1CWXOWZR2T5FRu3Ss2uKft6m2OFURE3oZIHHlPQmvbh?= =?us-ascii?Q?Ow=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: b7eb8c44-bf46-41bf-bc27-08ddff7cf184 X-MS-Exchange-CrossTenant-AuthSource: SJ5PPF0D43D62C4.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2025 17:23:45.1619 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WC4Ybd8aLvj4x3eUxIMRKOGpq1HxptjMBRa0t/6jqE2gJvA/zvqQ/ZjkUQiOZNYT5VDAwvLKskQGMVisEreIGPNACOB8pmVu7RwmFFwGVT8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7671 X-OriginatorOrg: intel.com On Mon, Sep 29, 2025 at 10:05:31AM -0500, Ira Weiny wrote: > Alison Schofield wrote: > > On Sun, Sep 28, 2025 at 09:31:10AM +0800, Jiapeng Chong wrote: > > > ./drivers/nvdimm/bus.c: linux/slab.h is included more than once. > > > > Hi Jiapeng, > > > > It would have been useful here to note where else slab.h was included, > > since it wasn't simply a duplicate #include in bus.c. > > Actually Alison this is a bug against linux-next where it was an issue > with Dave's patch here: > > https://lore.kernel.org/all/20250923174013.3319780-3-dave.jiang@intel.com/ Ah, I see this removes the dup that the above patch added. Why not remove fs.h instead of slab.h and get a clean up and de-dup in one shot? > > I'll queue this up. > > Reviewed-by: Ira Weiny > > Thanks, > Ira > > > > > I found slab.h is also in #include . Then I found that this > > compiles if I remove both of those includes. It would be worthwhile to > > check all the includes and send a new tested version of this patch that > > does this "Remove needless #include's in bus.c" > > > > BTW - I didn't check all #includes.There may be more beyond slab.h & fs.h. > > > > --Alison > > > > > > > > Reported-by: Abaci Robot > > > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=25516 > > > Signed-off-by: Jiapeng Chong > > > --- > > > drivers/nvdimm/bus.c | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c > > > index ad3a0493f474..87178a53ff9c 100644 > > > --- a/drivers/nvdimm/bus.c > > > +++ b/drivers/nvdimm/bus.c > > > @@ -13,7 +13,6 @@ > > > #include > > > #include > > > #include > > > -#include > > > #include > > > #include > > > #include > > > -- > > > 2.43.5 > > > > > > > >