Re: [PATCH v3 1/4] mm: Introduce vm_uffd_ops API

Mike Rapoport
2025-09-30T10:07:59Z

On Tue, Sep 30, 2025 at 11:36:53AM +0200, David Hildenbrand wrote:
> On 26.09.25 23:16, Peter Xu wrote:
> > + /**
> > + * uffd_get_folio: Handler to resolve UFFDIO_CONTINUE request.
>
> Just wondering if we could incorporate the "continue" / "minor" aspect into
> the callback name.
>
> uffd_minor_get_folio / uffd_continue_get_folio
>
> Or do you see use of that callback in the context of other uffd features?

If someone picks the gauntlet of refactoring the loop in mcopy_atomic()
we'd need a similar callback for uffd copy. And as I see it it would be
different enough to warrant emphasizing minor/continue in the name here.

I also think we can drop uffd_ prefix for the callback, as it's called as
uffd_ops->get_folio() or whatever it's be called.

> --
> Cheers
>
> David / dhildenb
>

--
Sincerely yours,
Mike.