Re: [PATCH v4 11/13] ARM: dts: aspeed: facebook-fuji: Include facebook-fuji-data64.dts

Tao Ren
2025-10-14T01:15:31Z

Hi Guenter,

On Mon, Oct 13, 2025 at 05:20:57PM -0700, Guenter Roeck wrote:
> Hi,
>
> On Sun, Jul 27, 2025 at 10:56:13PM -0700, rentao.bupt@gmail.com wrote:
> > From: Tao Ren <rentao.bupt@gmail.com>
> >
> > Include "facebook-fuji-data64.dts" in facebook-fuji dts to avoid
> > duplicated code.
> >
> > Fuji-data64 and Fuji are identical except the BMC flash layout.
> >
> > Signed-off-by: Tao Ren <rentao.bupt@gmail.com>
>
> With this patch in the mainline kernel, the Ethernet interface I use for
> testing does not come online when loading fuji-bmc in qemu.
>
> Reverting this patch fixes the problem.
>
> Looking into this patch,
>
> > -
> > -#include <dt-bindings/leds/common.h>
> > -#include "ast2600-facebook-netbmc-common.dtsi"
> > +#include "aspeed-bmc-facebook-fuji-data64.dts"
> >
> ...
> > -&mac3 {
> > - status = "okay";
> > - phy-mode = "rgmii";
> > - phy-handle = <&ethphy3>;
> > - pinctrl-names = "default";
> > - pinctrl-0 = <&pinctrl_rgmii4_default>;
> > -};
>
> I don't see this in aspeed-bmc-facebook-fuji-data64.dts, meaning that
> interface is now disabled. Adding it back in fixes the problem.
> Also, MAC3 is explicitly enabled for fuji-bmc in qemu.
>
> Was the interface disabled on purpose ?
>
> Thanks,
> Guenter

The mac3 interface was removed in the latest patch (v4) per Andrew Lunn's
feedback, because the rgmii setting is incorrect.

I was planning to add mac3 back as soon as rgmii support is properly
handled in aspeed mac driver, but kindly let me know if you have other
suggestions.

Thanks,

Tao