Re: [PATCH v4 11/13] ARM: dts: aspeed: facebook-fuji: Include facebook-fuji-data64.dts

Andrew Lunn
2025-10-15T00:13:14Z

> The fuji-data64.dts was copied from fuji.dts mainly for larger
> persistent data partition (64MB), and the latest fuji.dts includes
> fuji-data64.dts (instead of vice versa) because we wish to deprecate
> fuji.dts in the long term.
>
> So it is a regression for fuji, but fuji-data64.dts is a new node..
>
> My original plan is to add mac3 back to fuji-data64.dts (which will fix
> fuji.dts) when the rgmii fix is ready in aspeed mac driver, but I can
> add it back now if we need to fix the fuji regression asap. Please
> suggest.

Yes, please fix the regression.

> BTW, the current mac3 settings work in real fuji hardware because rgmii
> delay is configured in u-boot.

Which is the second wrong in "two wrongs make a right". Neither
u-boot, nor the driver should be adding delays with
phy-mode = 'rgmii'. That means the PCB is adding the delays.

Andrew