Re: [PATCH v7 00/14] hide ->i_state behind accessors

Christian Brauner
2025-10-10T11:29:31Z

On Thu, 09 Oct 2025 09:59:14 +0200, Mateusz Guzik wrote:
> Commit message from the patch adding helpers quoted verbatim with rationable + API:
>
> [quote]
> Open-coded accesses prevent asserting they are done correctly. One
> obvious aspect is locking, but significantly more can checked. For
> example it can be detected when the code is clearing flags which are
> already missing, or is setting flags when it is illegal (e.g., I_FREEING
> when ->i_count > 0).
>
> [...]

Applied to the vfs-6.19.inode branch of the vfs/vfs.git tree.
Patches in the vfs-6.19.inode branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.19.inode

[01/14] fs: move wait_on_inode() from writeback.h to fs.h
https://git.kernel.org/vfs/vfs/c/6605bf7d9536
[02/14] fs: spell out fenced ->i_state accesses with explicit smp_wmb/smp_rmb
https://git.kernel.org/vfs/vfs/c/1fdd36da49d5
[03/14] fs: provide accessors for ->i_state
https://git.kernel.org/vfs/vfs/c/1f4e908f28da
[04/14] Coccinelle-based conversion to use ->i_state accessors
https://git.kernel.org/vfs/vfs/c/91d75e00d68f
[05/14] Manual conversion to use ->i_state accessors of all places not covered by coccinelle
https://git.kernel.org/vfs/vfs/c/5b953be62d20
[06/14] btrfs: use the new ->i_state accessors
https://git.kernel.org/vfs/vfs/c/b77405952757
[07/14] ceph: use the new ->i_state accessors
https://git.kernel.org/vfs/vfs/c/9e121446182b
[08/14] smb: use the new ->i_state accessors
https://git.kernel.org/vfs/vfs/c/6f44aedc8692
[09/14] f2fs: use the new ->i_state accessors
https://git.kernel.org/vfs/vfs/c/60d14a5b26e3
[10/14] gfs2: use the new ->i_state accessors
https://git.kernel.org/vfs/vfs/c/8b5a2dbef579
[11/14] overlayfs: use the new ->i_state accessors
https://git.kernel.org/vfs/vfs/c/46ee05af3842
[12/14] nilfs2: use the new ->i_state accessors
https://git.kernel.org/vfs/vfs/c/ff6d2b3d3473
[13/14] xfs: use the new ->i_state accessors
https://git.kernel.org/vfs/vfs/c/fdbb1cb57675
[14/14] fs: make plain ->i_state access fail to compile