From: Carlos Llamas <cmllamas@google.com>
To: Alice Ryhl <aliceryhl@google.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Christian Brauner" <brauner@kernel.org>,
"Suren Baghdasaryan" <surenb@google.com>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH] rust_binder: remove warning about orphan mappings
Date: Fri, 3 Oct 2025 17:58:42 +0000 [thread overview]
Message-ID: <aOAO0kQtjovUUXQ-@google.com> (raw)
In-Reply-To: <20251002-binder-orphan-v1-1-cdc4cffff992@google.com>
On Thu, Oct 02, 2025 at 09:25:29AM +0000, Alice Ryhl wrote:
> This condition occurs if a thread dies while processing a transaction.
> We should not print anything in this scenario.
>
> Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> ---
> drivers/android/binder/process.rs | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/android/binder/process.rs b/drivers/android/binder/process.rs
> index f13a747e784c84a0fb09cbf47442712106eba07c..d8c3c1ae740e0eb3bcc8aa5e7faf4291f1cb69c9 100644
> --- a/drivers/android/binder/process.rs
> +++ b/drivers/android/binder/process.rs
> @@ -1346,10 +1346,6 @@ fn deferred_release(self: Arc<Self>) {
> .alloc
> .take_for_each(|offset, size, debug_id, odata| {
> let ptr = offset + address;
> - pr_warn!(
> - "{}: removing orphan mapping {offset}:{size}\n",
> - self.pid_in_current_ns()
> - );
> let mut alloc =
> Allocation::new(self.clone(), debug_id, offset, size, ptr, false);
> if let Some(data) = odata {
>
LGTM!
Acked-by: Carlos Llamas <cmllamas@google.com>
prev parent reply other threads:[~2025-10-03 17:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-02 9:25 [PATCH] rust_binder: remove warning about orphan mappings Alice Ryhl
2025-10-02 17:32 ` Joel Fernandes
2025-10-03 17:58 ` Carlos Llamas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aOAO0kQtjovUUXQ-@google.com \
--to=cmllamas@google.com \
--cc=aliceryhl@google.com \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=surenb@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox