From: Petr Mladek <pmladek@suse.com>
To: Joel Granados <joel.granados@kernel.org>
Cc: Daniel Xu <dlxu@meta.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: move nmi_watchdog sysctl into .rodata
Date: Mon, 6 Oct 2025 17:06:25 +0200 [thread overview]
Message-ID: <aOPa8RClyXaeyV6L@pathway.suse.cz> (raw)
In-Reply-To: <20250929-jag-nmiwd_const-v1-1-92200d503b1f@kernel.org>
On Mon 2025-09-29 17:55:07, Joel Granados wrote:
> Move nmi_watchdog into the watchdog_sysctls array to prevent it from
> unnecessary modification. This move effectively moves it inside the
> .rodata section.
>
> Initially moved out into its own non-const array in commit 9ec272c586b0
> ("watchdog/hardlockup: keep kernel.nmi_watchdog sysctl as 0444 if probe
> fails"), which made it writable only when watchdog_hardlockup_available
> was true. Moving it back to watchdog_sysctl keeps this behavior as
> writing to nmi_watchdog still fails when watchdog_hardlockup_available
> is false.
>
> Signed-off-by: Joel Granados <joel.granados@kernel.org>
The patch looks good to me. Updating the access rights was nice to
have. But it does not look not worth complicating the constification.
And proc_nmi_watchdog() works correctly even when the access rights
are always 0644.
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
next prev parent reply other threads:[~2025-10-06 15:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-29 15:55 [PATCH] watchdog: move nmi_watchdog sysctl into .rodata Joel Granados
2025-10-06 15:06 ` Petr Mladek [this message]
2025-10-09 14:20 ` Joel Granados
2025-10-09 14:48 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aOPa8RClyXaeyV6L@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=dlxu@meta.com \
--cc=joel.granados@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox