From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: Sune Brian <briansune@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound/soc/codecs/wm8978: add missing BCLK divider setup
Date: Tue, 7 Oct 2025 13:26:52 +0100 [thread overview]
Message-ID: <aOUHDJW5aJzD7Ku7@opensource.cirrus.com> (raw)
In-Reply-To: <e507ace6-90af-4763-a1e9-08e02f9e63f1@sirena.org.uk>
On Tue, Oct 07, 2025 at 01:18:02PM +0100, Mark Brown wrote:
> On Tue, Oct 07, 2025 at 01:11:24PM +0100, Charles Keepax wrote:
>
> > Its not missing its right there. That said your way is probably
> > slightly more standard these days, but we should take care of the
> > interaction between the two.
>
> Where we've had users using the manual divider configuration that we
> cared about in the past we've suppressed automatic configuration if
> manual configuration has ever been done by the machine driver.
I don't see any current users for the manual divider configuration
at least in mainline, so we could probably just drop the manual
stuff. I don't think I have a strong opinion between that
and blocking the automatic configuration if it was previously
set manually, but we should do one of them to keep things clear.
Thanks,
Charles
next prev parent reply other threads:[~2025-10-07 12:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-03 9:13 [PATCH] sound/soc/codecs/wm8978: add missing BCLK divider setup Brian Sune
2025-10-07 10:30 ` Charles Keepax
2025-10-07 11:22 ` Sune Brian
2025-10-07 12:11 ` Charles Keepax
2025-10-07 12:18 ` Mark Brown
2025-10-07 12:26 ` Charles Keepax [this message]
2025-10-07 12:30 ` Mark Brown
2025-10-07 12:37 ` Sune Brian
2025-10-07 12:48 ` Sune Brian
2025-10-07 13:15 ` Charles Keepax
2025-10-07 13:39 ` Sune Brian
2025-10-07 13:48 ` Mark Brown
2025-10-07 13:54 ` Sune Brian
2025-10-07 11:33 ` [PATCH v2] ASoC: wm8978: " Brian Sune
2025-10-07 11:44 ` Mark Brown
2025-10-07 11:48 ` Sune Brian
2025-10-07 11:52 ` Mark Brown
2025-10-07 11:56 ` Sune Brian
2025-10-07 12:10 ` Mark Brown
2025-10-07 13:03 ` Sune Brian
2025-10-07 13:15 ` Mark Brown
2025-10-07 13:48 ` Sune Brian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aOUHDJW5aJzD7Ku7@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=briansune@gmail.com \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox