From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA9CF2E1EE7 for ; Tue, 7 Oct 2025 13:58:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759845503; cv=none; b=uORJolB8WXdL0x+lhi0Qma0VlqR9ErI3erY+oIaMnAVNcFig394a3H0xdrQXDsMEmN3R/tqFbcirnw0GhZVvqunR2SgBB2ujwgaKVCKGOWYQXsDwWtdLREzKCqkX0hgrKwv3M59Ti2/mtVy3hDsfCAwteUnxMmmn1yydURI8RGE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759845503; c=relaxed/simple; bh=2p6sw/d5o9WykeyOnWT+2vs8b7uJ9tBZ8iAVCQgjDZQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=TZxQWBMJde0OuGMpwz93RWk4hHlA8t6/28jcahh2IR1NILdhL+nE7mLZuyeRx9Nw1zJOWOiPtfpD6hT4E/kiX3KwY/KB1hCWV/3oQ6d8bZdXgkCw4scZCammYvMvnNDjWerTWXsNX4zUNRcNO219m6nk+SiL6rt6YzWWWYfO8ew= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Kc0DNiPQ; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Kc0DNiPQ" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-b5535902495so4392954a12.0 for ; Tue, 07 Oct 2025 06:58:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1759845500; x=1760450300; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=4rlYUY99rqPM8GfD927WUvhieIqn1G/yd0+acs0pn14=; b=Kc0DNiPQcf/Yg01kLqjQ2vgJ4iF8e+BxDeVfek9w09kHNgTtWfloa6M9vZfkcMndko P7OcTak5OqvEIPyvXQWKAWL+I8ggor676Gl/ZAi6tD9BKnndGPwZ7BvztfkW2AhvCb8R tR/GD/91sPOM597EU4hYlxBCxNUOtcOS//siFo9xeGqGNy3zDONYdoD96hDRtLWBhXcm Byeq6nHbFyFT30rJHeC0Nb+6pxh9lH0EVYDxKzB8NWOQutGWPYb4A/qE1Rls4U8bZcHz mYIIdEVyiOuvl7+VmIUkr5Wvefplcgdtd4zFb3OLTfwSavPlW1rnb+pi87r3npqnyNeN Bt2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759845500; x=1760450300; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4rlYUY99rqPM8GfD927WUvhieIqn1G/yd0+acs0pn14=; b=mS5ubQHVbbh8u0JKDOvmK17wJfSDh2zvOh1HPdny6CMRFNIbF6KFe771Ki5iug1iD+ 8W90m+N2LzHiR5vxUAbEPfnlZTx+pIunKZumA8FiSwzox16FtRMzy8qYTKYT3pRqo25m UclcQQDBmLTvHoHjDBE1x2W42YzjppD5vwa2kF4wI8CdDkyJZGWcV9D+upkEalEGeGY9 Mf0dCJRxSFyIccQJNmtSUjsiR2vPLpnJhLchQ+zcr+qgBZoadgtro8tX8EBSxISYy3Dq HyaPooAR4cEJ3aq8bOffu9Cn+0Q4NxbZkJGQlt3bHvtgoLTpDdCpL5y0kQlOiZ4xTl0l e3mg== X-Forwarded-Encrypted: i=1; AJvYcCUOxo3XN6SNreovMheEQBTo0Wz82xiL1Z9ljxtUZCfZ/YBN5RaBD6HMeJq1NZZ+XFkAiV2DOPYxGQEaif0=@vger.kernel.org X-Gm-Message-State: AOJu0Ywp53/Vnb1pVhsxXOmCo9mnbUeGAuKU9HdddHCjpY8vrHHrFR8s WbwAER/VadyJozAz6LOAc26SOSA6zsFq/TUvJeYwSdzgoloafMo8Th+9t/NiiR9gF0MLoyd38xf u6chhXg== X-Google-Smtp-Source: AGHT+IH44LYFtR2Z9aj26aSM38dj+lWGcrky74kzzSLe1xZuZzZCEhZOyIjquiME0rIkS/AaVEe3J4tloO4= X-Received: from pjbmw12.prod.google.com ([2002:a17:90b:4d0c:b0:329:b272:45a7]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:1c05:b0:335:2823:3686 with SMTP id 98e67ed59e1d1-339c274089dmr20831446a91.2.1759845499915; Tue, 07 Oct 2025 06:58:19 -0700 (PDT) Date: Tue, 7 Oct 2025 06:58:18 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20231105163040.14904-1-pbonzini@redhat.com> <20231105163040.14904-16-pbonzini@redhat.com> Message-ID: Subject: Re: [PATCH 15/34] KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory From: Sean Christopherson To: Nikita Kalyazin Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , "=?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?=" , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A. Shutemov" Content-Type: text/plain; charset="us-ascii" On Fri, Oct 03, 2025, Nikita Kalyazin wrote: > On 05/11/2023 16:30, Paolo Bonzini wrote: > > From: Sean Christopherson > > > > Introduce an ioctl(), KVM_CREATE_GUEST_MEMFD, to allow creating file-based > > memory that is tied to a specific KVM virtual machine and whose primary > > purpose is to serve guest memory. > > ... > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > > index f1a575d39b3b..8f46d757a2c5 100644 > > --- a/virt/kvm/kvm_main.c > > +++ b/virt/kvm/kvm_main.c > > ... > > > -static int check_memory_region_flags(const struct kvm_userspace_memory_region2 *mem) > > +static int check_memory_region_flags(struct kvm *kvm, > > + const struct kvm_userspace_memory_region2 *mem) > > { > > u32 valid_flags = KVM_MEM_LOG_DIRTY_PAGES; > > + if (kvm_arch_has_private_mem(kvm)) > > + valid_flags |= KVM_MEM_GUEST_MEMFD; > > + > > + /* Dirty logging private memory is not currently supported. */ > > + if (mem->flags & KVM_MEM_GUEST_MEMFD) > > + valid_flags &= ~KVM_MEM_LOG_DIRTY_PAGES; > > I was wondering whether this restriction is still required at this stage or > can be lifted in cases where the guest memory is accessible by the host. Off the top of my head, I can't think of any reason why dirty logging wouldn't work with guest_memfd for non-CoCo VMs. We'd likely need to explicitly enumerate support to userspace, and there might be some assumptions lurking in KVM, but fundamentally it should Just Work (TM). > Specifically, it would be useful to support differential memory snapshots > based on dirty page tracking in Firecracker [1] or in live migration. As an > experiment, I removed the check and was able to produce a diff snapshot and > restore a Firecracker VM from it. > > [1] https://github.com/firecracker-microvm/firecracker/blob/main/docs/snapshotting/snapshot-support.md#creating-diff-snapshots > > > + > > #ifdef __KVM_HAVE_READONLY_MEM > > valid_flags |= KVM_MEM_READONLY; > > #endif > > @@ -2018,7 +2029,7 @@ int __kvm_set_memory_region(struct kvm *kvm, > > int as_id, id; > > int r; > > - r = check_memory_region_flags(mem); > > + r = check_memory_region_flags(kvm, mem); > > if (r) > > return r;