From: Benson Leung <bleung@google.com>
To: Jameson Thies <jthies@google.com>
Cc: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, dmitry.baryshkov@oss.qualcomm.com,
bleung@chromium.org, gregkh@linuxfoundation.org,
akuchynski@chromium.org, abhishekpandit@chromium.org,
sebastian.reichel@collabora.com, linux-pm@vger.kernel.org
Subject: Re: [PATCH 3/6] usb: typec: ucsi: Report power supply changes on power opmode changes
Date: Tue, 7 Oct 2025 23:51:40 +0000 [thread overview]
Message-ID: <aOWnjAgB7rEERd1-@google.com> (raw)
In-Reply-To: <20251007000007.3724229-4-jthies@google.com>
[-- Attachment #1: Type: text/plain, Size: 1346 bytes --]
On Tue, Oct 07, 2025 at 12:00:04AM +0000, Jameson Thies wrote:
> Report opmode changes from the PPM to the power supply class by calling
> ucsi_port_psy_changed(). If the current opmode is USB PD, do not call
> ucsi_port_psy_changed(). The power supply class will be updated after
> requesting partner source PDOs.
>
> Signed-off-by: Jameson Thies <jthies@google.com>
Reviewed-by: Benson Leung <bleung@chromium.org>
> ---
> drivers/usb/typec/ucsi/ucsi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
> index 3f568f790f39..7b718049d0d1 100644
> --- a/drivers/usb/typec/ucsi/ucsi.c
> +++ b/drivers/usb/typec/ucsi/ucsi.c
> @@ -1022,14 +1022,17 @@ static void ucsi_pwr_opmode_change(struct ucsi_connector *con)
> case UCSI_CONSTAT_PWR_OPMODE_TYPEC1_5:
> con->rdo = 0;
> typec_set_pwr_opmode(con->port, TYPEC_PWR_MODE_1_5A);
> + ucsi_port_psy_changed(con);
> break;
> case UCSI_CONSTAT_PWR_OPMODE_TYPEC3_0:
> con->rdo = 0;
> typec_set_pwr_opmode(con->port, TYPEC_PWR_MODE_3_0A);
> + ucsi_port_psy_changed(con);
> break;
> default:
> con->rdo = 0;
> typec_set_pwr_opmode(con->port, TYPEC_PWR_MODE_USB);
> + ucsi_port_psy_changed(con);
> break;
> }
> }
> --
> 2.51.0.618.g983fd99d29-goog
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-10-07 23:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 0:00 [PATCH 0/6] UCSI Power Supply Updates and Bug Fixes Jameson Thies
2025-10-07 0:00 ` [PATCH 1/6] usb: typec: ucsi: psy: Add power supply status Jameson Thies
2025-10-08 12:53 ` Heikki Krogerus
2025-10-07 0:00 ` [PATCH 2/6] usb: typec: ucsi: psy: Add support for DRP USB type Jameson Thies
2025-10-07 23:50 ` Benson Leung
2025-10-08 13:02 ` Heikki Krogerus
2025-10-13 20:44 ` Jameson Thies
2025-10-07 0:00 ` [PATCH 3/6] usb: typec: ucsi: Report power supply changes on power opmode changes Jameson Thies
2025-10-07 23:51 ` Benson Leung [this message]
2025-10-08 13:02 ` Heikki Krogerus
2025-10-07 0:00 ` [PATCH 4/6] usb: typec: ucsi: Report power supply change on sink path change Jameson Thies
2025-10-07 23:52 ` Benson Leung
2025-10-08 13:06 ` Heikki Krogerus
2025-10-13 20:45 ` Jameson Thies
2025-10-07 0:00 ` [PATCH 5/6] usb: typec: ucsi: psy: Set max current to zero when disconnected Jameson Thies
2025-10-07 23:55 ` Benson Leung
2025-10-08 13:08 ` Heikki Krogerus
2025-10-07 0:00 ` [PATCH 6/6] usb: typec: ucsi: pr_swap should check connector_status Jameson Thies
2025-10-07 23:56 ` Benson Leung
2025-10-08 13:10 ` Heikki Krogerus
2025-10-13 20:56 ` Jameson Thies
2025-10-13 7:33 ` [PATCH 0/6] UCSI Power Supply Updates and Bug Fixes Greg KH
2025-10-13 20:59 ` Jameson Thies
2025-10-14 5:19 ` Greg KH
2025-10-13 21:02 ` Kenneth Crudup
2025-10-13 22:53 ` Jameson Thies
2025-10-13 23:26 ` Kenneth Crudup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aOWnjAgB7rEERd1-@google.com \
--to=bleung@google.com \
--cc=abhishekpandit@chromium.org \
--cc=akuchynski@chromium.org \
--cc=bleung@chromium.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jthies@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox