public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Kael D'Alcamo <dev@kael-k.io>
Cc: Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Wei Yan <sledge.yanwei@huawei.com>,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: i2c: hisilicon,hix5hd2-i2c convert to DT schema
Date: Wed, 8 Oct 2025 09:22:20 +0200	[thread overview]
Message-ID: <aOYRLCGv9_k8i_Vn@shikoro> (raw)
In-Reply-To: <20251004154808.116143-2-dev@kael-k.io>

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

Hi,

thanks for this conversion!

> +properties:
> +  compatible:
> +    enum:
> +      - hisilicon,hix5hd2-i2c

Question for DT maintainers: Is it preferred to start with 'enum' right
away or to start with 'const' and convert to 'enum' once a second user
appears?

> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 0

These should be left out because they come from i2c-controller.yaml?

> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - "#address-cells"
> +  - "#size-cells"

Same here for the last two?

Happy hacking,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2025-10-08  7:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-04 15:48 [PATCH] dt-bindings: i2c: hisilicon,hix5hd2-i2c convert to DT schema Kael D'Alcamo
2025-10-07 20:49 ` Conor Dooley
2025-10-08  7:22 ` Wolfram Sang [this message]
2025-10-08  8:41   ` Krzysztof Kozlowski
2025-10-08 20:04     ` [PATCH v2 0/1] " Kael D'Alcamo
2025-10-08 20:04       ` [PATCH v2 1/1] " Kael D'Alcamo
2025-10-09  0:23         ` Krzysztof Kozlowski
2025-10-09 11:22         ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aOYRLCGv9_k8i_Vn@shikoro \
    --to=wsa+renesas@sang-engineering.com \
    --cc=andi.shyti@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=dev@kael-k.io \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sledge.yanwei@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox