From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Artem Shimko <a.shimko.dev@gmail.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_dw: handle reset control deassert error
Date: Wed, 15 Oct 2025 19:35:44 +0300 [thread overview]
Message-ID: <aO_NYGFCKb0J2uqK@smile.fi.intel.com> (raw)
In-Reply-To: <20251009081309.2021600-1-a.shimko.dev@gmail.com>
On Thu, Oct 09, 2025 at 11:13:08AM +0300, Artem Shimko wrote:
> Check the return value of reset_control_deassert() in the probe
> function to prevent continuing probe when reset deassertion fails.
>
> Previously, reset_control_deassert() was called without checking its
> return value, which could lead to probe continuing even when the
> device reset wasn't properly deasserted.
>
> The fix checks the return value and returns an error with dev_err_probe()
> if reset deassertion fails, providing better error handling and
> diagnostics.
If it's not applied yet, it deserves the Fixes tag, I believe.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-10-18 17:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 8:13 [PATCH] serial: 8250_dw: handle reset control deassert error Artem Shimko
2025-10-15 16:35 ` Andy Shevchenko [this message]
2025-10-19 8:53 ` [PATCH v2] " Artem Shimko
2025-10-19 9:00 ` Greg KH
2025-10-19 9:51 ` [PATCH v3] " Artem Shimko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aO_NYGFCKb0J2uqK@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=a.shimko.dev@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox