From: Simon Horman <horms@kernel.org>
To: Florian Westphal <fw@strlen.de>
Cc: Eric Dumazet <edumazet@google.com>,
Wang Liang <wangliang74@huawei.com>,
nhorman@tuxdriver.com, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, yuehaibing@huawei.com,
zhangchangzhong@huawei.com
Subject: Re: [PATCH RFC net-next] net: drop_monitor: Add debugfs support
Date: Wed, 15 Oct 2025 17:49:55 +0100 [thread overview]
Message-ID: <aO_Qs9jzbguNrTjV@horms.kernel.org> (raw)
In-Reply-To: <aO-CJ7caP083oBJg@strlen.de>
On Wed, Oct 15, 2025 at 01:14:47PM +0200, Florian Westphal wrote:
> Eric Dumazet <edumazet@google.com> wrote:
> > I do not understand the fascination with net/core/drop_monitor.c,
> > which looks very old school to me,
> > and misses all the features, flexibility, scalability that 'perf',
> > eBPF tracing, bpftrace, .... have today.
> >
> > Adding /sys/kernel/debug/drop_monitor/* is even more old school.
> >
> > Not mentioning the maintenance burden.
> >
> > For me the choice is easy :
> >
> > # CONFIG_NET_DROP_MONITOR is not set
> >
> > perf record -ag -e skb:kfree_skb sleep 1
> >
> > perf script # or perf report
>
> Maybe:
>
> diff --git a/net/Kconfig b/net/Kconfig
> --- a/net/Kconfig
> +++ b/net/Kconfig
> @@ -400,15 +400,15 @@ config NET_PKTGEN
> module will be called pktgen.
>
> config NET_DROP_MONITOR
> - tristate "Network packet drop alerting service"
> + tristate "Legacy network packet drop alerting service"
+1
...
next prev parent reply other threads:[~2025-10-15 16:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 10:14 [PATCH RFC net-next] net: drop_monitor: Add debugfs support Wang Liang
2025-10-15 10:40 ` Eric Dumazet
2025-10-15 11:14 ` Florian Westphal
2025-10-15 16:49 ` Simon Horman [this message]
2025-10-16 6:26 ` Wang Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aO_Qs9jzbguNrTjV@horms.kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=pabeni@redhat.com \
--cc=wangliang74@huawei.com \
--cc=yuehaibing@huawei.com \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox