The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Dave Martin <Dave.Martin@arm.com>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: Babu Moger <babu.moger@amd.com>,
	tony.luck@intel.com, james.morse@arm.com, tglx@linutronix.de,
	mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
	x86@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org,
	peternewman@google.com, eranian@google.com,
	gautham.shenoy@amd.com
Subject: Re: [PATCH] x86/resctrl: Fix buggy overflow when reactivating previously Unavailable RMID
Date: Wed, 8 Oct 2025 16:23:57 +0100	[thread overview]
Message-ID: <aOaCDee7xbhA0ji3@e133380.arm.com> (raw)
In-Reply-To: <fe06aa33-3351-45d4-a687-ff88a689be6e@intel.com>

Hi,

On Tue, Oct 07, 2025 at 01:23:36PM -0700, Reinette Chatre wrote:
> Hi Babu,
> 
> Thank you for catching and preparing a fix for this issue.
> 
> On 10/6/25 4:13 PM, Babu Moger wrote:
> > The issue was observed during testing on systems with multiple resctrl
> > domains, where tasks were dynamically moved between domains.
> 
> (please let changelog stand on its own and not be a continuation of subject line)

[...]

[Quick, drive-by observation:]

Can I add that the commit message also seems way too long?

I think some of the description of the problem symptom could probably
be after the tearoff -- there doesn't seem to be a clear statement of
what is actually wrong in the code, or of why the change made in the
patch fixes it (or if there is, I struggled to find it.)

I puzzled over this for some minutes before I figured out this patch is
fixing something that is not upstream, yet.  A statement to that effect
would have helped.

Possibly I didn't read carefully enough...

Cheers
---Dave

  parent reply	other threads:[~2025-10-08 15:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-06 23:13 [PATCH] x86/resctrl: Fix buggy overflow when reactivating previously Unavailable RMID Babu Moger
2025-10-07 20:23 ` Reinette Chatre
2025-10-07 23:47   ` Moger, Babu
2025-10-08  3:04     ` Reinette Chatre
2025-10-08 18:08       ` Babu Moger
2025-10-08 15:23   ` Dave Martin [this message]
2025-10-08 18:42     ` Babu Moger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aOaCDee7xbhA0ji3@e133380.arm.com \
    --to=dave.martin@arm.com \
    --cc=babu.moger@amd.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=eranian@google.com \
    --cc=gautham.shenoy@amd.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peternewman@google.com \
    --cc=reinette.chatre@intel.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox