Re: [PATCH] wifi: wcn36xx: Remove unused wcn36xx_smd_update_scan_params

["Dr. David Alan Gilbert" <linux@treblig.org>]

* Loic Poulain (loic.poulain@oss.qualcomm.com) wrote:
> Hi Dave,
> 
> On Fri, Oct 10, 2025 at 2:46 AM Dr. David Alan Gilbert
> <linux@treblig.org> wrote:
> >
> > * Jeff Johnson (jeff.johnson@oss.qualcomm.com) wrote:
> > > On 10/9/2025 3:15 PM, Loic Poulain wrote:
> > > > Hi Jeff,
> > > >
> > > > On Thu, Oct 9, 2025 at 5:25 PM Dr. David Alan Gilbert <linux@treblig.org> wrote:
> > > >>
> > > >> * Loic Poulain (loic.poulain@oss.qualcomm.com) wrote:
> > > >>> On Thu, Jun 19, 2025 at 3:05 AM <linux@treblig.org> wrote:
> > > >>>>
> > > >>>> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > > >>>>
> > > >>>> wcn36xx_smd_update_scan_params() last use was removed in 2020 by
> > > >>>> commit 5973a2947430 ("wcn36xx: Fix software-driven scan")
> > > >>>>
> > > >>>> Remove it.
> > > >>>>
> > > >>>> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > > >>>
> > > >>> Reviewed-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> > > >>
> > > >> Hi Loic,
> > > >>   Is this getting into a pull somewhere?
> > > >
> > > > Can it be picked for ath10-next?
> > >
> > > This was not on my radar since it wasn't sent to linux-wireless and hence
> > > isn't tracked in patchwork. I just looked at it and it seems the following are
> > > now also unused and could be removed:
> > > struct wcn36xx_hal_update_scan_params_resp
> > > struct wcn36xx_hal_update_scan_params_req_ex
> >
> > Oh, I'm happy to cook a v2 for that if Loic agrees they should go
> > (I know some drivers like to keep struct definitions if they document the hardware)
> 
> The software based scanning never worked very well, so I'm not even
> sure the related structs are correct or complete, so it's ok to remove
> in your v2.

Sure.

> > > Let me know if you want me to take this as-is or wait for a v2. If you send a
> > > v2 please also include linux-wireless so that it is tracked by patchwork.
> >
> > Sure.
> >
> > Note that linux-wireless isn't included in get_maintainer output for this:
> >
> > $ scripts/get_maintainer.pl -f drivers/net/wireless/ath/wcn36xx/smd.c
> > Loic Poulain <loic.poulain@oss.qualcomm.com> (maintainer:QUALCOMM WCN36XX WIRELESS DRIVER)
> > wcn36xx@lists.infradead.org (open list:QUALCOMM WCN36XX WIRELESS DRIVER)
> > linux-kernel@vger.kernel.org (open list)
> > QUALCOMM WCN36XX WIRELESS DRIVER status: Supported
> 
> Indeed, would you mind submitting a fix for the MAINTAINERS file?

No problem.

I'll cook a pair of patches.

Dave

> Regards,
> Loic
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/