From: Vaibhav Gupta <vaibhavgupta40@gmail.com>
To: "Michael Büsch" <mb@bues.ch>
Cc: kernel test robot <lkp@intel.com>,
oe-kbuild-all@lists.linux.dev, Bjorn Helgaas <helgaas@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] driver: gpio-bt8xx: use generic PCI PM
Date: Sat, 11 Oct 2025 12:37:35 +0000 [thread overview]
Message-ID: <aOpPj86wEmtpIQQ_@gmail.com> (raw)
In-Reply-To: <20251011143123.094043ed@barney>
On Sat, Oct 11, 2025 at 02:31:23PM +0200, Michael Büsch wrote:
> On Sat, 11 Oct 2025 11:32:11 +0000
> Vaibhav Gupta <vaibhavgupta40@gmail.com> wrote:
>
> > > It looks like the
> > > #ifdef CONFIG_PM
> > > must be removed from struct bt8xxgpio definition.
> > Ah yes, this macro somehow got overlooked by me. I will send a v2.
> > Thanks for the review!
>
>
> Also, the SIMPLE_DEV_PM_OPS macro seems to be deprecated in favour of DEFINE_SIMPLE_DEV_PM_OPS.
Okay I will have a look to it. Ingonre v2 in this case.
>
> And please do a compile test when submitting v2. Thanks :)
Sure! I created another config file to disable CONFIG_PM just to make sure
during compile test.
Regards,
Vaibhav
>
> --
> Michael Büsch
> https://bues.ch/
next prev parent reply other threads:[~2025-10-11 12:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 10:53 [PATCH v1] driver: gpio-bt8xx: use generic PCI PM Vaibhav Gupta
2025-10-11 1:43 ` kernel test robot
2025-10-11 10:26 ` Michael Büsch
2025-10-11 11:32 ` Vaibhav Gupta
2025-10-11 12:31 ` Michael Büsch
2025-10-11 12:37 ` Vaibhav Gupta [this message]
2025-10-11 12:57 ` [PATCH v3] " Vaibhav Gupta
2025-10-13 11:04 ` [PATCH v4] driver: gpio: bt8xx: " Vaibhav Gupta
2025-10-11 12:32 ` [PATCH v2] driver: gpio-bt8xx: " Vaibhav Gupta
2025-10-13 9:41 ` [PATCH v1] " Bartosz Golaszewski
2025-10-13 11:03 ` Vaibhav Gupta
2025-10-13 15:36 ` Bartosz Golaszewski
2025-10-13 15:51 ` Vaibhav Gupta
2025-10-13 15:52 ` [PATCH v5] gpio: bt8xx: " Vaibhav Gupta
2025-10-13 17:43 ` Bjorn Helgaas
2025-10-16 16:36 ` [PATCH v6] gpio: bt8xx: use generic power management Vaibhav Gupta
2025-10-21 8:48 ` Bartosz Golaszewski
2025-10-22 19:29 ` Bjorn Helgaas
2025-10-23 7:49 ` Vaibhav Gupta
2025-10-23 7:55 ` Bartosz Golaszewski
2025-10-23 7:58 ` Vaibhav Gupta
2025-10-23 7:59 ` Bartosz Golaszewski
2025-10-16 16:37 ` [PATCH v5] gpio: bt8xx: use generic PCI PM Vaibhav Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aOpPj86wEmtpIQQ_@gmail.com \
--to=vaibhavgupta40@gmail.com \
--cc=brgl@bgdev.pl \
--cc=helgaas@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mb@bues.ch \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox