From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D781259CBC for ; Sat, 25 Oct 2025 21:18:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761427097; cv=none; b=R8ks2/u6uJm2Wy8Q8nRCmMQeKixzL3f/FjNjWeaktJF1TQe7GyPqwxs6lA6yrQug14dWfkpOoFe76kAVStlXYY52NhPQT1rjuJj8uv8ekctVkXppL0Pr8nEFINZ6Lbq0rr70FJEVnTp/GabjbBXdcvyL+VxMDCTfNi7VpzTYQCM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761427097; c=relaxed/simple; bh=3bsFJNE4DE47AGrHwWCWsH5kkVM8VML79+gkO8TWy4Y=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eFp/V65fd49E4B79zIllR0J9/H5xmFCQiFYiw4i20e4UyVhVkn5JP/qrf+22E2cvj6IAe7qqNQ6vEndhHYzfOQE2TqMGDQv3qJnpS1YRyT/JTPt9JDzWFhQ2srvL4G7Q8GQMcodMa/l0Zp4KDMVuIpYzm7dPng+sqB/ptqI3/Ko= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mZEX4CE+; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mZEX4CE+" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-475db4ad7e4so3141855e9.3 for ; Sat, 25 Oct 2025 14:18:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761427093; x=1762031893; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=3c1WBcRxq8wi3EgsqQk7zV+qxOcJsiv7FtZH/pCDIvU=; b=mZEX4CE+Evz7rK6n13uoO+oaBt/vTGBXt6fMM7JWaD83VHSqUwqR8XS9AA/Ol8qIhc 4GcmTV3pvquzRxqc2hPUKAsiT8jDcLxBsbBTf1V+HLskARyMqjmeRWROkDCf5VoRc/NT gyE6puY26dU+BDRxJriQfusveL7gHfG2lAMSWoa5CRsbQkDUAzZOrYpQVvfW6TxlfLWF 39Vex8olo0zFL91ltxC3ncEYXDLSlumoL0JPGv/gIEyNz33LJ0mtUnZwEKVTG64JNkgi DnjcdRQlnJdypsllSllkeo+c/+PV7PDeQGXB+ZEfNKr+oRJi45h5FF6zKVY2ngPbqoDt dscw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761427093; x=1762031893; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3c1WBcRxq8wi3EgsqQk7zV+qxOcJsiv7FtZH/pCDIvU=; b=WU8ZlBblF4n3ir8S6pxIMf0TwO5QEu1M22yHyU7lZJCiOJNPNxRhhlqMlXi4RoicBI cwDXFCWuZaxe4WWGEL50hBfrezROQEtx3YAcbGUQ1xO4ubbxgU2qpQKLKZtovNMb24pT m1/BQ84GCeVwgZ46S4z7f/cqwJgcU/KVaI9dRCqe0CIqXt1X91dBMjgap3iASOMHqyAc 3oP2razhijpIB9KacgTrNctuDvCNIUHcxEIcMppnLGLvfFqMGSnpnFNuKHLR99ywG8a2 IEKwfMfOO3KOp56zpXeZK7IimxLko1oyoDW4b90xgX2OeYVV6tuBKUMFyL0+MVkJzMjX f+Fg== X-Forwarded-Encrypted: i=1; AJvYcCVUB5vxnyf9TjRYnqevd9HBbd4lyTPy+AOwxE4QnNSOfOAGJlnInS3F6dIAydGyvkreEVSwe+WGZMGqRq8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/ZlT+7AGmC6x7uJ3XfKb5eGEusedGEGjpFntare2g7zqWef29 CGt85z2q02JkEelIm6P+X+zYbmuNTya65NzyQTYg9l1ONSr5DgFPerAi X-Gm-Gg: ASbGnct7OT/SBkP5WReg9VhOUqjQcNeWZGnDMEISKgwvxS3BPejS3mb1APEDzctlbqz X9OyddZ1MuD7YLqv3Er+3tyQDqd5/IYPkqx9uIdV+dlLHb7muXyTyHP+PhNdyMUj/4tnChLxgU2 0EvpneOi/eFqsUzjppZaGkKaqpjLqnQHZxHsa8Cm82SuYbHx5fYQl+uVAoV4t3KLpsxTzFf+Z7z LYK34SF29UrePUGMBBE43DPiumGrPgSmy83aWvU98s8TZpJCzC+Hs6C8oT21psv47W3kBZQw/nb hNXTr5c6jCbs1ZTgnreoe8KrwBHtGXEJu5PKnOr7emHPisWT41UCHCYgSdSeTlaQ9+UBZlGJPMA 11Jcc7Qgn9RVrPzAJmSJ0DtClpWNBer2YwyRNXd0xCf11q6dj47nM/ByyyDLVUYocfuf+oWC8AI c= X-Google-Smtp-Source: AGHT+IEKmGV6iwycAf4O/Au0c79Uf5s26+e12RwvflkfNHz45yscxbt7voylHffu4v/BbZtKilFDgg== X-Received: by 2002:a05:600c:64c3:b0:477:ad4:4920 with SMTP id 5b1f17b1804b1-4770ad449b4mr8309285e9.10.1761427093382; Sat, 25 Oct 2025 14:18:13 -0700 (PDT) Received: from krava ([176.74.159.170]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429952db964sm5427322f8f.33.2025.10.25.14.18.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 14:18:12 -0700 (PDT) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Sat, 25 Oct 2025 23:18:11 +0200 To: Nirbhay Sharma Cc: Kees Cook , Shuah Khan , Andy Lutomirski , Will Drewry , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, khalid@kernel.org, david.hunter.linux@gmail.com, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH] selftests/seccomp: fix pointer type mismatch in UPROBE test Message-ID: References: <20251025184903.154755-2-nirbhay.lkd@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251025184903.154755-2-nirbhay.lkd@gmail.com> On Sun, Oct 26, 2025 at 12:19:04AM +0530, Nirbhay Sharma wrote: > Fix compilation error in UPROBE_setup caused by pointer type mismatch > in ternary expression. The probed_uretprobe and probed_uprobe function > pointers have different type attributes (__attribute__((nocf_check))), just probed_uprobe right? > which causes the conditional operator to fail with: > > seccomp_bpf.c:5175:74: error: pointer type mismatch in conditional > expression [-Wincompatible-pointer-types] curious what compiler do you see that with? gcc-15 is silent, the change looks good to me thanks, jirka > > Cast both function pointers to 'const void *' to match the expected > parameter type of get_uprobe_offset(), resolving the type mismatch > while preserving the function selection logic. > > Signed-off-by: Nirbhay Sharma > --- > tools/testing/selftests/seccomp/seccomp_bpf.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c > index 874f17763536..e13ffe18ef95 100644 > --- a/tools/testing/selftests/seccomp/seccomp_bpf.c > +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c > @@ -5172,7 +5172,8 @@ FIXTURE_SETUP(UPROBE) > ASSERT_GE(bit, 0); > } > > - offset = get_uprobe_offset(variant->uretprobe ? probed_uretprobe : probed_uprobe); > + offset = get_uprobe_offset(variant->uretprobe ? > + (const void *)probed_uretprobe : (const void *)probed_uprobe); > ASSERT_GE(offset, 0); > > if (variant->uretprobe) > -- > 2.48.1 > >