Re: [PATCH v4 1/2] driver: reset: spacemit-p1: add driver for poweroff/reboot

[Yao Zi <ziyao@disroot.org>]

On Mon, Oct 27, 2025 at 11:20:33AM +0800, Troy Mitchell wrote:
> On Sun, Oct 26, 2025 at 11:41:14PM +0100, Aurelien Jarno wrote:
> > This driver implements poweroff/reboot support for the SpacemiT P1 PMIC
> > chip, which is commonly paired with the SpacemiT K1 SoC.
> > 
> > The SpacemiT P1 support is implemented as a MFD driver, so the access is
> > done directly through the regmap interface. Reboot or poweroff is
> > triggered by setting a specific bit in a control register, which is
> > automatically cleared by the hardware afterwards.
> > 
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > ---
> > v2:
> >  - Replace the "select" by a "depends on"
> >  - Remove outdated Reviewed-by
> > 
> >  drivers/power/reset/Kconfig              |  9 +++
> >  drivers/power/reset/Makefile             |  1 +
> >  drivers/power/reset/spacemit-p1-reboot.c | 88 ++++++++++++++++++++++++
> >  3 files changed, 98 insertions(+)
> >  create mode 100644 drivers/power/reset/spacemit-p1-reboot.c
> > 
> > diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> > index 8248895ca9038..61c16f3d5abc7 100644
> > --- a/drivers/power/reset/Kconfig
> > +++ b/drivers/power/reset/Kconfig
> > @@ -283,6 +283,15 @@ config POWER_RESET_KEYSTONE
> >  	help
> >  	  Reboot support for the KEYSTONE SoCs.
> >  
> > +config POWER_RESET_SPACEMIT_P1
> > +	tristate "SpacemiT P1 poweroff and reset driver"
> > +	depends on ARCH_SPACEMIT || COMPILE_TEST
> > +	depends on MFD_SPACEMIT_P1
> > +	default m
> default m if ARCH_SPACEMIT? Or default ARCH_SPACEMIT?
> I believe that reboot and shutdown are actually essential functionalities,
> so it might make more sense: default ARCH_SPACEMIT?

I don't think there's anything preventing it to be built as module by
default: even though it's "essential", it's unnecessary during kernel
and userspace startup, thus I see no reason to build it in the image.

Building it as module by default shrinks the kernel image, which most
distributions are willing to see, thus helps distro maintainers to
maintain the configuration.

The default value has been discussed in v2 of the series[1], where Emil,
Yixun have expressed preference on "default m". So do I here.

>                                       - Troy

Regards,
Yao Zi

[1]: https://lore.kernel.org/spacemit/aPXAyeDC7YXAketm@aurel32.net/

> > +	help
> > +	  This driver supports power-off and reset operations for the SpacemiT
> > +	  P1 PMIC.
> > +
> >  config POWER_RESET_SYSCON
> >  	bool "Generic SYSCON regmap reset driver"
> >  	depends on OF