public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Jack Xu <jack.xu@intel.com>,
	Suman Kumar Chakraborty <suman.kumar.chakraborty@intel.com>,
	Qianfeng Rong <rongqianfeng@vivo.com>,
	qat-linux@intel.com, linux-crypto@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: qat - use strscpy_pad to simplify buffer initialization
Date: Mon, 27 Oct 2025 10:19:41 +0200	[thread overview]
Message-ID: <aP8rHYq4I09pvhFa@smile.fi.intel.com> (raw)
In-Reply-To: <B981F95A-287C-44CF-8852-B4642E728975@linux.dev>

On Fri, Oct 24, 2025 at 08:47:02PM +0200, Thorsten Blum wrote:
> On 23. Oct 2025, at 20:44, Andy Shevchenko wrote:
> > On Thu, Oct 23, 2025 at 05:35:00PM +0200, Thorsten Blum wrote:
> >> On 22. Oct 2025, at 20:17, Andy Shevchenko wrote:
> >>> On Wed, Oct 22, 2025 at 02:36:19PM +0200, Thorsten Blum wrote:

...

> >> How about this?
> > 
> > LGTM, and that's what I had in mind, ...
> 
> I was about to submit v2, but checkpatch warns me about simple_strtoull:
> 
>   WARNING: simple_strtoull is obsolete, use kstrtoull instead
> 
> Any recommendations?

Yes, fix checkpatch as per commit 885e68e8b7b1 ("kernel.h: update comment about
simple_strto<foo>() functions") or ignore this false positive.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2025-10-27  8:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-22 12:36 [PATCH] crypto: qat - use strscpy_pad to simplify buffer initialization Thorsten Blum
2025-10-22 18:17 ` Andy Shevchenko
2025-10-22 18:29   ` Andy Shevchenko
2025-10-23 15:35   ` Thorsten Blum
2025-10-23 18:44     ` Andy Shevchenko
2025-10-24  8:50       ` Giovanni Cabiddu
2025-10-24  9:49         ` Andy Shevchenko
2025-10-24 18:47       ` Thorsten Blum
2025-10-27  8:19         ` Andy Shevchenko [this message]
2025-10-27  8:43           ` Thorsten Blum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aP8rHYq4I09pvhFa@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=giovanni.cabiddu@intel.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jack.xu@intel.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=qat-linux@intel.com \
    --cc=rongqianfeng@vivo.com \
    --cc=suman.kumar.chakraborty@intel.com \
    --cc=thorsten.blum@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox