Re: [PATCH] drm: sti: fix device leaks at component probe

Johan Hovold
2025-11-20T13:13:06Z

On Tue, Nov 04, 2025 at 12:21:27PM +0100, Johan Hovold wrote:
> On Fri, Oct 31, 2025 at 06:10:46PM +0100, Raphaël Gallais-Pou wrote:
>
> > Le Mon, Sep 22, 2025 at 02:20:12PM +0200, Johan Hovold a écrit :
> > > Make sure to drop the references taken to the vtg devices by
> > > of_find_device_by_node() when looking up their driver data during
> > > component probe.
> >
> > Markus suggested “Prevent device leak in of_vtg_find()” as commit
> > summary.
>
> Markus has gotten himself banned from the mailing lists some years ago
> and even if he is now back with a new mail address most of us still
> ignore him.
>
> I prefer the Subject as it stands since it captures when the leaks
> happens, but I don't mind mentioning of_vtg_find() instead if you
> insist.

Can this one be picked up for 6.19 or do you want me to respin?

> > > Note that holding a reference to a platform device does not prevent its
> > > driver data from going away so there is no point in keeping the
> > > reference after the lookup helper returns.
> > >
> > > Fixes: cc6b741c6f63 ("drm: sti: remove useless fields from vtg structure")
> > > Cc: stable@vger.kernel.org # 4.16
> > > Cc: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> > > Signed-off-by: Johan Hovold <johan@kernel.org>

Johan