From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E10F2DCF51 for ; Thu, 16 Oct 2025 20:28:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760646516; cv=none; b=A52zHh64QJZETN3vArOBzlYlZq+9eJNlpV117lmqskDyUdNSN9FfiT3RFzW3T6mQkH6Q4ZQBE7FSRnpRpaw9ENOMd9WH1ED1z0DcCcwjN26iuQm4bV06wDY90hJ4JdIbPbLgwm8AOy9qy2Vji1QoJ/qVDMGclunq67G7sUigxsA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760646516; c=relaxed/simple; bh=0Q40eCSagH0eBhvwze/WcBTb/mvhv4ZZ3cELPBlgvGA=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=YIYPV+mI5Lf+xA8z28jhag+FbOlZY6LbVfAjOZ5UdZIzSj2j6ePHWRnZGn42wPxvS4Q62X1yTc+gNujKgU6rv5J9psm56o7dQPxLGVFxzqeqX8Mr9CofvEBArSUW3wDpTG3y1DQ3dEN/3TjI55ByQd8yUbokvrVw7d/gdCXG57c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=f6uvRg7Q; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="f6uvRg7Q" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-32ee62ed6beso1772205a91.2 for ; Thu, 16 Oct 2025 13:28:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1760646514; x=1761251314; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=92VK8FOPojooOIWV+l2v1FHmJALxyLmlS2dAJ/3Uzy4=; b=f6uvRg7QQbShAivfWepdGkwuWfv1/xlwl8GJ/W5U9gBHGu/EbTYo6gYbdzwRff1Gpg q92Qp9UoC1EYYM13D0oS8pWUJzLLV6GmaMCDglMJ1Z3sUZ0BglDo3FVM7lcYjQRGQxm+ y/rHAt6PzaLZZnezHwfgQDKzVfQV1yIx2pCrMxt2YzkjfOvAGYzYLLy0NUsg9h+OuVjh ImFOlNTcqDKsgWR6Jj/mQnWNFVB/CQZXSjO4wYhE+PL/WRSwLNvPOtJPhMMwtTYrJcLp 62MFeG0zRX2KGjWsquojqKDaRpSR+x2irgd8jvH1fQzBm9lb3sjZagImQccvwbhg28g2 1+Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760646514; x=1761251314; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=92VK8FOPojooOIWV+l2v1FHmJALxyLmlS2dAJ/3Uzy4=; b=jssXtbaypkp2jWWdw/B7Kv/0xiDRKpPoPH+MB9m6L1AkIjAhURcQ8T2E+br5g5eqWI URpUd0F5dUv4q/rsxknHh+0KxSHTP1u70nYZhS3KX+RDNmXgeQz3MIakQYpqPFiEeu5/ MUXv2Afofd1uZANB8jtszLXGSUUWypl77w7uJI3eXPIVbB6qqBTaLkwVytRG0xnmfckK u3y0MkTAgOfzWsA8Cx0h2ZQercuAX3PbvIiXnkWI+rrg1Oye7vktnuN7N16Ng73y6Zys w99iFPTUdAsrp0/D5WMuQ157flzW1OK+1uNyr+XAQm/qlvFRd/5TjlSmFefxxL6Log48 3NSg== X-Forwarded-Encrypted: i=1; AJvYcCXF/vzLgF9fQw/Oih+uWHYdKuwt1N0i2gqcVWAtyDtvULLl7O1dKal+9EnwwOFlOO/cKmzj21uhhwDeIE0=@vger.kernel.org X-Gm-Message-State: AOJu0YwXohJdYyEfLh+WJg401dM1VlvadqbeJfYvvcUC+AXJ7H6rp4cf nyWlyMZbZ6SWgJQCyqMpoXsC9eGopFT+kQLJjFwSypj8qyC3dSkbO+9U+JlPaMW3knC0xLjm8oF TiBLyiQ== X-Google-Smtp-Source: AGHT+IG21/MmBPeuGnH22iEw5Q/v7OFmPy0dksEdBEvBnL6MuloU0P55WAZNWStQXjZRcej0BNndSKWVUlQ= X-Received: from pjbgz13.prod.google.com ([2002:a17:90b:ecd:b0:33b:51fe:1a72]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:4f:b0:330:6c5a:4af4 with SMTP id 98e67ed59e1d1-33bcf93fbd3mr1383934a91.35.1760646514081; Thu, 16 Oct 2025 13:28:34 -0700 (PDT) Date: Thu, 16 Oct 2025 13:28:32 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251016172853.52451-1-seanjc@google.com> Message-ID: Subject: Re: [PATCH v13 00/12] KVM: guest_memfd: Add NUMA mempolicy support From: Sean Christopherson To: Miguel Ojeda Cc: Miguel Ojeda , Marc Zyngier , Oliver Upton , Paolo Bonzini , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Ackerley Tng , Shivank Garg , David Hildenbrand , Fuad Tabba , Ashish Kalra , Vlastimil Babka Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Thu, Oct 16, 2025, Miguel Ojeda wrote: > On Thu, Oct 16, 2025 at 7:30=E2=80=AFPM Sean Christopherson wrote: > > > > Miguel, you got pulled in due to a one-line change to add a new iterato= r > > macros in .clang-format. >=20 > Thanks! >=20 > The macro is not in `include/`, right? That means that, currently, > when I rerun the command to update the list it will go away. Oh, I take it .clang-format is auto-generated? Is it a "formal" script, or= do you literally just run the grep command in the comment? # Taken from: # git grep -h '^#define [^[:space:]]*for_each[^[:space:]]*(' include/ t= ools/ \ # | sed "s,^#define \([^[:space:]]*for_each[^[:space:]]*\)(.*$, - '\1'= ," \ # | LC_ALL=3DC sort -u > If that is correct, and you want to have it in the list, I don't think I care if it's in the list? I honestly don't know for sure, = because it's entirely possible I'm consuming .clang-format without knowing it. I a= dded the entry based on someone else's request. Ackerley? > then we should add e.g. `virt/` there or similar, or we could have a few > separate lines at the top that are independent of the ones generated > by the command. Is it possible, and sensible, to have per-subsystem .clang-format files? K= VM (virt/kvm) and KVM x86 (arch/x86/kvm) both have has several for_each macros= , pretty much all of which are more interesting than kvm_gmem_for_each_file()= . Adding arch/x86/kvm to the "script" in .clang-format feels wrong. E.g. $ git grep -h '^#define [^[:space:]]*for_each[^[:space:]]*(' arch/x86/kvm/ = | \ sed "s,^#define \([^[:space:]]*for_each[^[:space:]]*\)(.*$, - '\1'," | \ LC_ALL=3DC sort -u - '__for_each_rmap_spte' - '__for_each_tdp_mmu_root' - '__for_each_tdp_mmu_root_yield_safe' - 'for_each_gfn_valid_sp_with_gptes' - 'for_each_rmap_spte' - 'for_each_rmap_spte_lockless' - 'for_each_shadow_entry' - 'for_each_shadow_entry_lockless' - 'for_each_shadow_entry_using_root' - 'for_each_slot_rmap_range' - 'for_each_sp' - 'for_each_tdp_mmu_root_rcu' - 'for_each_tdp_mmu_root_yield_safe' - 'for_each_tdp_pte' - 'for_each_tdp_pte_min_level' - 'for_each_tdp_pte_min_level_all' - 'for_each_valid_sp' - 'for_each_valid_tdp_mmu_root' - 'for_each_valid_tdp_mmu_root_yield_safe' - 'kvm_for_each_pmc' - 'tdp_root_for_each_leaf_pte' - 'tdp_root_for_each_pte'