From: Christoph Hellwig <hch@infradead.org>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Christoph Hellwig <hch@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-block@vger.kernel.org
Subject: Re: [GIT PULL] block-bio_iov_iter_export
Date: Mon, 20 Oct 2025 07:54:03 -0700 [thread overview]
Message-ID: <aPZNC8bKIzRmFJ21@infradead.org> (raw)
In-Reply-To: <wrcaluw3pxx65tgznv5z3td3xb2tdf6rwucze5sy7bqrutj4jp@srde54eo3iyz>
On Mon, Oct 20, 2025 at 10:49:57AM -0400, Kent Overstreet wrote:
> Christoph, I don't know what you're claiming here. I see no tweaks in
> the original patch, that's all code I wrote.
Then look closer.
> There was no need for you to drop the EXPORT_SYMBOL.
> What I want to know is, is this going to become a pattern?
Of course there was. The kernel doesn't keep unused code around,
including symbols. So anything that is unused will eventually be
garbage collected. There's even folks around that run scripts and
automate it (David Alan Gilbert is the most active one currently).
> I can vendorize this one function, but If you're going to make a habit
> of ripping out exports and functionality bcachefs depends on, I can't
> expect I'll always be able to.
I'm not sure why you're turning this personal and singling me out.
Yes, unused exports and code are removed all the time, and that's a
feature and not a bug.
next prev parent reply other threads:[~2025-10-20 14:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 16:39 [GIT PULL] block-bio_iov_iter_export Kent Overstreet
2025-10-17 6:13 ` Christoph Hellwig
2025-10-17 13:31 ` Kent Overstreet
2025-10-20 9:35 ` Christoph Hellwig
2025-10-20 12:56 ` Kent Overstreet
2025-10-20 13:21 ` Christoph Hellwig
2025-10-20 14:49 ` Kent Overstreet
2025-10-20 14:54 ` Christoph Hellwig [this message]
2025-10-20 16:42 ` Kent Overstreet
2025-10-20 15:13 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPZNC8bKIzRmFJ21@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox