From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: guest_memfd: Drop a superfluous local var in kvm_gmem_fault_user_mapping()
Date: Mon, 20 Oct 2025 08:51:21 -0700 [thread overview]
Message-ID: <aPZaeU1PGQFkUSHE@google.com> (raw)
In-Reply-To: <176055117173.1528469.2261818917462419157.b4-ty@google.com>
On Wed, Oct 15, 2025, Sean Christopherson wrote:
> On Tue, 07 Oct 2025 15:27:33 -0700, Sean Christopherson wrote:
> > Drop the local "int err" that's buried in the middle guest_memfd's user
> > fault handler to avoid the potential for variable shadowing, e.g. if an
> > "err" variable were also declared at function scope.
> >
> > No functional change intended.
> >
> >
> > [...]
>
> Applied to kvm-x86 gmem, thanks!
>
> [1/1] KVM: guest_memfd: Drop a superfluous local var in kvm_gmem_fault_user_mapping()
> https://github.com/kvm-x86/linux/commit/c1168f24b444
FYI, I rebased this onto 6.18-rc2 to avoid a silly merge. New hash:
[1/1] KVM: guest_memfd: Drop a superfluous local var in kvm_gmem_fault_user_mapping()
https://github.com/kvm-x86/linux/commit/5f3e10797ab8
prev parent reply other threads:[~2025-10-20 15:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 22:27 [PATCH] KVM: guest_memfd: Drop a superfluous local var in kvm_gmem_fault_user_mapping() Sean Christopherson
2025-10-09 23:46 ` Ackerley Tng
2025-10-10 22:11 ` Sean Christopherson
2025-10-10 22:33 ` Ackerley Tng
2025-10-15 18:02 ` Sean Christopherson
2025-10-20 15:51 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPZaeU1PGQFkUSHE@google.com \
--to=seanjc@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox