public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dominique Martinet <asmadeus@codewreck.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Song Liu <song@kernel.org>,
	Andrii Nakryiko <andrii.nakryiko@gmail.com>,
	Eric Van Hensbergen <ericvh@kernel.org>,
	Latchesar Ionkov <lucho@ionkov.net>,
	Christian Schoenebeck <linux_oss@crudebyte.com>,
	Tingmao Wang <m@maowtm.org>, Alexei Starovoitov <ast@kernel.org>,
	linux-kernel@vger.kernel.org, v9fs@lists.linux.dev,
	bpf@vger.kernel.org
Subject: [GIT PULL] 9p cache=mmap regression fix (for 6.18-rc3)
Date: Wed, 22 Oct 2025 08:16:56 +0900	[thread overview]
Message-ID: <aPgUaFE1oUq8e1F-@codewreck.org> (raw)
In-Reply-To: <CAHzjS_s5EzJkvTqi73XS_9bBsaGuXu1zQ4jOLgcpC9vmJ7FoaA@mail.gmail.com>

Hi Linus,

We had a regression with cache=mmap that impacted quite a few people so
I'm sending a fix less than a couple of hours after making the commit.

If it turns out there are other side effects I'd suggest just reverting
commit 290434474c33 ("fs/9p: Refresh metadata in d_revalidate for
uncached mode too") first, but the fix is rather minimal so I think it's
ok to try falling forward -- let me know if you prefer a revert and I'll
send one instead (there's a minor conflict)

Thanks to Sung Liu for the minimal reproducer and testing, as well as
Alexei/Andrii and everyone else who looked at it.



The following changes since commit 211ddde0823f1442e4ad052a2f30f050145ccada:

  Linux 6.18-rc2 (2025-10-19 15:19:16 -1000)

are available in the Git repository at:

  https://github.com/martinetd/linux tags/9p-for-6.18-rc3

for you to fetch changes up to 2776e27d404684bc43acf023d7ca15255e96b3e3:

  fs/9p: don't use cached metadata in revalidate for cache=mmap (2025-10-22 08:04:05 +0900)

----------------------------------------------------------------
Fix regression with cache=mmap in 6.18-rc1

Will do some more testing as time allows but this fixes the immediate
issue minimally (only impacts cache=mmap), and is therefore an
improvement good enough to send right away.

----------------------------------------------------------------
Dominique Martinet (1):
      fs/9p: don't use cached metadata in revalidate for cache=mmap

 fs/9p/vfs_dentry.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

-- 
Dominique Martinet | Asmadeus

  reply	other threads:[~2025-10-21 23:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-21 22:09 [PATCH] fs/9p: don't use cached metadata in revalidate for cache=mmap Dominique Martinet via B4 Relay
2025-10-21 22:46 ` Song Liu
2025-10-21 23:16   ` Dominique Martinet [this message]
2025-10-21 23:34     ` [GIT PULL] 9p cache=mmap regression fix (for 6.18-rc3) Tingmao Wang
2025-10-22  5:38       ` Dominique Martinet
2025-10-22 15:17         ` pr-tracker-bot
2025-10-21 23:18 ` [PATCH] fs/9p: don't use cached metadata in revalidate for cache=mmap Tingmao Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPgUaFE1oUq8e1F-@codewreck.org \
    --to=asmadeus@codewreck.org \
    --cc=andrii.nakryiko@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=ericvh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux_oss@crudebyte.com \
    --cc=lucho@ionkov.net \
    --cc=m@maowtm.org \
    --cc=song@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=v9fs@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox