From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 322527082A for ; Wed, 22 Oct 2025 00:18:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761092323; cv=none; b=umX/e6fNvkFjSKZ8ElzpUqV3eUWGWcx0+FviTMYvtQTNl3JG0jVz0Kda/4MQUxtL/k5BjIySSMJFgIe8qL3i5BxG8zSkZgcONpqHnFMJ8fhhX14AnZnlZ91MBbiPva0dBZD0uFAvJ8J5OfGWiTQB7nqel6zoZoLEx0m2o+hZrtM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761092323; c=relaxed/simple; bh=e7zZqGzrVyuJ5QFyUVE7eGJWKcfl4COyVHk9MxNeNKI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ppfo/mMTiTznZQZewWViep6jOjvUolBF+bsxZcNbwg/RpRcezztsIiETGY58tozqcc+qEJse7KmFNib+EvwCPjEPkuShAfAh7h6SwLbl4V3MNZmmHCs3VXv7TqPbOBc7dXl2BotAi4/VEGcSs6H3eSjh+mm10dT/04UXVxFEx3o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LEYxaRC6; arc=none smtp.client-ip=209.85.128.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LEYxaRC6" Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-78356c816fdso68227407b3.3 for ; Tue, 21 Oct 2025 17:18:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761092320; x=1761697120; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/VVHhrbKGyn2rHkoA+yo5pqhCOh1qQTtBCOhpEVSIKI=; b=LEYxaRC6RrM323rjsaoom5Qmq/bAc2SaTJQX8GJ41fF9wS6dF+ydCMuObV/5vRa9eB SYzYEkaIUsxJnYJGDOSck7f5EU9vx9otxlhq1x+6sXovUgcPoHhzkS1/sr+MeTTofOqm kaqUIhe3CEayD/uRA/QRjxQKOf5/hfvNSSFokoiA062H/g1f6d4cgxhk8wQ2qHOqAWA1 eVHfFwRFvzlDceNZFLxCxEXtyF1o/6x4+magzUtAbYoQ1/0Hwm2zFzVNHt/0gaLM4WR/ +Bg6rdX7+JB7kTTKBRV1FQh/ebFcOfaNMgNs1sN5dVUKU0p7jMbVBrQMcaEqRjUmbe0p fT4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761092320; x=1761697120; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/VVHhrbKGyn2rHkoA+yo5pqhCOh1qQTtBCOhpEVSIKI=; b=vDByU7NfGe8bfaCT8fZaQtD6xt/2pS3agF9d1odcGp6jvsD7nSMYMHHntzh+QvRGZ6 KOhoamQDXLYeaYqy6EP/0dSHOe9Mlegphslys1RQT/o7idFICWUde1fecsrKXvuCCj9H +y5OvWbaBIp33KZeR8z9IlLsWYV1TewovHjH73sclKAREHU9y8JOU6UHi+KtQJNCiZHW RcqA007dp7ssRUgNpC62Gp95e04Nj65k3JtGV4dp38AmG4SlIbiQk8AGqHaU4Cg8knzM UqFMJPutYq8phTE5+njXrZTRq0XFHwwymEMULQEr+dSmopmoPvOu3GDBmTHvpo4Qy1Jd sg5A== X-Forwarded-Encrypted: i=1; AJvYcCXeHDsTV/8tKBpYpe/BGAtsIGVlMrTWyNwL+boRbrF44xz4DHMWf8GGoq81qePrNE6jElBcowkq8dc40wY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6tvPZQEQsJcP5Td5x0HBOoBZWrKek/NsFuVFcNwXiXH0JIWJB vdAnTKmIo32pCInPeQ+t/0dJ0NhWccFnVSGqfA5qAmdcnDzOReS5WisL X-Gm-Gg: ASbGncttUVK/yF0dodreQOvNaybfh1SP0K20Qd2OJBDkGeavXAfO0pq7N4UN8lTEb/u 8uIXgTUUKtly0PmcUDwwHmDdjgQ9NLGvcR1znpUyFd+J+Lynzv2kZvHeZgsLqOLapLwd8MX9RNm ugkwVsipqlagGsI7xLpTOIaKqRgBnHdgAcR6yL/k9UuQc3QaoIe6VPXt6CVKyjX98xQ578pmCCt eLYtHdMVXGH4DboonecFkVjSIUpAoI2r/DKvNYWJ2q1kZfMcjOb9WWFbwatniPEFBEqi8sOt/20 pdZ3eYsW7rpZdxjrHdMPGPckS+l/D8FsqsBPIYAXlMVQHvasm0J3ftTlQzQTEPQhvdxICjSAct/ ePRVoABNqWV5bJYl5Yz9za4JUXHh5kNM4y7ki3YkdnA20lZzspuKKN5uQjgG+gabB9v/U47UBHR 8DCzoo/KAjkg6NM6VaH0mmCzLdzV/WxQeAEQ4cX/Qat0r8nps= X-Google-Smtp-Source: AGHT+IEqYiiuWqadmrSa+ocB1xo5kZsyd7pE12wgODlf319TseLh48deAbNiLMyHfUUvkPdfF1Gc1A== X-Received: by 2002:a05:690c:45c3:b0:783:7266:58ef with SMTP id 00721157ae682-7837266619dmr152519147b3.5.1761092320133; Tue, 21 Oct 2025 17:18:40 -0700 (PDT) Received: from devvm11784.nha0.facebook.com ([2a03:2880:25ff:59::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7846a6cc14bsm32765777b3.60.2025.10.21.17.18.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Oct 2025 17:18:39 -0700 (PDT) Date: Tue, 21 Oct 2025 17:18:38 -0700 From: Bobby Eshleman To: Jakub Kicinski Cc: Stefano Garzarella , Shuah Khan , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Bryan Tan , Vishnu Dasa , Broadcom internal kernel review list , virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, berrange@redhat.com, Bobby Eshleman Subject: Re: [PATCH net-next v7 08/26] selftests/vsock: improve logging in vmtest.sh Message-ID: References: <20251021-vsock-vmtest-v7-0-0661b7b6f081@meta.com> <20251021-vsock-vmtest-v7-8-0661b7b6f081@meta.com> <20251021170147.7c0d96b2@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251021170147.7c0d96b2@kernel.org> On Tue, Oct 21, 2025 at 05:01:47PM -0700, Jakub Kicinski wrote: > On Tue, 21 Oct 2025 16:46:51 -0700 Bobby Eshleman wrote: > > Improve usability of logging functions. Remove the test name prefix from > > logging functions so that logging calls can be made deeper into the call > > stack without passing down the test name or setting some global. Teach > > log function to accept a LOG_PREFIX variable to avoid unnecessary > > argument shifting. > > > > Remove log_setup() and instead use log_host(). The host/guest prefixes > > are useful to show whether a failure happened on the guest or host side, > > but "setup" doesn't really give additional useful information. Since all > > log_setup() calls happen on the host, lets just use log_host() instead. > > And this cannot be posted separately / before the rest? I don't think > this series has to be 26 patches long. > > I'm dropping this from PW, please try to obey the local customs :( Sorry about that, since these selftest changes were all part of one messier patch in the previous rev, I wasn't sure if the custom was to keep them in the original series or break them out into another series. I'll break them out and resend.