From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Petre Rodan <petre.rodan@subdimension.ro>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"kernel test robot" <lkp@intel.com>
Subject: Re: [PATCH] iio: accel: bma220: move set_wdt() out of bma220_core
Date: Wed, 22 Oct 2025 14:50:18 +0300 [thread overview]
Message-ID: <aPjE-n0wKNIJd2-M@smile.fi.intel.com> (raw)
In-Reply-To: <20251021-bma220_set_wdt_move-v1-1-6c99f6fd951c@subdimension.ro>
On Tue, Oct 21, 2025 at 01:31:49PM +0300, Petre Rodan wrote:
> Move bma220_set_wdt() into bma220_i2c.c instead of using a conditional
> based on i2c_verify_client() in bma220_core.c that would make core
> always depend on the i2c module.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
But Kconfig for this driver is a bit strange. Usually we do other way around,
i.e. make user visible selection of the glue drivers, while core is selected if
at least one of the leaf driver selected by the user.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-10-22 11:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 10:31 [PATCH] iio: accel: bma220: move set_wdt() out of bma220_core Petre Rodan
2025-10-22 11:50 ` Andy Shevchenko [this message]
2025-10-23 17:23 ` Jonathan Cameron
2025-10-23 18:37 ` Andy Shevchenko
2025-10-27 5:27 ` Petre Rodan
2025-10-27 14:11 ` Jonathan Cameron
2025-10-27 14:10 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPjE-n0wKNIJd2-M@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nuno.sa@analog.com \
--cc=petre.rodan@subdimension.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox