From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Haotian Zhang <vulab@iscas.ac.cn>,
Lixu Zhang <lixu.zhang@intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: ljca: Fix duplicated IRQ mapping
Date: Thu, 23 Oct 2025 11:48:43 +0300 [thread overview]
Message-ID: <aPnr66W9J_VnpYgE@smile.fi.intel.com> (raw)
In-Reply-To: <CAMRc=MekWJPnhwLn9z4=yqC4Pjyf2xd7teKCLTUEmnBCDLeROA@mail.gmail.com>
On Thu, Oct 23, 2025 at 10:09:05AM +0200, Bartosz Golaszewski wrote:
> On Thu, Oct 23, 2025 at 9:02 AM Haotian Zhang <vulab@iscas.ac.cn> wrote:
> >
> > The generic_handle_domain_irq() function resolves the hardware IRQ
> > internally. The driver performed a duplicative mapping by calling
> > irq_find_mapping() first, which could lead to an RCU stall.
> >
> > Delete the redundant irq_find_mapping() call and pass the hardware IRQ
> > directly to generic_handle_domain_irq().
>
> Andy: this looks correct to me and you already sent your PR with
> fixes, should I take it directly into my fixes tree for v6.18-rc3?
Yes, please. This driver is out of my scope, it should have its own maintainers
(from Intel). If not, I may rise this problem internally.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-10-23 8:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 7:02 [PATCH] gpio: ljca: Fix duplicated IRQ mapping Haotian Zhang
2025-10-23 8:09 ` Bartosz Golaszewski
2025-10-23 8:48 ` Andy Shevchenko [this message]
2025-10-23 8:58 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPnr66W9J_VnpYgE@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixu.zhang@intel.com \
--cc=sakari.ailus@linux.intel.com \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox