public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Schier <nsc@kernel.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Alexander Potapenko <glider@google.com>,
	Marco Elver <elver@google.com>,
	Dmitry Vyukov <dvyukov@google.com>, Kees Cook <kees@kernel.org>,
	kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org,
	llvm@lists.linux.dev, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] KMSAN: Restore dynamic check for '-fsanitize=kernel-memory'
Date: Thu, 23 Oct 2025 21:50:34 +0200	[thread overview]
Message-ID: <aPqHCrC0JPwQynWd@levanger> (raw)
In-Reply-To: <20251023-fix-kmsan-check-s390-clang-v1-1-4e6df477a4cc@kernel.org>

On Thu, Oct 23, 2025 at 09:01:29PM +0200, Nathan Chancellor wrote:
> Commit 5ff8c11775c7 ("KMSAN: Remove tautological checks") changed
> CONFIG_HAVE_KMSAN_COMPILER from a dynamic check for
> '-fsanitize=kernel-memory' to just being true for CONFIG_CC_IS_CLANG.
> This missed the fact that not all architectures supported
> '-fsanitize=kernel-memory' at the same time. For example, SystemZ / s390
> gained support for KMSAN in clang-18 [1], so builds with clang-15
> through clang-17 can select KMSAN but they error with:
> 
>   clang-16: error: unsupported option '-fsanitize=kernel-memory' for target 's390x-unknown-linux-gnu'
> 
> Restore the cc-option check for '-fsanitize=kernel-memory' to make sure
> the compiler target properly supports '-fsanitize=kernel-memory'. The
> check for '-msan-disable-checks=1' does not need to be restored because
> all supported clang versions for building the kernel support it.
> 
> Fixes: 5ff8c11775c7 ("KMSAN: Remove tautological checks")
> Link: https://github.com/llvm/llvm-project/commit/a3e56a8792ffaf3a3d3538736e1042b8db45ab89 [1]
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/r/202510220236.AVuXXCYy-lkp@intel.com/
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
> I plan to take this via kbuild-fixes for 6.18-rc3 or -rc4.
> ---
>  lib/Kconfig.kmsan | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/Kconfig.kmsan b/lib/Kconfig.kmsan
> index 7251b6b59e69..cae1ddcc18e1 100644
> --- a/lib/Kconfig.kmsan
> +++ b/lib/Kconfig.kmsan
> @@ -3,7 +3,7 @@ config HAVE_ARCH_KMSAN
>  	bool
>  
>  config HAVE_KMSAN_COMPILER
> -	def_bool CC_IS_CLANG
> +	def_bool $(cc-option,-fsanitize=kernel-memory)
>  
>  config KMSAN
>  	bool "KMSAN: detector of uninitialized values use"
> 
> ---
> base-commit: 211ddde0823f1442e4ad052a2f30f050145ccada
> change-id: 20251023-fix-kmsan-check-s390-clang-190d37bbcff3
> 
> Best regards,
> --  
> Nathan Chancellor <nathan@kernel.org>
> 

Thanks!

Acked-by: Nicolas Schier <nsc@kernel.org>


-- 
Nicolas

  reply	other threads:[~2025-10-23 20:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-23 19:01 [PATCH] KMSAN: Restore dynamic check for '-fsanitize=kernel-memory' Nathan Chancellor
2025-10-23 19:50 ` Nicolas Schier [this message]
2025-10-23 22:54 ` Nathan Chancellor
2025-10-23 23:01   ` Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPqHCrC0JPwQynWd@levanger \
    --to=nsc@kernel.org \
    --cc=dvyukov@google.com \
    --cc=elver@google.com \
    --cc=glider@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=llvm@lists.linux.dev \
    --cc=nathan@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox