public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
	Akhilesh Patil <akhilesh@ee.iitb.ac.in>,
	jic23@kernel.org, dlechner@baylibre.com, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, nuno.sa@analog.com,
	andy@kernel.org, marcelo.schmitt1@gmail.com,
	vassilisamir@gmail.com, salah.triki@gmail.com,
	skhan@linuxfoundation.org, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	akhileshpatilvnit@gmail.com
Subject: Re: [PATCH 2/2] iio: pressure: adp810: Add driver for adp810 sensor
Date: Fri, 24 Oct 2025 11:34:36 +0300	[thread overview]
Message-ID: <aPs6HAJabFMRzX9Y@smile.fi.intel.com> (raw)
In-Reply-To: <c45309cf-bd2c-41fe-b893-7e0a91de84a8@kernel.org>

On Fri, Oct 24, 2025 at 08:18:21AM +0200, Krzysztof Kozlowski wrote:
> On 23/10/2025 20:51, Andy Shevchenko wrote:
> > On Sun, Oct 12, 2025 at 05:12:26AM +0200, Krzysztof Kozlowski wrote:
> >> On 11/10/2025 16:10, Andy Shevchenko wrote:
> >>> On Sat, Oct 11, 2025 at 3:25 PM Akhilesh Patil <akhilesh@ee.iitb.ac.in> wrote:
> >>>> +AOSONG ADP810 DIFFERENTIAL PRESSURE SENSOR DRIVER
> >>>> +M:     Akhilesh Patil <akhilesh@ee.iitb.ac.in>
> >>>> +L:     linux-iio@vger.kernel.org
> >>>> +S:     Maintained
> >>>> +F:     Documentation/devicetree/bindings/iio/pressure/aosong,adp810.yaml
> >>>> +F:     drivers/iio/pressure/adp810.c
> >>>
> >>> Some tools will report an orphaned yaml file if you apply patch 1
> >>> without patch 2.
> >>
> >> You mean checkpatch? That warning is not really relevant. Adding
> >> maintainers entry here for both files is perfectly fine and correct.
> > 
> > It's relevant as long as I see (false positive) warnings from it. Can somebody
> 
> 
> No, it is not relevant. Just because tool is inefficient does not allow
> you to point such nitpicks. You as reviewer are supposed to find
> difference which checkpatch warnings are important and which are not and
> DO NOT bother contributors with useless points that there is some
> orphaned file according to checkpatch.
> 
> 
> > shut the checkpatch up about missing DT files in the MAINTAINERS?
> 
> That would be great but, if no one does it your comments on "orphaned
> file" are counter productive.

Something like this?

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 6729f18e5654..818b49d314ce 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3441,11 +3441,17 @@ sub process {
 		     ($line =~ /\{\s*([\w\/\.\-]*)\s*\=\>\s*([\w\/\.\-]*)\s*\}/ &&
 		      (defined($1) || defined($2))))) {
 			$is_patch = 1;
-			$reported_maintainer_file = 1;
-			WARN("FILE_PATH_CHANGES",
-			     "added, moved or deleted file(s), does MAINTAINERS need updating?\n" . $herecurr);
+			# DT bindings are incorporate maintainer information, no need to report
+			if ($realfile !~ m@^Documentation/devicetree/bindings/@)) {
+				$reported_maintainer_file = 1;
+				WARN("FILE_PATH_CHANGES",
+				     "added, moved or deleted file(s), does MAINTAINERS need updating?\n" . $herecurr);
+			}
 		}
 
+		    ($realfile =~ m@^Documentation/devicetree/bindings/.*\.txt$@)) {
+			if ($realfile =~ m@^include/asm/@) {
+
 # Check for adding new DT bindings not in schema format
 		if (!$in_commit_log &&
 		    ($line =~ /^new file mode\s*\d+\s*$/) &&

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2025-10-24  8:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-11 12:24 [PATCH 0/2] iio: pressure: add driver and bindings for adp810 Akhilesh Patil
2025-10-11 12:25 ` [PATCH 1/2] dt-bindings: iio: pressure: Add Aosong adp810 Akhilesh Patil
2025-10-12  3:13   ` Krzysztof Kozlowski
2025-10-13 15:25     ` Akhilesh Patil
2025-10-11 12:25 ` [PATCH 2/2] iio: pressure: adp810: Add driver for adp810 sensor Akhilesh Patil
2025-10-11 14:10   ` Andy Shevchenko
2025-10-12  3:12     ` Krzysztof Kozlowski
2025-10-23 18:51       ` Andy Shevchenko
2025-10-24  6:18         ` Krzysztof Kozlowski
2025-10-24  8:34           ` Andy Shevchenko [this message]
2025-10-24  8:37             ` Andy Shevchenko
2025-10-24 17:50               ` Akhilesh Patil
2025-10-27  8:24                 ` Andy Shevchenko
2025-10-27  8:45                   ` Akhilesh Patil
2025-10-13 14:46     ` Akhilesh Patil
2025-10-23 18:58       ` Andy Shevchenko
2025-10-25  5:55         ` Akhilesh Patil
2025-10-12 19:36   ` Jonathan Cameron
2025-10-13 16:06     ` Akhilesh Patil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPs6HAJabFMRzX9Y@smile.fi.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=akhilesh@ee.iitb.ac.in \
    --cc=akhileshpatilvnit@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.schmitt1@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=salah.triki@gmail.com \
    --cc=skhan@linuxfoundation.org \
    --cc=vassilisamir@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox